mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-09 13:38:53 +00:00
shankar0123
7013227a34
Closes T-1 (cat-s2-c24a548076c6) — frontend page-level Vitest coverage was
3 of 28 pages pre-T-1. T-1 lifts that to 11 of 28 (39%) by writing focused
behavior tests for the 8 highest-leverage pages.
Tests added:
- CertificatesPage.test.tsx (6 cases) — F-1 filter+pagination contract:
team_id / expires_before / sort param wiring, page=1 reset on filter
change, page+per_page always present in getCertificates params.
- PoliciesPage.test.tsx (4 cases) — D-006/D-008 TitleCase contract:
list render, severity badge, toggle-enabled inversion, delete confirm.
- IssuersPage.test.tsx (3 cases) — D-2 phantom-trim + B-1 EditIssuer:
list render, StatusBadge derives from enabled, Test fires
testIssuerConnection.
- TargetsPage.test.tsx (3 cases) — D-2 phantom-trim:
list render, Status derives from enabled, Delete fires deleteTarget.
- AgentsPage.test.tsx (3 cases) — D-2 phantom-trim + heartbeatStatus:
list render, undefined last_heartbeat_at -> Offline,
listRetiredAgents lazy-loaded.
- AgentDetailPage.test.tsx (3 cases) — D-2 phantom-trim:
fetches by URL :id, Registered row reads registered_at,
Capabilities + Tags sections absent.
- OwnersPage.test.tsx (3 cases) — B-1 EditOwnerModal closure:
list render, Edit opens modal, Save fires updateOwner.
- TeamsPage.test.tsx (2 cases) — B-1 EditTeamModal closure.
- AgentGroupsPage.test.tsx (2 cases) — B-1 EditAgentGroupModal closure.
- RenewalPoliciesPage.test.tsx (3 cases) — B-1 brand-new-page closure:
list + alert_thresholds_days display, Create modal, Edit modal.
- DiscoveryPage.test.tsx (3 cases) — I-2 claim/dismiss closure:
list render, status filter wiring, Dismiss fires dismissDiscoveredCertificate.
CI guardrail: .github/workflows/ci.yml step "Frontend page-coverage
regression guard (T-1)" blocks new pages from landing without sibling
.test.tsx unless added to a 14-name deferred allowlist with one-line
"why deferred" justifications.
Net coverage: 13 page-level vitest cases -> ~35 page-level vitest cases
across 14 files (was 3); total project tests 302 -> 337.
See coverage-gap-audit-2026-04-24-v5/unified-audit.md
cat-s2-c24a548076c6 for closure rationale.
88 lines
2.9 KiB
TypeScript
88 lines
2.9 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
import { render, screen, waitFor, fireEvent, cleanup } from '@testing-library/react';
|
|
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
|
|
import { MemoryRouter } from 'react-router-dom';
|
|
import type { ReactNode } from 'react';
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// T-1 closure (cat-s2-c24a548076c6): AgentGroupsPage Vitest coverage.
|
|
//
|
|
// Pins the B-1 closure: Edit button opens EditAgentGroupModal which calls
|
|
// updateAgentGroup(id, payload). Mirrors the OwnersPage / TeamsPage pattern.
|
|
// -----------------------------------------------------------------------------
|
|
|
|
vi.mock('../api/client', () => ({
|
|
getAgentGroups: vi.fn(),
|
|
createAgentGroup: vi.fn(),
|
|
updateAgentGroup: vi.fn(),
|
|
deleteAgentGroup: vi.fn(),
|
|
getAgentGroupMembers: vi.fn(),
|
|
}));
|
|
|
|
import AgentGroupsPage from './AgentGroupsPage';
|
|
import * as client from '../api/client';
|
|
|
|
function renderWithQuery(ui: ReactNode) {
|
|
const qc = new QueryClient({
|
|
defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } },
|
|
});
|
|
return render(
|
|
<QueryClientProvider client={qc}>
|
|
<MemoryRouter>{ui}</MemoryRouter>
|
|
</QueryClientProvider>,
|
|
);
|
|
}
|
|
|
|
const group = {
|
|
id: 'ag-linux-prod',
|
|
name: 'Linux Prod Fleet',
|
|
description: 'Linux amd64 in prod CIDR',
|
|
match_os: 'linux',
|
|
match_architecture: 'amd64',
|
|
match_ip_cidr: '10.0.0.0/24',
|
|
match_version: '',
|
|
enabled: true,
|
|
created_at: new Date().toISOString(),
|
|
updated_at: new Date().toISOString(),
|
|
};
|
|
|
|
describe('AgentGroupsPage — T-1 page coverage', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
cleanup();
|
|
vi.mocked(client.getAgentGroups).mockResolvedValue({
|
|
data: [group],
|
|
total: 1,
|
|
page: 1,
|
|
per_page: 50,
|
|
});
|
|
vi.mocked(client.updateAgentGroup).mockResolvedValue(group);
|
|
});
|
|
|
|
it('renders the agent groups list when getAgentGroups resolves', async () => {
|
|
renderWithQuery(<AgentGroupsPage />);
|
|
await waitFor(() => {
|
|
expect(screen.getByText('Linux Prod Fleet')).toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
it('Edit + Save calls updateAgentGroup with the right payload (B-1 closure)', async () => {
|
|
renderWithQuery(<AgentGroupsPage />);
|
|
await waitFor(() => {
|
|
expect(screen.getByText('Linux Prod Fleet')).toBeInTheDocument();
|
|
});
|
|
fireEvent.click(await screen.findByRole('button', { name: 'Edit' }));
|
|
await waitFor(() => {
|
|
expect(screen.getByText('Edit Agent Group')).toBeInTheDocument();
|
|
});
|
|
|
|
fireEvent.click(await screen.findByRole('button', { name: /Save Changes/ }));
|
|
await waitFor(() => {
|
|
expect(client.updateAgentGroup).toHaveBeenCalled();
|
|
});
|
|
const [id, payload] = vi.mocked(client.updateAgentGroup).mock.calls[0]!;
|
|
expect(id).toBe('ag-linux-prod');
|
|
expect(payload).toMatchObject({ name: 'Linux Prod Fleet', match_os: 'linux' });
|
|
});
|
|
});
|