mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-09 19:18:56 +00:00
7013227a34
Closes T-1 (cat-s2-c24a548076c6) — frontend page-level Vitest coverage was
3 of 28 pages pre-T-1. T-1 lifts that to 11 of 28 (39%) by writing focused
behavior tests for the 8 highest-leverage pages.
Tests added:
- CertificatesPage.test.tsx (6 cases) — F-1 filter+pagination contract:
team_id / expires_before / sort param wiring, page=1 reset on filter
change, page+per_page always present in getCertificates params.
- PoliciesPage.test.tsx (4 cases) — D-006/D-008 TitleCase contract:
list render, severity badge, toggle-enabled inversion, delete confirm.
- IssuersPage.test.tsx (3 cases) — D-2 phantom-trim + B-1 EditIssuer:
list render, StatusBadge derives from enabled, Test fires
testIssuerConnection.
- TargetsPage.test.tsx (3 cases) — D-2 phantom-trim:
list render, Status derives from enabled, Delete fires deleteTarget.
- AgentsPage.test.tsx (3 cases) — D-2 phantom-trim + heartbeatStatus:
list render, undefined last_heartbeat_at -> Offline,
listRetiredAgents lazy-loaded.
- AgentDetailPage.test.tsx (3 cases) — D-2 phantom-trim:
fetches by URL :id, Registered row reads registered_at,
Capabilities + Tags sections absent.
- OwnersPage.test.tsx (3 cases) — B-1 EditOwnerModal closure:
list render, Edit opens modal, Save fires updateOwner.
- TeamsPage.test.tsx (2 cases) — B-1 EditTeamModal closure.
- AgentGroupsPage.test.tsx (2 cases) — B-1 EditAgentGroupModal closure.
- RenewalPoliciesPage.test.tsx (3 cases) — B-1 brand-new-page closure:
list + alert_thresholds_days display, Create modal, Edit modal.
- DiscoveryPage.test.tsx (3 cases) — I-2 claim/dismiss closure:
list render, status filter wiring, Dismiss fires dismissDiscoveredCertificate.
CI guardrail: .github/workflows/ci.yml step "Frontend page-coverage
regression guard (T-1)" blocks new pages from landing without sibling
.test.tsx unless added to a 14-name deferred allowlist with one-line
"why deferred" justifications.
Net coverage: 13 page-level vitest cases -> ~35 page-level vitest cases
across 14 files (was 3); total project tests 302 -> 337.
See coverage-gap-audit-2026-04-24-v5/unified-audit.md
cat-s2-c24a548076c6 for closure rationale.
91 lines
3.1 KiB
TypeScript
91 lines
3.1 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
import { render, screen, waitFor, cleanup } from '@testing-library/react';
|
|
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
|
|
import { MemoryRouter, Route, Routes } from 'react-router-dom';
|
|
import type { ReactNode } from 'react';
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// T-1 closure (cat-s2-c24a548076c6): AgentDetailPage Vitest coverage.
|
|
//
|
|
// Pins the D-2 phantom-trim contract on the detail page:
|
|
// 1. Page fetches the agent via getAgent(id) when the URL :id param is set.
|
|
// 2. The Registered row reads agent.registered_at — pre-D-2 it read
|
|
// agent.created_at which was a TS phantom never emitted by the Go
|
|
// Agent struct.
|
|
// 3. The page does NOT render Capabilities / Tags sections — both were
|
|
// D-2-trimmed phantoms.
|
|
// -----------------------------------------------------------------------------
|
|
|
|
vi.mock('../api/client', () => ({
|
|
getAgent: vi.fn(),
|
|
getJobs: vi.fn(),
|
|
}));
|
|
|
|
import AgentDetailPage from './AgentDetailPage';
|
|
import * as client from '../api/client';
|
|
|
|
function renderAt(path: string, ui: ReactNode) {
|
|
const qc = new QueryClient({
|
|
defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } },
|
|
});
|
|
return render(
|
|
<QueryClientProvider client={qc}>
|
|
<MemoryRouter initialEntries={[path]}>
|
|
<Routes>
|
|
<Route path="/agents/:id" element={ui} />
|
|
</Routes>
|
|
</MemoryRouter>
|
|
</QueryClientProvider>,
|
|
);
|
|
}
|
|
|
|
describe('AgentDetailPage — T-1 page coverage', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
cleanup();
|
|
vi.mocked(client.getAgent).mockResolvedValue({
|
|
id: 'agent-iis01',
|
|
name: 'IIS-01',
|
|
hostname: 'iis01.prod.example.com',
|
|
ip_address: '10.0.0.5',
|
|
version: '0.5.4',
|
|
status: 'Online',
|
|
os: 'windows',
|
|
architecture: 'amd64',
|
|
last_heartbeat_at: new Date().toISOString(),
|
|
registered_at: '2026-04-01T00:00:00Z',
|
|
});
|
|
vi.mocked(client.getJobs).mockResolvedValue({
|
|
data: [],
|
|
total: 0,
|
|
page: 1,
|
|
per_page: 10,
|
|
});
|
|
});
|
|
|
|
it('fetches the agent by URL id param', async () => {
|
|
renderAt('/agents/agent-iis01', <AgentDetailPage />);
|
|
await waitFor(() => {
|
|
expect(client.getAgent).toHaveBeenCalledWith('agent-iis01');
|
|
});
|
|
});
|
|
|
|
it('renders the Registered row from registered_at (D-2 phantom-trim)', async () => {
|
|
renderAt('/agents/agent-iis01', <AgentDetailPage />);
|
|
await waitFor(() => {
|
|
expect(screen.getByText('Registered')).toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
it('does NOT render Capabilities / Tags sections (D-2 trimmed both phantoms)', async () => {
|
|
renderAt('/agents/agent-iis01', <AgentDetailPage />);
|
|
await waitFor(() => {
|
|
expect(screen.getByText('IIS-01')).toBeInTheDocument();
|
|
});
|
|
// These two labels existed pre-D-2 backed by phantom fields the Go
|
|
// Agent struct never emitted; both sections must be absent post-D-2.
|
|
expect(screen.queryByText('Capabilities')).not.toBeInTheDocument();
|
|
expect(screen.queryByText('Tags')).not.toBeInTheDocument();
|
|
});
|
|
});
|