mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 14:11:31 +00:00
shankar0123
1caedd5fd3
Bundle: ci-pipeline-cleanup, Phase 1. Pure relocation — no behavior change. Each guard's bash logic is byte-identical to the prior inline version; the only changes are: (a) the guard becomes a sibling script under scripts/ci-guards/<id>.sh, (b) ci.yml's per-guard step is replaced by a single loop step that iterates all scripts. 20 scripts extracted (alphabetized): B-1-orphan-crud.sh, D-1-D-2-statusbadge-phantom.sh, G-1-jwt-auth-literal.sh, G-2-api-key-hash-json.sh, G-3-env-docs-drift.sh, H-001-bare-from.sh, H-009-readme-jwt.sh, L-001-insecure-skip-verify.sh, L-1-bulk-action-loop.sh, M-012-no-root-user.sh, P-1-documented-orphan-fns.sh, S-1-hardcoded-source-counts.sh, S-2-strings-contains-err.sh, T-1-frontend-page-coverage.sh, U-2-plaintext-healthcheck.sh, U-3-migration-mount.sh, bundle-8-L-015-target-blank-rel-noopener.sh, bundle-8-L-019-dangerously-set-inner-html.sh, bundle-8-M-009-bare-usemutation.sh, test-naming-convention.sh Plus scripts/ci-guards/README.md documenting the contract: - Each script must exit 0 on clean repo, non-zero with ::error:: prefix on regression - Runnable from repo root via 'bash scripts/ci-guards/<id>.sh' - Adding a new guard: drop a new <id>.sh; CI auto-picks it up ci.yml dropped 1488 → 557 lines (-931, -63%). Single CI loop step now collects ALL guard failures before failing the build instead of fail-fast — UX win for regressions that hit two guards at once. Two guards (QA-doc Part-count + seed-count, ci.yml lines 868-917) deliberately NOT extracted — they move to 'make verify-docs' in Phase 11 because they protect docs-the-operator-reads, not the product itself. Verification (sandbox): - All 20 scripts pass against HEAD (chmod +x; for g in scripts/ci-guards/*.sh; do bash $g; done) - New ci.yml YAML-parses cleanly - Job boundaries preserved: go-build-and-test, frontend-build, helm-lint, deploy-vendor-e2e, deploy-vendor-e2e-windows - Loop step appears twice (once at end of go-build-and-test, once at end of frontend-build) so both jobs continue running their set of guards
39 lines
1.8 KiB
Bash
Executable File
39 lines
1.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# scripts/ci-guards/P-1-documented-orphan-fns.sh
|
|
#
|
|
# P-1 master closed diff-04x03-d24864996ad4 + cat-b-dc46aadab98e
|
|
# by documenting 17 detail-page-candidate orphan client.ts
|
|
# functions in a docblock at the top of web/src/api/client.ts.
|
|
# This script verifies the docblock list ↔ export list relationship:
|
|
# every name listed in the docblock must still be declared as
|
|
# an export below it (catches drift where someone deletes the
|
|
# export but forgets the docblock, or vice versa).
|
|
#
|
|
# CRL/OCSP-Responder Phase 5 closed the getOCSPStatus orphan: the
|
|
# CertificateDetailPage Revocation Endpoints panel now consumes it
|
|
# ("Check OCSP status" button). Removed from the list to keep the
|
|
# docblock + guardrail honest.
|
|
#
|
|
# See coverage-gap-audit-2026-04-24-v5/unified-audit.md
|
|
# diff-04x03-d24864996ad4 + cat-b-dc46aadab98e for closure rationale.
|
|
|
|
set -e
|
|
DOCUMENTED='getAgentGroup getAgentGroupMembers getAuditEvent getCertificateDeployments getDiscoveredCertificate getHealthCheck getHealthCheckHistory getNetworkScanTarget getNotification getOwner getPolicy getPolicyViolations getRenewalPolicy getTeam registerAgent updateHealthCheck'
|
|
MISSING=""
|
|
for fn in $DOCUMENTED; do
|
|
if ! grep -qE "^export const ${fn}\b" web/src/api/client.ts; then
|
|
MISSING="${MISSING}${fn} "
|
|
fi
|
|
done
|
|
if [ -n "$MISSING" ]; then
|
|
echo "::error::P-1 regression: documented orphan(s) missing from client.ts exports:"
|
|
echo " $MISSING"
|
|
echo ""
|
|
echo "Either restore the export, or delete the corresponding line"
|
|
echo "in the documented-orphans docblock at the top of client.ts."
|
|
echo "See coverage-gap-audit-2026-04-24-v5/unified-audit.md"
|
|
echo "diff-04x03-d24864996ad4 for closure rationale."
|
|
exit 1
|
|
fi
|
|
echo "P-1 documented-orphan-fns: clean ($(echo $DOCUMENTED | wc -w) fns verified)."
|