Files
certctl/web/src/pages/DigestPage.test.tsx
T
Shankar 668a7bad11 Bundle H follow-up #2: end-to-end fix for Pass 3 CI multi-match failures
Second CI run surfaced 8 real failures across 7 detail/list pages and 1

mock-shape error. Root causes:

  1. Multi-match disambiguation. screen.getByText(...) matched both the

     PageHeader <h2> AND duplicated text in InfoRow / detail-row spans

     within the same page (e.g., issuer name appears as page title AND

     in the Issuer Details panel; cert.common_name appears as page title

     AND in the Common Name InfoRow). The regex variants (getByText(/X/i))

     were even worse — matched any element containing the substring.

  2. NetworkScanPage mock-shape. xssScanTarget.ports was '443,8443'

     (string), but NetworkScanPage.tsx:180 calls t.ports?.join() which

     requires a number[] per src/api/types.ts:506. Page errored before

     rendering the DataTable, so the XSS test's body.textContent

     assertion saw an empty string.

Fixes:

  - Every page-title assertion in the 14 Pass 3 test files now uses

    screen.getByRole('heading', { level: 2, name: ... }), which matches

    ONLY the PageHeader <h2> (PageHeader.tsx:11 renders an actual <h2>).

    Detail-row spans / InfoRow text / column-header text in lower-level

    headings (h3) is excluded by the level filter.

  - NetworkScanPage xssScanTarget.ports changed from '443,8443' (string)

    to [443, 8443] (number[]) per the NetworkScanTarget TS type.

Pages with assertion fixes (8 tests across 7 files):

  - AgentFleetPage         /Agent/i        -> 'Agent Fleet Overview' (h2)

  - AuditPage              /Audit/         -> 'Audit Trail' (h2)

  - CertificateDetailPage  'plain.example.com' (text)  -> heading h2

  - HealthMonitorPage      /Health/i       -> 'Health Monitor' (h2)

  - IssuerDetailPage       'Plain Name' (text)         -> heading h2

  - JobDetailPage          /j-xss-001/ (text)          -> heading h2

  - JobsPage               /Jobs/i         -> 'Jobs' (h2)

  - ProfilesPage           /Profile/i      -> 'Certificate Profiles' (h2)

  - TargetDetailPage       'Plain Name' (text)         -> heading h2

Plus 4 already-correct pages updated for consistency:

  - DigestPage             text 'Certificate Digest'   -> heading h2

  - ObservabilityPage      text 'Observability'        -> heading h2

  - NetworkScanPage        /Network/i      -> 'Network Scanning' (h2)

  - ShortLivedPage         text 'Short-Lived...'       -> heading h2

Mock-shape fix:

  - NetworkScanPage.test.tsx  ports: '443,8443' -> [443, 8443]

End-to-end audit:

  Every Pass 3 test now anchors on the unambiguous PageHeader <h2>;

  no remaining getByText() with regex or substring that could spuriously

  multi-match. Mock data shapes verified against src/api/types.ts

  interfaces (NetworkScanTarget, MetricsResponse, ManagedCertificate).
2026-04-27 03:24:31 +00:00

89 lines
3.8 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest';
import { render, screen, waitFor, cleanup } from '@testing-library/react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { MemoryRouter } from 'react-router-dom';
import type { ReactNode } from 'react';
// -----------------------------------------------------------------------------
// M-029 Pass 3 (Audit M-026): DigestPage XSS-hardening + basic render coverage.
//
// DigestPage renders a server-rendered HTML preview from previewDigest(). The
// audit's M-026 closure guards against the day someone migrates the preview
// surface from controlled <iframe srcDoc> rendering to a less-safe
// dangerouslySetInnerHTML or similar pattern: an attacker-controlled cert
// subject DN that lands inside the digest HTML would then execute as a
// script payload.
//
// Pins:
// 1. Page renders when previewDigest resolves.
// 2. The HTML payload returned by previewDigest is NEVER injected into the
// DOM as a live <script> — `document.querySelector('script[data-xss])'`
// stays empty even when the response contains a literal <script> tag.
// 3. The literal preview text (or an iframe pointing at the preview) is
// surfaced to the operator, but the <script> attack vector cannot fire.
// -----------------------------------------------------------------------------
vi.mock('../api/client', () => ({
previewDigest: vi.fn(),
sendDigest: vi.fn(),
}));
import DigestPage from './DigestPage';
import * as client from '../api/client';
function renderWithQuery(ui: ReactNode) {
const qc = new QueryClient({
defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } },
});
return render(
<QueryClientProvider client={qc}>
<MemoryRouter>{ui}</MemoryRouter>
</QueryClientProvider>,
);
}
describe('DigestPage — render + XSS hardening (M-026 / M-029 Pass 3)', () => {
beforeEach(() => {
vi.clearAllMocks();
cleanup();
});
it('renders the page header when previewDigest resolves', async () => {
vi.mocked(client.previewDigest).mockResolvedValue('<p>Today 5 certs expire</p>' as never);
renderWithQuery(<DigestPage />);
await waitFor(() => {
expect(screen.getByRole('heading', { level: 2, name: 'Certificate Digest' })).toBeInTheDocument();
});
});
it('does NOT execute a <script> payload returned by previewDigest', async () => {
const xssPayload = '<script data-xss="digest-preview">window.__xss_pwned__=1;</script>';
vi.mocked(client.previewDigest).mockResolvedValue(xssPayload as never);
renderWithQuery(<DigestPage />);
await waitFor(() => {
// Wait for the preview surface to render (the page settles into
// either the preview pane or an error pane — either way the
// page-load cycle is done by the time the header text appears).
expect(screen.getByRole('heading', { level: 2, name: 'Certificate Digest' })).toBeInTheDocument();
});
// No live script with our marker may be attached to the DOM, AND no
// global side-effect from the script body may have run.
const liveScripts = document.querySelectorAll('script[data-xss="digest-preview"]');
expect(liveScripts.length, 'previewDigest payload must not inject a live <script>').toBe(0);
expect(
(window as unknown as { __xss_pwned__?: number }).__xss_pwned__,
'previewDigest <script> body must not have executed',
).toBeUndefined();
});
it('still renders when previewDigest fails (error path does not crash)', async () => {
vi.mocked(client.previewDigest).mockRejectedValue(new Error('preview failed') as never);
renderWithQuery(<DigestPage />);
await waitFor(() => {
expect(screen.getByRole('heading', { level: 2, name: 'Certificate Digest' })).toBeInTheDocument();
});
});
});