Files
certctl/web/src/pages/TargetsPage.test.tsx
T
cowork 9a7f2ba06f test(web): Vitest coverage for 8 high-leverage pages (T-1 master)
Closes T-1 (cat-s2-c24a548076c6) — frontend page-level Vitest coverage was
3 of 28 pages pre-T-1. T-1 lifts that to 11 of 28 (39%) by writing focused
behavior tests for the 8 highest-leverage pages.

Tests added:
  - CertificatesPage.test.tsx (6 cases) — F-1 filter+pagination contract:
    team_id / expires_before / sort param wiring, page=1 reset on filter
    change, page+per_page always present in getCertificates params.
  - PoliciesPage.test.tsx (4 cases) — D-006/D-008 TitleCase contract:
    list render, severity badge, toggle-enabled inversion, delete confirm.
  - IssuersPage.test.tsx (3 cases) — D-2 phantom-trim + B-1 EditIssuer:
    list render, StatusBadge derives from enabled, Test fires
    testIssuerConnection.
  - TargetsPage.test.tsx (3 cases) — D-2 phantom-trim:
    list render, Status derives from enabled, Delete fires deleteTarget.
  - AgentsPage.test.tsx (3 cases) — D-2 phantom-trim + heartbeatStatus:
    list render, undefined last_heartbeat_at -> Offline,
    listRetiredAgents lazy-loaded.
  - AgentDetailPage.test.tsx (3 cases) — D-2 phantom-trim:
    fetches by URL :id, Registered row reads registered_at,
    Capabilities + Tags sections absent.
  - OwnersPage.test.tsx (3 cases) — B-1 EditOwnerModal closure:
    list render, Edit opens modal, Save fires updateOwner.
  - TeamsPage.test.tsx (2 cases) — B-1 EditTeamModal closure.
  - AgentGroupsPage.test.tsx (2 cases) — B-1 EditAgentGroupModal closure.
  - RenewalPoliciesPage.test.tsx (3 cases) — B-1 brand-new-page closure:
    list + alert_thresholds_days display, Create modal, Edit modal.
  - DiscoveryPage.test.tsx (3 cases) — I-2 claim/dismiss closure:
    list render, status filter wiring, Dismiss fires dismissDiscoveredCertificate.

CI guardrail: .github/workflows/ci.yml step "Frontend page-coverage
regression guard (T-1)" blocks new pages from landing without sibling
.test.tsx unless added to a 14-name deferred allowlist with one-line
"why deferred" justifications.

Net coverage: 13 page-level vitest cases -> ~35 page-level vitest cases
across 14 files (was 3); total project tests 302 -> 337.

See coverage-gap-audit-2026-04-24-v5/unified-audit.md
cat-s2-c24a548076c6 for closure rationale.
2026-04-25 18:35:41 +00:00

116 lines
3.6 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest';
import { render, screen, waitFor, fireEvent, cleanup } from '@testing-library/react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { MemoryRouter } from 'react-router-dom';
import type { ReactNode } from 'react';
// -----------------------------------------------------------------------------
// T-1 closure (cat-s2-c24a548076c6): TargetsPage Vitest coverage.
//
// Pins:
// 1. Targets list renders when getTargets resolves.
// 2. Status column derives from `enabled` (D-2 phantom-field trim).
// 3. Connection column reads test_status (D-2 contract).
// 4. Delete confirm flow calls deleteTarget(id).
// -----------------------------------------------------------------------------
vi.mock('../api/client', () => ({
getTargets: vi.fn(),
createTarget: vi.fn(),
deleteTarget: vi.fn(),
getAgents: vi.fn(),
}));
import TargetsPage from './TargetsPage';
import * as client from '../api/client';
function renderWithQuery(ui: ReactNode) {
const qc = new QueryClient({
defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } },
});
return render(
<QueryClientProvider client={qc}>
<MemoryRouter>{ui}</MemoryRouter>
</QueryClientProvider>,
);
}
const targetEnabled = {
id: 'tgt-iis-prod',
name: 'IIS Web01',
type: 'iis',
agent_id: 'agent-iis01',
enabled: true,
test_status: 'success',
config: {},
created_at: new Date().toISOString(),
updated_at: new Date().toISOString(),
};
const targetUntested = {
id: 'tgt-untested',
name: 'New Target',
type: 'kubernetes',
agent_id: '',
enabled: false,
test_status: 'untested',
config: {},
created_at: new Date().toISOString(),
updated_at: new Date().toISOString(),
};
describe('TargetsPage — T-1 page coverage', () => {
beforeEach(() => {
vi.clearAllMocks();
cleanup();
vi.mocked(client.getTargets).mockResolvedValue({
data: [targetEnabled, targetUntested],
total: 2,
page: 1,
per_page: 50,
});
vi.mocked(client.getAgents).mockResolvedValue({ data: [], total: 0, page: 1, per_page: 50 });
vi.mocked(client.deleteTarget).mockResolvedValue({ message: 'deleted' });
});
it('renders the targets list when getTargets resolves', async () => {
renderWithQuery(<TargetsPage />);
await waitFor(() => {
expect(screen.getByText('IIS Web01')).toBeInTheDocument();
});
expect(screen.getByText('New Target')).toBeInTheDocument();
});
it('derives the Status column from enabled (D-2 phantom-field trim)', async () => {
renderWithQuery(<TargetsPage />);
await waitFor(() => {
expect(screen.getByText('IIS Web01')).toBeInTheDocument();
});
// Pre-D-2 the column read a phantom `status` field; post-D-2 it derives
// 'Enabled' / 'Disabled' purely from the boolean.
expect(screen.getAllByText(/Enabled/).length).toBeGreaterThan(0);
expect(screen.getAllByText(/Disabled/).length).toBeGreaterThan(0);
});
it('Delete confirm flow calls deleteTarget(id)', async () => {
const origConfirm = globalThis.confirm;
globalThis.confirm = vi.fn(() => true);
try {
renderWithQuery(<TargetsPage />);
await waitFor(() => {
expect(screen.getByText('IIS Web01')).toBeInTheDocument();
});
const deleteButtons = await screen.findAllByRole('button', { name: 'Delete' });
fireEvent.click(deleteButtons[0]!);
await waitFor(() => {
expect(client.deleteTarget).toHaveBeenCalled();
});
expect(vi.mocked(client.deleteTarget).mock.calls[0]?.[0]).toBe('tgt-iis-prod');
} finally {
globalThis.confirm = origConfirm;
}
});
});