mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 15:01:32 +00:00
shankar0123
1caedd5fd3
Bundle: ci-pipeline-cleanup, Phase 1. Pure relocation — no behavior change. Each guard's bash logic is byte-identical to the prior inline version; the only changes are: (a) the guard becomes a sibling script under scripts/ci-guards/<id>.sh, (b) ci.yml's per-guard step is replaced by a single loop step that iterates all scripts. 20 scripts extracted (alphabetized): B-1-orphan-crud.sh, D-1-D-2-statusbadge-phantom.sh, G-1-jwt-auth-literal.sh, G-2-api-key-hash-json.sh, G-3-env-docs-drift.sh, H-001-bare-from.sh, H-009-readme-jwt.sh, L-001-insecure-skip-verify.sh, L-1-bulk-action-loop.sh, M-012-no-root-user.sh, P-1-documented-orphan-fns.sh, S-1-hardcoded-source-counts.sh, S-2-strings-contains-err.sh, T-1-frontend-page-coverage.sh, U-2-plaintext-healthcheck.sh, U-3-migration-mount.sh, bundle-8-L-015-target-blank-rel-noopener.sh, bundle-8-L-019-dangerously-set-inner-html.sh, bundle-8-M-009-bare-usemutation.sh, test-naming-convention.sh Plus scripts/ci-guards/README.md documenting the contract: - Each script must exit 0 on clean repo, non-zero with ::error:: prefix on regression - Runnable from repo root via 'bash scripts/ci-guards/<id>.sh' - Adding a new guard: drop a new <id>.sh; CI auto-picks it up ci.yml dropped 1488 → 557 lines (-931, -63%). Single CI loop step now collects ALL guard failures before failing the build instead of fail-fast — UX win for regressions that hit two guards at once. Two guards (QA-doc Part-count + seed-count, ci.yml lines 868-917) deliberately NOT extracted — they move to 'make verify-docs' in Phase 11 because they protect docs-the-operator-reads, not the product itself. Verification (sandbox): - All 20 scripts pass against HEAD (chmod +x; for g in scripts/ci-guards/*.sh; do bash $g; done) - New ci.yml YAML-parses cleanly - Job boundaries preserved: go-build-and-test, frontend-build, helm-lint, deploy-vendor-e2e, deploy-vendor-e2e-windows - Loop step appears twice (once at end of go-build-and-test, once at end of frontend-build) so both jobs continue running their set of guards
31 lines
1.2 KiB
Bash
Executable File
31 lines
1.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# scripts/ci-guards/bundle-8-L-015-target-blank-rel-noopener.sh
|
|
#
|
|
# Audit L-015 / CWE-1022 (reverse-tabnabbing): every <a target="_blank">
|
|
# MUST carry rel="noopener noreferrer" so a malicious page at the
|
|
# target URL cannot navigate the opener window via window.opener.
|
|
# At Bundle-8 close all 3 sites in the codebase already comply —
|
|
# this guard prevents regression. The ExternalLink component
|
|
# (web/src/components/ExternalLink.tsx) is the recommended way to
|
|
# add new external links.
|
|
#
|
|
# Test files (web/src/**/*.test.{ts,tsx}) are excluded so test
|
|
# docstrings or fixture data describing the attack vector by
|
|
# name don't trip the guard — symmetric with the L-019 guard.
|
|
|
|
set -e
|
|
OFFENDERS=$(grep -rnE 'target=["'"'"']?_blank["'"'"']?' web/src/ 2>/dev/null \
|
|
| grep -v 'noopener noreferrer' \
|
|
| grep -v 'web/src/components/ExternalLink.tsx' \
|
|
| grep -vE '\.test\.(ts|tsx)(:[0-9]+)?:' \
|
|
|| true)
|
|
if [ -n "$OFFENDERS" ]; then
|
|
echo "::error::L-015 regression: target=\"_blank\" without rel=\"noopener noreferrer\":"
|
|
echo "$OFFENDERS"
|
|
echo ""
|
|
echo "Either add rel=\"noopener noreferrer\" inline,"
|
|
echo "or migrate to <ExternalLink> from web/src/components/ExternalLink.tsx."
|
|
exit 1
|
|
fi
|
|
echo "L-015 target-blank-rel-noopener: clean."
|