Files
certctl/web/src/pages/OwnersPage.test.tsx
T
cowork 9a7f2ba06f test(web): Vitest coverage for 8 high-leverage pages (T-1 master)
Closes T-1 (cat-s2-c24a548076c6) — frontend page-level Vitest coverage was
3 of 28 pages pre-T-1. T-1 lifts that to 11 of 28 (39%) by writing focused
behavior tests for the 8 highest-leverage pages.

Tests added:
  - CertificatesPage.test.tsx (6 cases) — F-1 filter+pagination contract:
    team_id / expires_before / sort param wiring, page=1 reset on filter
    change, page+per_page always present in getCertificates params.
  - PoliciesPage.test.tsx (4 cases) — D-006/D-008 TitleCase contract:
    list render, severity badge, toggle-enabled inversion, delete confirm.
  - IssuersPage.test.tsx (3 cases) — D-2 phantom-trim + B-1 EditIssuer:
    list render, StatusBadge derives from enabled, Test fires
    testIssuerConnection.
  - TargetsPage.test.tsx (3 cases) — D-2 phantom-trim:
    list render, Status derives from enabled, Delete fires deleteTarget.
  - AgentsPage.test.tsx (3 cases) — D-2 phantom-trim + heartbeatStatus:
    list render, undefined last_heartbeat_at -> Offline,
    listRetiredAgents lazy-loaded.
  - AgentDetailPage.test.tsx (3 cases) — D-2 phantom-trim:
    fetches by URL :id, Registered row reads registered_at,
    Capabilities + Tags sections absent.
  - OwnersPage.test.tsx (3 cases) — B-1 EditOwnerModal closure:
    list render, Edit opens modal, Save fires updateOwner.
  - TeamsPage.test.tsx (2 cases) — B-1 EditTeamModal closure.
  - AgentGroupsPage.test.tsx (2 cases) — B-1 EditAgentGroupModal closure.
  - RenewalPoliciesPage.test.tsx (3 cases) — B-1 brand-new-page closure:
    list + alert_thresholds_days display, Create modal, Edit modal.
  - DiscoveryPage.test.tsx (3 cases) — I-2 claim/dismiss closure:
    list render, status filter wiring, Dismiss fires dismissDiscoveredCertificate.

CI guardrail: .github/workflows/ci.yml step "Frontend page-coverage
regression guard (T-1)" blocks new pages from landing without sibling
.test.tsx unless added to a 14-name deferred allowlist with one-line
"why deferred" justifications.

Net coverage: 13 page-level vitest cases -> ~35 page-level vitest cases
across 14 files (was 3); total project tests 302 -> 337.

See coverage-gap-audit-2026-04-24-v5/unified-audit.md
cat-s2-c24a548076c6 for closure rationale.
2026-04-25 18:35:41 +00:00

102 lines
3.7 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest';
import { render, screen, waitFor, fireEvent, cleanup } from '@testing-library/react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { MemoryRouter } from 'react-router-dom';
import type { ReactNode } from 'react';
// -----------------------------------------------------------------------------
// T-1 closure (cat-s2-c24a548076c6): OwnersPage Vitest coverage.
//
// Pins the B-1 master closure: the Edit button opens an EditOwnerModal that
// calls updateOwner(id, payload) — pre-B-1 the only rename path was
// delete-and-recreate which destroyed audit history and broke every cert
// referencing the old owner_id.
//
// 1. Owner list renders when getOwners resolves.
// 2. Edit button opens the EditOwnerModal (B-1 closure).
// 3. Submitting the edit calls updateOwner with the right payload.
// -----------------------------------------------------------------------------
vi.mock('../api/client', () => ({
getOwners: vi.fn(),
getTeams: vi.fn(),
createOwner: vi.fn(),
updateOwner: vi.fn(),
deleteOwner: vi.fn(),
}));
import OwnersPage from './OwnersPage';
import * as client from '../api/client';
function renderWithQuery(ui: ReactNode) {
const qc = new QueryClient({
defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } },
});
return render(
<QueryClientProvider client={qc}>
<MemoryRouter>{ui}</MemoryRouter>
</QueryClientProvider>,
);
}
const owner = {
id: 'o-platform',
name: 'Platform Team Lead',
email: 'platform@example.com',
team_id: 't-platform',
created_at: new Date().toISOString(),
updated_at: new Date().toISOString(),
};
const team = { id: 't-platform', name: 'Platform', description: '' };
describe('OwnersPage — T-1 page coverage', () => {
beforeEach(() => {
vi.clearAllMocks();
cleanup();
vi.mocked(client.getOwners).mockResolvedValue({ data: [owner], total: 1, page: 1, per_page: 50 } as never);
vi.mocked(client.getTeams).mockResolvedValue({ data: [team], total: 1, page: 1, per_page: 50 } as never);
vi.mocked(client.updateOwner).mockResolvedValue(owner as never);
});
it('renders the owners list when getOwners resolves', async () => {
renderWithQuery(<OwnersPage />);
await waitFor(() => {
expect(screen.getByText('Platform Team Lead')).toBeInTheDocument();
});
expect(screen.getByText('platform@example.com')).toBeInTheDocument();
});
it('Edit button opens the EditOwnerModal (B-1 closure)', async () => {
renderWithQuery(<OwnersPage />);
await waitFor(() => {
expect(screen.getByText('Platform Team Lead')).toBeInTheDocument();
});
const editBtn = await screen.findByRole('button', { name: 'Edit' });
fireEvent.click(editBtn);
await waitFor(() => {
expect(screen.getByText('Edit Owner')).toBeInTheDocument();
});
});
it('submitting the edit form calls updateOwner with the new payload', async () => {
renderWithQuery(<OwnersPage />);
await waitFor(() => {
expect(screen.getByText('Platform Team Lead')).toBeInTheDocument();
});
fireEvent.click(await screen.findByRole('button', { name: 'Edit' }));
await waitFor(() => {
expect(screen.getByText('Edit Owner')).toBeInTheDocument();
});
const saveBtn = await screen.findByRole('button', { name: /Save Changes/ });
fireEvent.click(saveBtn);
await waitFor(() => {
expect(client.updateOwner).toHaveBeenCalled();
});
const [id, payload] = vi.mocked(client.updateOwner).mock.calls[0]!;
expect(id).toBe('o-platform');
expect(payload).toMatchObject({ name: 'Platform Team Lead', email: 'platform@example.com' });
});
});