mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-09 12:58:52 +00:00
shankar0123
8b75e0311b
Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol
sub-module's go.mod, every Go file's import path (361 files), and a rebuild of
the checked-in f5-mock-icontrol binary so its embedded build-info reflects the
new module path. No behavior change.
Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A
(keep module path declared as github.com/shankar0123/certctl regardless of
repo URL) shipped on the day of the org transfer (2026-05-03) since we had no
external Go consumers; this commit closes that deferral.
Backward-compat: GitHub HTTP redirects continue to forward
github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL
level, but Go's module proxy uses the path declared in go.mod as the
canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...`
hit a "module path mismatch" error because go.mod said
github.com/shankar0123/certctl and the URL they fetched it from said
certctl-io/certctl. Post-fix, the canonical name and the URL agree, so
go get / go install / external Go consumers / Go-tooling integrations
work cleanly via either the new path (preferred) or the old path (which
redirects and Go follows the redirect for source fetch).
Anyone still importing the old path inside their own code keeps working
provided they update their go.mod's `require` line to match — the module
path declared in their consumer's go.sum / go.mod is the authoritative
import name, so a mass sed across their import statements is the migration
on the consumer side. No external consumers exist today.
Diff shape:
361 *.go files — import path replacement only
2 go.mod — module declaration replacement only
1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt
so embedded build-info reflects the new path (8618965 vs
8618933 bytes; 32-byte diff is the build-info change)
Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure
mechanical substitution.
Verification:
gofmt: 17 files needed re-alignment after sed (the new path is one char
shorter than the old, so column-aligned import groups drifted). Applied
`gofmt -w` to fix.
go mod tidy: clean exit on both modules.
go vet ./...: clean exit.
go build ./...: clean exit.
go test -short -count=1 on representative packages: all green
(internal/domain, internal/validation, internal/crypto, internal/crypto/signer,
cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...`
confirming the module path resolves correctly.
binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns
nothing; `strings | grep certctl-io/certctl` shows the new module path
embedded in build-info.
Files intentionally NOT touched in this commit:
README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io
URLs in commit 0729ee4 (the post-transfer URL refresh). This commit is
purely the Go-tooling layer.
Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account
namespace, not a Go import or GitHub repo URL. Stays.
This is a non-blocking, non-customer-impacting change. Operators pulling
container images, running `make verify`, hitting the API, or installing the
agent see no functional difference. Only Go-tooling consumers (none today)
are affected, and they're enabled — not broken — by this commit.
41 lines
1.6 KiB
Go
41 lines
1.6 KiB
Go
package f5
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/certctl-io/certctl/internal/connector/target"
|
|
)
|
|
|
|
// ValidateOnly — Phase 8 of the deploy-hardening I master bundle.
|
|
// F5 already has full transactional rollback semantics in
|
|
// DeployCertificate (the iControl REST API is transactional —
|
|
// `mgmt/tm/transaction` wraps the install + bind together; on
|
|
// failure the whole transaction aborts atomically with no live
|
|
// VS impact). Phase 8 makes the dry-run explicit by probing the
|
|
// BIG-IP control plane health: if the API is reachable and
|
|
// authenticated, ValidateOnly returns nil; otherwise it returns
|
|
// the wrapped client error so operators can preview a deploy
|
|
// without touching the live SSL profile.
|
|
//
|
|
// Note: a full dry-run that simulates the cert install + bind
|
|
// without commit would require F5 to expose a no-commit transaction
|
|
// mode (it does not in v15.x; it does in v17.5+ — V3-Pro will add
|
|
// per-version dispatch). For V2 the reachability probe is the
|
|
// load-bearing safety check.
|
|
func (c *Connector) ValidateOnly(ctx context.Context, request target.DeploymentRequest) error {
|
|
if c.client == nil {
|
|
return target.ErrValidateOnlyNotSupported
|
|
}
|
|
// Probe by attempting authentication. The F5 client caches
|
|
// the token after first success, so subsequent ValidateOnly
|
|
// calls are cheap. Failure here means the BIG-IP is
|
|
// unreachable, the operator credentials are wrong, or the
|
|
// auth provider (TACACS+, RADIUS) is down — all reasons to
|
|
// abort a deploy preview.
|
|
if err := c.client.Authenticate(ctx); err != nil {
|
|
return fmt.Errorf("F5 ValidateOnly: BIG-IP control plane probe failed: %w", err)
|
|
}
|
|
return nil
|
|
}
|