mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 17:31:30 +00:00
5a682db8e2
+ Cisco IOS quirk fixtures + ManagedCertificate.Source provenance + EST bulk-revoke endpoint + 13 typed audit action codes. Phase 10.1 — libest reference-client sidecar: - deploy/test/libest/Dockerfile: multi-stage Debian-bookworm-slim build of Cisco's libest v3.2.0-2 from source (autoconf/automake/ libtool + libcurl4-openssl-dev + libssl-dev). Runtime stage carries only estclient + bash + openssl + ca-certificates so the exec surface stays small + predictable. - docker-compose.test.yml libest-client entry (profiles: [est-e2e]) with bind mounts for /config/est (test workspace) + /config/certs (certctl CA bundle for TLS pinning); IP 10.30.50.9 (10.30.50.8 was already taken by certctl-agent). - deploy/test/est/.gitkeep keeps the bind-mount target tracked. Phase 10.2 — 5 integration tests (//go:build integration) in deploy/test/est_e2e_test.go: - TestEST_LibESTClient_Enrollment_Integration (cacerts → simpleenroll → cert-shape assertion) - TestEST_LibESTClient_MTLSEnrollment_Integration (mTLS sibling-route cert auth; skip when bootstrap cert absent) - TestEST_LibESTClient_ServerKeygen_Integration (RFC 7030 §4.4 multipart; skip when profile gate disabled) - TestEST_LibESTClient_RateLimited_Integration (4th enroll trips per-principal cap, asserts 429-shaped error) - TestEST_LibESTClient_ChannelBinding_Integration (libest --tls-exporter; skip when libest build lacks the flag). - requireESTSidecar guard skips the suite when the operator forgot --profile est-e2e; helpful error message includes the exact command to bring the sidecar up. Phase 10.3 — Cisco IOS quirk fixtures + 3 unit tests in internal/api/handler/cisco_ios_quirks_test.go: - testdata/cisco_ios_15x_pem_csr.txt: PEM body sent with Content-Type application/x-pem-file. Handler dispatches on body-prefix not Content-Type — accepts cleanly. - testdata/cisco_ios_16x_trailing_newline_csr.txt: extra trailing newlines after base64 body. strings.TrimSpace tolerates. - testdata/cisco_ios_crlf_b64_csr.txt: CRLF-wrapped base64. base64.StdEncoding handles CRLF + LF identically. Phase 11.1 — ManagedCertificate.Source provenance: - New domain.CertificateSource enum (Unspecified/EST/SCEP/API/Agent). - Migration 000023_managed_certificates_source.up.sql adds source TEXT NOT NULL DEFAULT '' so existing rows scan as CertificateSourceUnspecified — back-compat: bulk-revoke filter treats empty as "any source". - Postgres repo Insert/Update/scan paths all wire the new column. Phase 11.2 — EST bulk-revoke endpoint: - BulkRevocationCriteria.Source field (Source-only requests rejected as too broad — must accompany at least one narrower criterion). - service.bulk_revocation.resolveCertificates post-filter by Source (empty=any, no SQL change so existing CertificateFilter callers unaffected). - New BulkRevocationHandler.BulkRevokeEST method pins Source=EST + dispatches; new route POST /api/v1/est/certificates/bulk-revoke (M-008 admin-gated). openapi.yaml documented + parity-guard green. Phase 11.3 — 13 typed audit action codes in internal/service/est_audit_actions.go: - est_simple_enroll_success / _failed - est_simple_reenroll_success / _failed - est_server_keygen_success / _failed - est_auth_failed_basic / _mtls / _channel_binding - est_rate_limited - est_csr_policy_violation - est_bulk_revoke - est_trust_anchor_reloaded - ESTService.processEnrollment + SimpleServerKeygen + ReloadTrust split-emit BOTH the legacy bare action codes (back-compat for the GUI activity-tab chip filters that match by exact string + existing audit-log analysers) AND the new typed _success / _failed variants (operator grep target + per-failure-mode counter). Tests: - internal/api/handler/bulk_revocation_est_test.go — 5 cases (admin-true happy path pins Source=EST + non-admin 403 + empty-criteria 400 + invalid-reason 400 + method-not-allowed). - internal/service/est_audit_actions_test.go — 5 cases (SimpleEnroll legacy+typed emission / SimpleReEnroll typed / IssuerError typed-failed / PolicyViolation triple-emit / unique-string invariant). Pre-commit verification (sandbox): gofmt clean, go vet clean (excluding repository/postgres testcontainers limit), staticcheck clean across api/handler/api/router/domain/service/deploy/test, go test -short -count=1 green for every non-postgres Go package + integration build (`go build -tags integration ./deploy/test/...`) clean. G-3 docs-drift guard reproduced locally clean (Phases 10-11 added zero new env vars). Spec preserved at cowork/est-rfc7030-hardening-prompt.md. Phases 12-13 (docs/est.md + WiFi/802.1X / IoT bootstrap / FreeRADIUS recipes; release prep + tag) remain — post-2.1.0 work.
102 lines
4.3 KiB
Go
102 lines
4.3 KiB
Go
package domain
|
|
|
|
import "time"
|
|
|
|
// RevocationReason represents the reason for revoking a certificate.
|
|
// Values align with RFC 5280 Section 5.3.1 CRL reason codes.
|
|
type RevocationReason string
|
|
|
|
const (
|
|
RevocationReasonUnspecified RevocationReason = "unspecified"
|
|
RevocationReasonKeyCompromise RevocationReason = "keyCompromise"
|
|
RevocationReasonCACompromise RevocationReason = "caCompromise"
|
|
RevocationReasonAffiliationChanged RevocationReason = "affiliationChanged"
|
|
RevocationReasonSuperseded RevocationReason = "superseded"
|
|
RevocationReasonCessationOfOperation RevocationReason = "cessationOfOperation"
|
|
RevocationReasonCertificateHold RevocationReason = "certificateHold"
|
|
RevocationReasonPrivilegeWithdrawn RevocationReason = "privilegeWithdrawn"
|
|
)
|
|
|
|
// ValidRevocationReasons contains all valid revocation reason strings.
|
|
var ValidRevocationReasons = map[RevocationReason]int{
|
|
RevocationReasonUnspecified: 0,
|
|
RevocationReasonKeyCompromise: 1,
|
|
RevocationReasonCACompromise: 2,
|
|
RevocationReasonAffiliationChanged: 3,
|
|
RevocationReasonSuperseded: 4,
|
|
RevocationReasonCessationOfOperation: 5,
|
|
RevocationReasonCertificateHold: 6,
|
|
RevocationReasonPrivilegeWithdrawn: 9,
|
|
}
|
|
|
|
// IsValidRevocationReason checks whether a reason string is a valid RFC 5280 reason code.
|
|
func IsValidRevocationReason(reason string) bool {
|
|
_, ok := ValidRevocationReasons[RevocationReason(reason)]
|
|
return ok
|
|
}
|
|
|
|
// CRLReasonCode returns the RFC 5280 integer reason code for a revocation reason.
|
|
func CRLReasonCode(reason RevocationReason) int {
|
|
if code, ok := ValidRevocationReasons[reason]; ok {
|
|
return code
|
|
}
|
|
return 0 // unspecified
|
|
}
|
|
|
|
// BulkRevocationCriteria defines the filter criteria for bulk certificate revocation.
|
|
// At least one field must be set — empty criteria is rejected as a safety guard.
|
|
type BulkRevocationCriteria struct {
|
|
ProfileID string `json:"profile_id,omitempty"`
|
|
OwnerID string `json:"owner_id,omitempty"`
|
|
AgentID string `json:"agent_id,omitempty"`
|
|
IssuerID string `json:"issuer_id,omitempty"`
|
|
TeamID string `json:"team_id,omitempty"`
|
|
CertificateIDs []string `json:"certificate_ids,omitempty"`
|
|
// Source filters by ManagedCertificate.Source provenance value.
|
|
// Empty matches any source (back-compat with v2.X.0 callers); the
|
|
// EST bulk-revoke endpoint pins this to CertificateSourceEST so an
|
|
// operator hitting POST /api/v1/est/certificates/bulk-revoke only
|
|
// affects EST-issued certs, never SCEP/API/Agent-provisioned ones.
|
|
//
|
|
// EST RFC 7030 hardening master bundle Phase 11.2.
|
|
Source CertificateSource `json:"source,omitempty"`
|
|
}
|
|
|
|
// IsEmpty returns true if no filter criteria are set. Source alone does
|
|
// NOT count as a criterion — a Source=EST request without any narrower
|
|
// criterion (profile_id, owner_id, etc.) is rejected as too broad,
|
|
// because it would revoke EVERY EST-issued cert in the deployment.
|
|
func (c BulkRevocationCriteria) IsEmpty() bool {
|
|
return c.ProfileID == "" && c.OwnerID == "" && c.AgentID == "" &&
|
|
c.IssuerID == "" && c.TeamID == "" && len(c.CertificateIDs) == 0
|
|
}
|
|
|
|
// BulkRevocationResult contains the outcome of a bulk revocation operation.
|
|
type BulkRevocationResult struct {
|
|
TotalMatched int `json:"total_matched"`
|
|
TotalRevoked int `json:"total_revoked"`
|
|
TotalSkipped int `json:"total_skipped"`
|
|
TotalFailed int `json:"total_failed"`
|
|
Errors []BulkRevocationError `json:"errors,omitempty"`
|
|
}
|
|
|
|
// BulkRevocationError records a per-certificate revocation failure.
|
|
type BulkRevocationError struct {
|
|
CertificateID string `json:"certificate_id"`
|
|
Error string `json:"error"`
|
|
}
|
|
|
|
// CertificateRevocation records the revocation of a specific certificate version.
|
|
// Used as the authoritative source for CRL generation.
|
|
type CertificateRevocation struct {
|
|
ID string `json:"id"`
|
|
CertificateID string `json:"certificate_id"`
|
|
SerialNumber string `json:"serial_number"`
|
|
Reason string `json:"reason"`
|
|
RevokedBy string `json:"revoked_by"`
|
|
RevokedAt time.Time `json:"revoked_at"`
|
|
IssuerID string `json:"issuer_id"`
|
|
IssuerNotified bool `json:"issuer_notified"`
|
|
CreatedAt time.Time `json:"created_at"`
|
|
}
|