Files
certctl/internal/service/owner.go
T
shankar0123 2497be496d M-2 PR-C: Collapse Policy/Profile/Owner/Team services to ctx-first signatures
- Add ctx first param to 21 service-layer handler-interface methods
  across policy.go (6), profile.go (5), owner.go (5), team.go (5)
- Replace 24 context.Background() call sites with received ctx; use
  context.WithoutCancel(ctx) for subsidiary audit-recording ops to
  preserve fire-and-forget audit semantics without inheriting caller
  cancellation
- Add ctx first param to 21 handler-interface method signatures across
  policies.go (6), profiles.go (5), owners.go (5), teams.go (5)
- Thread r.Context() through 21 HTTP handler sites (ListPolicies,
  GetPolicy, CreatePolicy, UpdatePolicy, DeletePolicy, ListViolations,
  ListProfiles, GetProfile, CreateProfile, UpdateProfile, DeleteProfile,
  ListOwners, GetOwner, CreateOwner, UpdateOwner, DeleteOwner,
  ListTeams, GetTeam, CreateTeam, UpdateTeam, DeleteTeam)
- Update MockPolicyService/MockProfileService/MockOwnerService/
  MockTeamService mock method impls with _ context.Context first param
  (Fn fields unchanged — closures do not need ctx); update mock impls
  in integration/lifecycle_test.go for all four services
- Update 12 service-layer test callsites (policy_test.go ×2,
  owner_test.go ×5, team_test.go ×5, profile_test.go ×13) to pass
  context.Background() at the call site

Audit complete. Commit: 1f6cf0eafa. Sections: 12. Findings: 2/7/10/4/6.
2026-04-18 01:10:06 +00:00

189 lines
4.9 KiB
Go

package service
import (
"context"
"fmt"
"log/slog"
"time"
"github.com/shankar0123/certctl/internal/domain"
"github.com/shankar0123/certctl/internal/repository"
)
// OwnerService provides business logic for certificate owner management.
type OwnerService struct {
ownerRepo repository.OwnerRepository
auditService *AuditService
}
// NewOwnerService creates a new owner service.
func NewOwnerService(
ownerRepo repository.OwnerRepository,
auditService *AuditService,
) *OwnerService {
return &OwnerService{
ownerRepo: ownerRepo,
auditService: auditService,
}
}
// List returns a paginated list of owners.
func (s *OwnerService) List(ctx context.Context, page, perPage int) ([]*domain.Owner, int64, error) {
if page < 1 {
page = 1
}
if perPage < 1 {
perPage = 50
}
owners, err := s.ownerRepo.List(ctx)
if err != nil {
return nil, 0, fmt.Errorf("failed to list owners: %w", err)
}
total := int64(len(owners))
start := (page - 1) * perPage
if start >= int(total) {
return nil, total, nil
}
end := start + perPage
if end > int(total) {
end = int(total)
}
return owners[start:end], total, nil
}
// Get retrieves an owner by ID.
func (s *OwnerService) Get(ctx context.Context, id string) (*domain.Owner, error) {
owner, err := s.ownerRepo.Get(ctx, id)
if err != nil {
return nil, fmt.Errorf("failed to get owner %s: %w", id, err)
}
return owner, nil
}
// Create validates and stores a new owner.
func (s *OwnerService) Create(ctx context.Context, owner *domain.Owner, actor string) error {
if owner.Name == "" {
return fmt.Errorf("owner name is required")
}
if owner.ID == "" {
owner.ID = generateID("owner")
}
now := time.Now()
if owner.CreatedAt.IsZero() {
owner.CreatedAt = now
}
if owner.UpdatedAt.IsZero() {
owner.UpdatedAt = now
}
if err := s.ownerRepo.Create(ctx, owner); err != nil {
return fmt.Errorf("failed to create owner: %w", err)
}
if s.auditService != nil {
if auditErr := s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "create_owner", "owner", owner.ID, nil); auditErr != nil {
slog.Error("failed to record audit event", "error", auditErr)
}
}
return nil
}
// Update modifies an existing owner.
func (s *OwnerService) Update(ctx context.Context, id string, owner *domain.Owner, actor string) error {
if owner.Name == "" {
return fmt.Errorf("owner name is required")
}
owner.ID = id
if err := s.ownerRepo.Update(ctx, owner); err != nil {
return fmt.Errorf("failed to update owner %s: %w", id, err)
}
if s.auditService != nil {
if auditErr := s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "update_owner", "owner", id, nil); auditErr != nil {
slog.Error("failed to record audit event", "error", auditErr)
}
}
return nil
}
// Delete removes an owner.
func (s *OwnerService) Delete(ctx context.Context, id string, actor string) error {
if err := s.ownerRepo.Delete(ctx, id); err != nil {
return fmt.Errorf("failed to delete owner %s: %w", id, err)
}
if s.auditService != nil {
if auditErr := s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "delete_owner", "owner", id, nil); auditErr != nil {
slog.Error("failed to record audit event", "error", auditErr)
}
}
return nil
}
// ListOwners returns paginated owners (handler interface method).
func (s *OwnerService) ListOwners(ctx context.Context, page, perPage int) ([]domain.Owner, int64, error) {
if page < 1 {
page = 1
}
if perPage < 1 {
perPage = 50
}
owners, err := s.ownerRepo.List(ctx)
if err != nil {
return nil, 0, fmt.Errorf("failed to list owners: %w", err)
}
total := int64(len(owners))
var result []domain.Owner
for _, o := range owners {
if o != nil {
result = append(result, *o)
}
}
return result, total, nil
}
// GetOwner returns a single owner (handler interface method).
func (s *OwnerService) GetOwner(ctx context.Context, id string) (*domain.Owner, error) {
return s.ownerRepo.Get(ctx, id)
}
// CreateOwner creates a new owner (handler interface method).
func (s *OwnerService) CreateOwner(ctx context.Context, owner domain.Owner) (*domain.Owner, error) {
if owner.ID == "" {
owner.ID = generateID("owner")
}
now := time.Now()
if owner.CreatedAt.IsZero() {
owner.CreatedAt = now
}
if owner.UpdatedAt.IsZero() {
owner.UpdatedAt = now
}
if err := s.ownerRepo.Create(ctx, &owner); err != nil {
return nil, fmt.Errorf("failed to create owner: %w", err)
}
return &owner, nil
}
// UpdateOwner modifies an owner (handler interface method).
func (s *OwnerService) UpdateOwner(ctx context.Context, id string, owner domain.Owner) (*domain.Owner, error) {
owner.ID = id
if err := s.ownerRepo.Update(ctx, &owner); err != nil {
return nil, fmt.Errorf("failed to update owner: %w", err)
}
return &owner, nil
}
// DeleteOwner removes an owner (handler interface method).
func (s *OwnerService) DeleteOwner(ctx context.Context, id string) error {
return s.ownerRepo.Delete(ctx, id)
}