Files
certctl/internal/repository/postgres/owner.go
T
shankar0123 0e29c416b1 refactor(handler,repo): replace strings.Contains error dispatch with typed sentinels (S-2)
Closes one 2026-04-24 audit finding (P2):

  - cat-s6-efc7f6f6bd50: 30 strings.Contains(err.Error(), ...) sites
    in internal/api/handler/ — brittle to repository-layer message
    changes, untyped against the actual failure mode.

Approach (Option B from prompt design notes):
  - New typed sentinels in internal/repository/errors.go:
      ErrNotFound, ErrForeignKeyConstraint
      IsForeignKeyError(err) helper (the only place substring
      matching at the lib/pq boundary is allowed; isolates the
      DB-driver string knowledge to one function).
  - New typed sentinel in internal/domain/errors.go:
      ErrValidation (reserved for future per-entity validation
      wrappers; not yet used by all handlers).
  - 49 sites in internal/repository/postgres/*.go updated to wrap
    sql.ErrNoRows-derived errors via fmt.Errorf("...: %w",
    repository.ErrNotFound).
  - 18 not-found handler sites + 2 FK-constraint handler sites
    refactored to errors.Is(err, repository.ErrNotFound) /
    repository.IsForeignKeyError(err).
  - 23 inline `fmt.Errorf("X not found")` test fixtures across
    handler tests rewrapped to wrap repository.ErrNotFound.
  - test_utils.go::ErrMockNotFound rewrapped to wrap
    repository.ErrNotFound; renewal_policy.go closure docblock
    updated to reflect the new convention.
  - integration test mockJobRepository.Get wraps repository.ErrNotFound.

CI regression guardrail:
- .github/workflows/ci.yml::"Forbidden strings.Contains(err.Error())
  regression guard (S-2)" greps for the three patterns ("not found",
  "violates foreign key", "RESTRICT") under internal/api/handler/
  and fails the build on regression.

Verification:
- go build ./... — clean
- go vet ./... — clean
- go test ./... -short -count=1 — all packages pass (handler +
  repository + service + integration)
- golangci-lint v2.11.4 run ./... — 0 issues
- S-2 guardrail dry-run on post-fix tree → empty (good)
- All sibling guardrails (S-1, G-3, D-1+D-2, B-1, L-1, H-1, C-1, F-1, P-1) pass

Audit findings closed:
- cat-s6-efc7f6f6bd50 (P2)

Deferred follow-ups:
- 6 domain-specific substring patterns still inline in handlers
  ("cannot approve", "cannot reject", "cannot be parsed",
  "no certificates found", "challenge password", "invalid"/
  "required" validation chains in profiles + agent_groups). Each
  needs its own typed sentinel, scoped per service. Documented
  by the S-2 CI guardrail's allowlist for closure-comments only.
- Per-entity not-found sentinels (Option A — ErrCertificateNotFound,
  ErrAgentNotFound, etc.) deferred. Generic ErrNotFound covers the
  current dispatch needs; per-entity precision would let handlers
  return entity-aware error bodies without a domain.Type field,
  but not blocking.
2026-04-25 17:54:14 +00:00

139 lines
3.3 KiB
Go

package postgres
import (
"github.com/shankar0123/certctl/internal/repository"
"context"
"database/sql"
"fmt"
"github.com/google/uuid"
"github.com/shankar0123/certctl/internal/domain"
)
// OwnerRepository implements repository.OwnerRepository
type OwnerRepository struct {
db *sql.DB
}
// NewOwnerRepository creates a new OwnerRepository
func NewOwnerRepository(db *sql.DB) *OwnerRepository {
return &OwnerRepository{db: db}
}
// List returns all owners
func (r *OwnerRepository) List(ctx context.Context) ([]*domain.Owner, error) {
rows, err := r.db.QueryContext(ctx, `
SELECT id, name, email, team_id, created_at, updated_at
FROM owners
ORDER BY created_at DESC
`)
if err != nil {
return nil, fmt.Errorf("failed to query owners: %w", err)
}
defer rows.Close()
var owners []*domain.Owner
for rows.Next() {
var owner domain.Owner
if err := rows.Scan(&owner.ID, &owner.Name, &owner.Email, &owner.TeamID,
&owner.CreatedAt, &owner.UpdatedAt); err != nil {
return nil, fmt.Errorf("failed to scan owner: %w", err)
}
owners = append(owners, &owner)
}
if err := rows.Err(); err != nil {
return nil, fmt.Errorf("error iterating owner rows: %w", err)
}
return owners, nil
}
// Get retrieves an owner by ID
func (r *OwnerRepository) Get(ctx context.Context, id string) (*domain.Owner, error) {
var owner domain.Owner
err := r.db.QueryRowContext(ctx, `
SELECT id, name, email, team_id, created_at, updated_at
FROM owners
WHERE id = $1
`, id).Scan(&owner.ID, &owner.Name, &owner.Email, &owner.TeamID,
&owner.CreatedAt, &owner.UpdatedAt)
if err != nil {
if err == sql.ErrNoRows {
return nil, fmt.Errorf("owner not found: %w", repository.ErrNotFound)
}
return nil, fmt.Errorf("failed to query owner: %w", err)
}
return &owner, nil
}
// Create stores a new owner
func (r *OwnerRepository) Create(ctx context.Context, owner *domain.Owner) error {
if owner.ID == "" {
owner.ID = uuid.New().String()
}
err := r.db.QueryRowContext(ctx, `
INSERT INTO owners (id, name, email, team_id, created_at, updated_at)
VALUES ($1, $2, $3, $4, $5, $6)
RETURNING id
`, owner.ID, owner.Name, owner.Email, owner.TeamID,
owner.CreatedAt, owner.UpdatedAt).Scan(&owner.ID)
if err != nil {
return fmt.Errorf("failed to create owner: %w", err)
}
return nil
}
// Update modifies an existing owner
func (r *OwnerRepository) Update(ctx context.Context, owner *domain.Owner) error {
result, err := r.db.ExecContext(ctx, `
UPDATE owners SET
name = $1,
email = $2,
team_id = $3,
updated_at = $4
WHERE id = $5
`, owner.Name, owner.Email, owner.TeamID, owner.UpdatedAt, owner.ID)
if err != nil {
return fmt.Errorf("failed to update owner: %w", err)
}
rows, err := result.RowsAffected()
if err != nil {
return fmt.Errorf("failed to get rows affected: %w", err)
}
if rows == 0 {
return fmt.Errorf("owner not found: %w", repository.ErrNotFound)
}
return nil
}
// Delete removes an owner
func (r *OwnerRepository) Delete(ctx context.Context, id string) error {
result, err := r.db.ExecContext(ctx, "DELETE FROM owners WHERE id = $1", id)
if err != nil {
return fmt.Errorf("failed to delete owner: %w", err)
}
rows, err := result.RowsAffected()
if err != nil {
return fmt.Errorf("failed to get rows affected: %w", err)
}
if rows == 0 {
return fmt.Errorf("owner not found: %w", repository.ErrNotFound)
}
return nil
}