mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-10 21:38:56 +00:00
shankar0123
8b75e0311b
Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol
sub-module's go.mod, every Go file's import path (361 files), and a rebuild of
the checked-in f5-mock-icontrol binary so its embedded build-info reflects the
new module path. No behavior change.
Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A
(keep module path declared as github.com/shankar0123/certctl regardless of
repo URL) shipped on the day of the org transfer (2026-05-03) since we had no
external Go consumers; this commit closes that deferral.
Backward-compat: GitHub HTTP redirects continue to forward
github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL
level, but Go's module proxy uses the path declared in go.mod as the
canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...`
hit a "module path mismatch" error because go.mod said
github.com/shankar0123/certctl and the URL they fetched it from said
certctl-io/certctl. Post-fix, the canonical name and the URL agree, so
go get / go install / external Go consumers / Go-tooling integrations
work cleanly via either the new path (preferred) or the old path (which
redirects and Go follows the redirect for source fetch).
Anyone still importing the old path inside their own code keeps working
provided they update their go.mod's `require` line to match — the module
path declared in their consumer's go.sum / go.mod is the authoritative
import name, so a mass sed across their import statements is the migration
on the consumer side. No external consumers exist today.
Diff shape:
361 *.go files — import path replacement only
2 go.mod — module declaration replacement only
1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt
so embedded build-info reflects the new path (8618965 vs
8618933 bytes; 32-byte diff is the build-info change)
Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure
mechanical substitution.
Verification:
gofmt: 17 files needed re-alignment after sed (the new path is one char
shorter than the old, so column-aligned import groups drifted). Applied
`gofmt -w` to fix.
go mod tidy: clean exit on both modules.
go vet ./...: clean exit.
go build ./...: clean exit.
go test -short -count=1 on representative packages: all green
(internal/domain, internal/validation, internal/crypto, internal/crypto/signer,
cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...`
confirming the module path resolves correctly.
binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns
nothing; `strings | grep certctl-io/certctl` shows the new module path
embedded in build-info.
Files intentionally NOT touched in this commit:
README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io
URLs in commit 0729ee4 (the post-transfer URL refresh). This commit is
purely the Go-tooling layer.
Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account
namespace, not a Go import or GitHub repo URL. Stays.
This is a non-blocking, non-customer-impacting change. Operators pulling
container images, running `make verify`, hitting the API, or installing the
agent see no functional difference. Only Go-tooling consumers (none today)
are affected, and they're enabled — not broken — by this commit.
46 lines
2.1 KiB
Go
46 lines
2.1 KiB
Go
package intune
|
|
|
|
// SCEP RFC 8894 + Intune master bundle Phase 7.2 (originally) +
|
|
// EST RFC 7030 hardening master bundle Phase 2.1 (extraction).
|
|
//
|
|
// LoadTrustAnchor + parseTrustAnchorPEM were extracted to
|
|
// internal/trustanchor.LoadBundle + parseBundlePEM so the EST mTLS
|
|
// sibling route (Phase 2 of the EST hardening bundle), the Intune
|
|
// dispatcher, and any future per-profile-trust-bundle caller can share
|
|
// the same PEM-bundle loader + SIGHUP-reload semantics. The shim below
|
|
// preserves the original public surface so existing intune callers
|
|
// (cmd/server/main.go, scep_intune_e2e_test.go, scep_profile_counter_
|
|
// isolation_test.go, scep_intune.go service) compile unchanged.
|
|
//
|
|
// New callers SHOULD import internal/trustanchor directly — the
|
|
// trustanchor.Holder + trustanchor.LoadBundle are the modern API.
|
|
//
|
|
// Note: the legacy intune error messages ("intune: trust anchor cert
|
|
// in %q expired ...") are NOT preserved verbatim across the extraction;
|
|
// the shared trustanchor package emits "trustanchor: ..." messages
|
|
// instead. The operator-facing log line at cmd/server/main.go's
|
|
// preflightSCEPIntuneTrustAnchor wraps the error in its own outer
|
|
// ("SCEP profile (PathID=...) INTUNE trust anchor load failed: ...")
|
|
// so the prefix change is invisible to log-grep runbooks that filter
|
|
// on the outer message.
|
|
|
|
import (
|
|
"crypto/x509"
|
|
|
|
"github.com/certctl-io/certctl/internal/trustanchor"
|
|
)
|
|
|
|
// LoadTrustAnchor reads a PEM bundle of one or more Intune Connector
|
|
// signing certificates from the configured path. Delegates to the
|
|
// shared trustanchor.LoadBundle (extracted in EST RFC 7030 hardening
|
|
// Phase 2.1) so the EST mTLS sibling route + the Intune dispatcher
|
|
// + any future per-profile trust-bundle caller share the same
|
|
// loader semantics (path-empty refusal, expired-cert refusal,
|
|
// non-CERTIFICATE-block tolerance).
|
|
//
|
|
// Preserved here as a wrapper so existing intune callers compile
|
|
// unchanged. New callers SHOULD use trustanchor.LoadBundle directly.
|
|
func LoadTrustAnchor(path string) ([]*x509.Certificate, error) {
|
|
return trustanchor.LoadBundle(path)
|
|
}
|