mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-11 17:29:27 +00:00
shankar0123
9f41b58b2f
Phase 9 of the deploy-hardening I master bundle. The four non-file-server connectors get real ValidateOnly probes that operators use to preview a deploy without touching the live cert. Existing DeployCertificate paths already have explicit backup + rollback semantics (SCP backup / WinCertStore Get-ChildItem snapshot / keytool snapshot / K8s atomic API). SSH (validate_only.go): - Probes via SSHClient.Connect. Confirms agent reachability + credentials. Cheap (no remote command runs); released cleanly via defer Close. - A true SCP dry-run requires a no-commit upload (SCP doesn't have one). V2 ships the auth probe as the load-bearing check. - 3 new tests in validate_only_test.go. WinCertStore (validate_only.go): - Probes via PowerShell `Get-ChildItem -Path Cert:\<loc>\<store>` using the configured StoreLocation + StoreName (defaults LocalMachine\My). - Confirms agent has Windows + the IIS module + the right ACLs. - 4 new tests including default-store-path verification. JavaKeystore (validate_only.go): - Probes via `keytool -list -keystore <path> -storepass <pass>` using the configured KeystorePath / KeystorePassword and KeytoolPath (default "keytool"). - Confirms keystore exists, password is correct, JRE is on PATH. - 4 new tests covering succeeds / fails / no-path-sentinel / nil-executor-sentinel. K8s Secret (validate_only.go): - Probes via K8sClient.GetSecret on the configured Namespace + SecretName. Returns nil on success or "not found" (the CreateSecret path on Deploy will handle it). Other errors (forbidden/unreachable) surface as wrapped. - 4 new tests covering succeeds / RBAC-error wrapped / no-config-sentinel / nil-client-sentinel. Smoke test connectorsAtPhase3 list shrunk from 7 to 3 entries (ssh + wincertstore + javakeystore + k8ssecret removed). Only caddy (file-mode) + envoy + traefik remain — those three genuinely have no validate-with-target command available. Race detector clean across all 13 connectors. golangci-lint v2.11.4 clean. Phase 10 next: DeployCounters + Prometheus exposer mirroring the production-hardening-II OCSP counter pattern.
35 lines
1.0 KiB
Go
35 lines
1.0 KiB
Go
package wincertstore
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/shankar0123/certctl/internal/connector/target"
|
|
)
|
|
|
|
// ValidateOnly — Phase 9. Probes the Windows certificate store
|
|
// via Get-ChildItem against the configured store path. Confirms
|
|
// the agent has the right permissions + the store path is valid.
|
|
// V3-Pro can extend with temp-import + immediate-remove; V2 ships
|
|
// the permission probe.
|
|
func (c *Connector) ValidateOnly(ctx context.Context, request target.DeploymentRequest) error {
|
|
if c.executor == nil {
|
|
return target.ErrValidateOnlyNotSupported
|
|
}
|
|
store := c.config.StoreName
|
|
if store == "" {
|
|
store = "My"
|
|
}
|
|
loc := c.config.StoreLocation
|
|
if loc == "" {
|
|
loc = "LocalMachine"
|
|
}
|
|
storePath := fmt.Sprintf(`Cert:\%s\%s`, loc, store)
|
|
script := fmt.Sprintf(`Get-ChildItem -Path %q | Select-Object -First 1 | Format-Table -HideTableHeaders -Property Thumbprint`, storePath)
|
|
out, err := c.executor.Execute(ctx, script)
|
|
if err != nil {
|
|
return fmt.Errorf("WinCertStore ValidateOnly: %w (output: %s)", err, out)
|
|
}
|
|
return nil
|
|
}
|