mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 19:21:29 +00:00
f0865bb051
Two audit findings, both category cat-l, both rooted in
web/src/pages/CertificatesPage.tsx. Pre-L-1 the GUI looped per-cert
HTTP calls — 100 selected certs = 100 sequential round-trips × ~50–200
ms each = a 5–20-second wedge during which the operator stared at a
progress bar. Post-L-1 each workflow is a single POST.
cat-l-fa0c1ac07ab5 [P1, primary] — bulk renew loop
handleBulkRenewal: for/await triggerRenewal(id)
cat-l-8a1fb258a38a [P2] — bulk reassign loop
handleReassign: for/await updateCertificate(id, {owner_id})
The bulk-revoke endpoint (POST /api/v1/certificates/bulk-revoke +
BulkRevocationCriteria/Result) already existed as the canonical shape
in v2.0.x — L-1 ports that pattern to renew + reassign with per-action
twists.
Backend (Go)
- internal/domain/bulk_renewal.go: BulkRenewalCriteria mirrors
BulkRevocationCriteria (criteria + IDs modes); BulkRenewalResult
envelope adds EnqueuedJobs[] for per-cert {certificate_id, job_id};
shared BulkOperationError type for all bulk paths.
- internal/domain/bulk_reassignment.go: narrower shape — IDs-only,
owner_id required, team_id optional.
- internal/service/bulk_renewal.go::BulkRenewalService.BulkRenew:
resolves criteria → status filter (Archived/Revoked/Expired/
RenewalInProgress all silent-skip) → per-cert status flip + job
create. Keygen-mode-aware so jobs land in the same initial status
as single-cert TriggerRenewal. Single bulk audit event per call,
not N.
- internal/service/bulk_reassignment.go::BulkReassignmentService.
BulkReassign: validates owner_id upfront via the
ErrBulkReassignOwnerNotFound typed sentinel — non-existent owner
returns 400 before any cert is touched. Already-owned-by-target
is silent-skip. Single bulk audit event.
- internal/api/handler/{bulk_renewal,bulk_reassignment}.go: HTTP
shape mirrors bulk_revocation.go. NOT admin-gated (renew is non-
destructive; reassign is a common-case workflow). Sentinel-error
→ 400 mapping for OwnerNotFound.
- internal/api/router/router.go: three bulk-* routes registered as a
block before the {id} routes. HandlerRegistry gains BulkRenewal +
BulkReassignment fields.
- cmd/server/main.go: NewBulkRenewalService threads cfg.Keygen.Mode
so bulk-renew jobs land in same initial state as single-cert path.
Frontend
- web/src/api/client.ts: bulkRenewCertificates(criteria) +
bulkReassignCertificates(request) functions with full TS types.
- web/src/pages/CertificatesPage.tsx: handleBulkRenewal + handleReassign
rewritten from N-call loops to single calls. Result envelope drives
progress UI; first-error message surfaced when total_failed > 0.
Stale triggerRenewal + updateCertificate imports removed.
MCP
- internal/mcp/types.go: BulkRenewCertificatesInput +
BulkReassignCertificatesInput.
- internal/mcp/tools.go: certctl_bulk_renew_certificates +
certctl_bulk_reassign_certificates tools mirroring the existing
certctl_bulk_revoke_certificates pattern.
OpenAPI
- api/openapi.yaml: two new operations (bulkRenewCertificates,
bulkReassignCertificates) under Certificates tag. Four new schemas
(BulkRenewRequest, BulkRenewResult, BulkEnqueuedJob,
BulkReassignRequest, BulkReassignResult).
Tests
- Domain: BulkRenewalCriteria.IsEmpty + BulkReassignmentRequest.IsEmpty
IsEmpty contracts; JSON round-trip shape pinning.
- Service: 7 BulkRenew tests (happy/criteria-mode/skips-RenewalInProgress/
skips-revoked-archived/empty-criteria-error/partial-failure/
audit-event-emitted) + 8 BulkReassign tests (happy/skips-already-
owned/owner-required/empty-IDs/owner-not-found-sentinel/team-id-
optional/team-id-provided/partial-failure/audit-event-emitted).
- Handler: 5 BulkRenew handler tests (happy/empty-body-400/wrong-
method-405/actor-attribution/service-error-500) + 6 BulkReassign
handler tests (happy/empty-IDs-400/missing-owner-400/owner-not-
found-400-via-sentinel/wrong-method-405/generic-error-500).
CI guardrail
- .github/workflows/ci.yml: 'Forbidden client-side bulk-action loop
regression guard (L-1)'. Greps web/src/pages/CertificatesPage.tsx
for 'for(...) await triggerRenewal(...)' and 'for(...) await
updateCertificate(...)' patterns; comment lines exempt; test files
exempt. Verified locally (passes against post-fix tree, fires
against synthetic regression).
Counts (deltas)
- Routes: 119 → 121 (+2)
- OpenAPI operations: 123 → 125 (+2)
- MCP tools: 83 → 85 (+2)
Performance
- 100-cert bulk-renew: ~10s of sequential HTTP → ~100ms (99% latency
reduction on the canonical operator workflow).
- Audit event volume: 1 + N per operation → 1.
Out of scope (deferred follow-ups)
- cat-b-31ceb6aaa9f1: updateOwner/updateTeam/updateAgentGroup orphan
(different shape — wire existing PUT to GUI, not new bulk endpoint).
- cat-k-e85d1099b2d7: CertificatesPage no pagination UI.
- cat-i-b0924b6675f8: MCP missing claim/dismiss/acknowledge (L-1 added
2 new tools but does not close that finding).
Verification
- go build / vet / test -short / test -short -race all clean.
- web tsc --noEmit + vitest run all clean (296 tests passing).
- OpenAPI YAML parses (89 paths, 125 ops).
- L-1 CI guardrail passes against post-fix tree, fires against
synthetic regression.
No push.
149 lines
5.2 KiB
Go
149 lines
5.2 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"log/slog"
|
|
"strings"
|
|
|
|
"github.com/shankar0123/certctl/internal/domain"
|
|
"github.com/shankar0123/certctl/internal/repository"
|
|
)
|
|
|
|
// ErrBulkReassignOwnerNotFound is the typed sentinel for a non-existent
|
|
// target OwnerID. The handler maps it to 400 (bad input — the operator
|
|
// picked an owner that doesn't exist) rather than 500 (server error).
|
|
// Sentinel-error rather than substring-error matches the project's
|
|
// post-M-1 error-mapping convention.
|
|
var ErrBulkReassignOwnerNotFound = errors.New("owner not found")
|
|
|
|
// BulkReassignmentService coordinates bulk owner-reassignment of
|
|
// certificates.
|
|
//
|
|
// L-2 closure (cat-l-8a1fb258a38a): the GUI used to loop
|
|
// `await updateCertificate(id, { owner_id })` over the selection at
|
|
// `web/src/pages/CertificatesPage.tsx::handleReassign`. Post-L-2 the
|
|
// GUI POSTs once. Narrower than BulkRenewal: explicit IDs only, no
|
|
// criteria-mode (criteria-mode reassignment doesn't have a strong use
|
|
// case — operators query first then reassign by ID).
|
|
//
|
|
// Validation order: empty IDs → 400, missing OwnerID → 400, OwnerID
|
|
// not in owners table → 400 (ErrBulkReassignOwnerNotFound). Resolving
|
|
// the owner upfront means we fail-fast without mutating any cert if
|
|
// the operator typo'd the owner ID.
|
|
type BulkReassignmentService struct {
|
|
certRepo repository.CertificateRepository
|
|
ownerRepo repository.OwnerRepository
|
|
auditService *AuditService
|
|
logger *slog.Logger
|
|
}
|
|
|
|
// NewBulkReassignmentService creates a new BulkReassignmentService.
|
|
func NewBulkReassignmentService(
|
|
certRepo repository.CertificateRepository,
|
|
ownerRepo repository.OwnerRepository,
|
|
auditService *AuditService,
|
|
logger *slog.Logger,
|
|
) *BulkReassignmentService {
|
|
return &BulkReassignmentService{
|
|
certRepo: certRepo,
|
|
ownerRepo: ownerRepo,
|
|
auditService: auditService,
|
|
logger: logger,
|
|
}
|
|
}
|
|
|
|
// BulkReassign updates owner_id (and optionally team_id) on every cert
|
|
// in request.CertificateIDs. Skips certs whose owner_id already equals
|
|
// the target (silent no-op — surfaced as TotalSkipped++, not as a fake
|
|
// "succeeded" count, so operators see "5 of your 10 selections were
|
|
// no-ops because Alice already owned them" without triaging fake
|
|
// errors).
|
|
//
|
|
// Partial failures don't abort the batch — the failing cert lands in
|
|
// Errors[]; the loop continues. Mirrors BulkRevocationService and
|
|
// BulkRenewalService partial-failure semantics.
|
|
//
|
|
// Audit: a single audit event is emitted at the end with the criteria
|
|
// + counts. NOT N events.
|
|
func (s *BulkReassignmentService) BulkReassign(ctx context.Context, request domain.BulkReassignmentRequest, actor string) (*domain.BulkReassignmentResult, error) {
|
|
if request.IsEmpty() {
|
|
return nil, fmt.Errorf("at least one certificate_id is required")
|
|
}
|
|
if request.OwnerID == "" {
|
|
return nil, fmt.Errorf("owner_id is required")
|
|
}
|
|
|
|
// Validate the target owner exists BEFORE touching any cert. This
|
|
// fail-fast pattern means an operator who typo'd 'o-alic' (missing
|
|
// 'e') doesn't half-reassign 50 certs before the 51st surfaces the
|
|
// FK violation.
|
|
if _, err := s.ownerRepo.Get(ctx, request.OwnerID); err != nil {
|
|
return nil, fmt.Errorf("%w: %s", ErrBulkReassignOwnerNotFound, request.OwnerID)
|
|
}
|
|
|
|
result := &domain.BulkReassignmentResult{}
|
|
|
|
for _, id := range request.CertificateIDs {
|
|
cert, err := s.certRepo.Get(ctx, id)
|
|
if err != nil {
|
|
result.TotalFailed++
|
|
result.Errors = append(result.Errors, domain.BulkOperationError{
|
|
CertificateID: id,
|
|
Error: fmt.Sprintf("failed to fetch certificate: %v", err),
|
|
})
|
|
continue
|
|
}
|
|
result.TotalMatched++
|
|
|
|
// No-op skip: cert already owned by the target. team_id may
|
|
// still differ — we still skip if owner matches AND
|
|
// team_id-update is a no-op (team unchanged or team_id field
|
|
// not set on the request). This prevents fake "reassigned"
|
|
// counts when nothing actually changed.
|
|
ownerUnchanged := cert.OwnerID == request.OwnerID
|
|
teamUnchanged := request.TeamID == "" || cert.TeamID == request.TeamID
|
|
if ownerUnchanged && teamUnchanged {
|
|
result.TotalSkipped++
|
|
continue
|
|
}
|
|
|
|
cert.OwnerID = request.OwnerID
|
|
if request.TeamID != "" {
|
|
cert.TeamID = request.TeamID
|
|
}
|
|
if err := s.certRepo.Update(ctx, cert); err != nil {
|
|
result.TotalFailed++
|
|
result.Errors = append(result.Errors, domain.BulkOperationError{
|
|
CertificateID: id,
|
|
Error: fmt.Sprintf("failed to update certificate: %v", err),
|
|
})
|
|
s.logger.Warn("bulk reassignment: update failed",
|
|
"certificate_id", id, "error", err)
|
|
continue
|
|
}
|
|
result.TotalReassigned++
|
|
}
|
|
|
|
// Single bulk audit event at the end.
|
|
auditDetails := map[string]interface{}{
|
|
"owner_id": request.OwnerID,
|
|
"certificate_ids": strings.Join(request.CertificateIDs, ","),
|
|
"total_matched": result.TotalMatched,
|
|
"total_reassigned": result.TotalReassigned,
|
|
"total_skipped": result.TotalSkipped,
|
|
"total_failed": result.TotalFailed,
|
|
}
|
|
if request.TeamID != "" {
|
|
auditDetails["team_id"] = request.TeamID
|
|
}
|
|
if err := s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser,
|
|
"bulk_reassignment_initiated", "certificate", "bulk",
|
|
auditDetails); err != nil {
|
|
s.logger.Error("failed to record bulk reassignment audit event", "error", err)
|
|
}
|
|
|
|
return result, nil
|
|
}
|