mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 13:51:36 +00:00
shankar0123
1caedd5fd3
Bundle: ci-pipeline-cleanup, Phase 1. Pure relocation — no behavior change. Each guard's bash logic is byte-identical to the prior inline version; the only changes are: (a) the guard becomes a sibling script under scripts/ci-guards/<id>.sh, (b) ci.yml's per-guard step is replaced by a single loop step that iterates all scripts. 20 scripts extracted (alphabetized): B-1-orphan-crud.sh, D-1-D-2-statusbadge-phantom.sh, G-1-jwt-auth-literal.sh, G-2-api-key-hash-json.sh, G-3-env-docs-drift.sh, H-001-bare-from.sh, H-009-readme-jwt.sh, L-001-insecure-skip-verify.sh, L-1-bulk-action-loop.sh, M-012-no-root-user.sh, P-1-documented-orphan-fns.sh, S-1-hardcoded-source-counts.sh, S-2-strings-contains-err.sh, T-1-frontend-page-coverage.sh, U-2-plaintext-healthcheck.sh, U-3-migration-mount.sh, bundle-8-L-015-target-blank-rel-noopener.sh, bundle-8-L-019-dangerously-set-inner-html.sh, bundle-8-M-009-bare-usemutation.sh, test-naming-convention.sh Plus scripts/ci-guards/README.md documenting the contract: - Each script must exit 0 on clean repo, non-zero with ::error:: prefix on regression - Runnable from repo root via 'bash scripts/ci-guards/<id>.sh' - Adding a new guard: drop a new <id>.sh; CI auto-picks it up ci.yml dropped 1488 → 557 lines (-931, -63%). Single CI loop step now collects ALL guard failures before failing the build instead of fail-fast — UX win for regressions that hit two guards at once. Two guards (QA-doc Part-count + seed-count, ci.yml lines 868-917) deliberately NOT extracted — they move to 'make verify-docs' in Phase 11 because they protect docs-the-operator-reads, not the product itself. Verification (sandbox): - All 20 scripts pass against HEAD (chmod +x; for g in scripts/ci-guards/*.sh; do bash $g; done) - New ci.yml YAML-parses cleanly - Job boundaries preserved: go-build-and-test, frontend-build, helm-lint, deploy-vendor-e2e, deploy-vendor-e2e-windows - Loop step appears twice (once at end of go-build-and-test, once at end of frontend-build) so both jobs continue running their set of guards
52 lines
2.2 KiB
Bash
Executable File
52 lines
2.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# scripts/ci-guards/U-2-plaintext-healthcheck.sh
|
|
#
|
|
# U-2 closed cat-u-healthcheck_protocol_mismatch by switching the
|
|
# published image's HEALTHCHECK from `curl -f http://localhost:
|
|
# 8443/health` (always failed against the HTTPS-only listener) to
|
|
# `curl -fsk https://localhost:8443/health`. This script grep-fails
|
|
# the build if any Dockerfile in the repo carries the pre-U-2
|
|
# plaintext shape — either explicitly (`http://localhost:8443/
|
|
# health` in a HEALTHCHECK) or via the looser pattern of any
|
|
# HEALTHCHECK that targets `http://` against the certctl server
|
|
# port.
|
|
#
|
|
# Comment lines and the docs/upgrade-to-tls.md:182 expected-to-
|
|
# fail invariant ("plaintext is gone, expect Connection refused")
|
|
# are intentionally exempt — we DO want the upgrade-doc string
|
|
# `http://localhost:8443/health` to remain there, since it
|
|
# documents what operators should test for to confirm plaintext
|
|
# is dead. The guardrail is scoped to Dockerfile* only, so docs
|
|
# are out of its reach.
|
|
#
|
|
# See coverage-gap-audit-2026-04-24-v5/unified-audit.md
|
|
# cat-u-healthcheck_protocol_mismatch for the closure rationale,
|
|
# or deploy/test/healthcheck_test.go for the binary-image
|
|
# contract the runtime test pins.
|
|
|
|
set -e
|
|
|
|
# Patterns that catch the actual regression shapes:
|
|
# - HEALTHCHECK directive carrying any http:// (even if the
|
|
# port differs, no plaintext probe should ship).
|
|
# - The exact pre-U-2 string for grep-friendliness.
|
|
BAD=$(grep -rnEH \
|
|
-e 'HEALTHCHECK.*http://' \
|
|
-e 'curl[^|&;]*-f[^|&;]*http://localhost:8443/health' \
|
|
Dockerfile Dockerfile.agent Dockerfile.* 2>/dev/null \
|
|
| grep -vE '^\s*[^:]+:[0-9]+:\s*#' \
|
|
|| true)
|
|
if [ -n "$BAD" ]; then
|
|
echo "::error::U-2 regression: plaintext HEALTHCHECK reappeared in a Dockerfile:"
|
|
echo "$BAD"
|
|
echo ""
|
|
echo "Allowed: HTTPS HEALTHCHECK with -k (acceptable for"
|
|
echo "localhost-to-localhost), or non-HTTP probe shapes"
|
|
echo "(pgrep, /proc check). See Dockerfile / Dockerfile.agent"
|
|
echo "for the post-U-2 reference shape and"
|
|
echo "coverage-gap-audit-2026-04-24-v5/unified-audit.md"
|
|
echo "cat-u-healthcheck_protocol_mismatch for rationale."
|
|
exit 1
|
|
fi
|
|
echo "U-2 plaintext-healthcheck: clean."
|