mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 20:51:30 +00:00
0e29c416b1
Closes one 2026-04-24 audit finding (P2):
- cat-s6-efc7f6f6bd50: 30 strings.Contains(err.Error(), ...) sites
in internal/api/handler/ — brittle to repository-layer message
changes, untyped against the actual failure mode.
Approach (Option B from prompt design notes):
- New typed sentinels in internal/repository/errors.go:
ErrNotFound, ErrForeignKeyConstraint
IsForeignKeyError(err) helper (the only place substring
matching at the lib/pq boundary is allowed; isolates the
DB-driver string knowledge to one function).
- New typed sentinel in internal/domain/errors.go:
ErrValidation (reserved for future per-entity validation
wrappers; not yet used by all handlers).
- 49 sites in internal/repository/postgres/*.go updated to wrap
sql.ErrNoRows-derived errors via fmt.Errorf("...: %w",
repository.ErrNotFound).
- 18 not-found handler sites + 2 FK-constraint handler sites
refactored to errors.Is(err, repository.ErrNotFound) /
repository.IsForeignKeyError(err).
- 23 inline `fmt.Errorf("X not found")` test fixtures across
handler tests rewrapped to wrap repository.ErrNotFound.
- test_utils.go::ErrMockNotFound rewrapped to wrap
repository.ErrNotFound; renewal_policy.go closure docblock
updated to reflect the new convention.
- integration test mockJobRepository.Get wraps repository.ErrNotFound.
CI regression guardrail:
- .github/workflows/ci.yml::"Forbidden strings.Contains(err.Error())
regression guard (S-2)" greps for the three patterns ("not found",
"violates foreign key", "RESTRICT") under internal/api/handler/
and fails the build on regression.
Verification:
- go build ./... — clean
- go vet ./... — clean
- go test ./... -short -count=1 — all packages pass (handler +
repository + service + integration)
- golangci-lint v2.11.4 run ./... — 0 issues
- S-2 guardrail dry-run on post-fix tree → empty (good)
- All sibling guardrails (S-1, G-3, D-1+D-2, B-1, L-1, H-1, C-1, F-1, P-1) pass
Audit findings closed:
- cat-s6-efc7f6f6bd50 (P2)
Deferred follow-ups:
- 6 domain-specific substring patterns still inline in handlers
("cannot approve", "cannot reject", "cannot be parsed",
"no certificates found", "challenge password", "invalid"/
"required" validation chains in profiles + agent_groups). Each
needs its own typed sentinel, scoped per service. Documented
by the S-2 CI guardrail's allowlist for closure-comments only.
- Per-entity not-found sentinels (Option A — ErrCertificateNotFound,
ErrAgentNotFound, etc.) deferred. Generic ErrNotFound covers the
current dispatch needs; per-entity precision would let handlers
return entity-aware error bodies without a domain.Type field,
but not blocking.
258 lines
7.8 KiB
Go
258 lines
7.8 KiB
Go
package handler
|
|
|
|
import (
|
|
"github.com/shankar0123/certctl/internal/repository"
|
|
"errors"
|
|
"context"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"net/http"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/shankar0123/certctl/internal/api/middleware"
|
|
"github.com/shankar0123/certctl/internal/domain"
|
|
)
|
|
|
|
// IssuerService defines the service interface for issuer operations.
|
|
type IssuerService interface {
|
|
ListIssuers(ctx context.Context, page, perPage int) ([]domain.Issuer, int64, error)
|
|
GetIssuer(ctx context.Context, id string) (*domain.Issuer, error)
|
|
CreateIssuer(ctx context.Context, issuer domain.Issuer) (*domain.Issuer, error)
|
|
UpdateIssuer(ctx context.Context, id string, issuer domain.Issuer) (*domain.Issuer, error)
|
|
DeleteIssuer(ctx context.Context, id string) error
|
|
TestConnection(ctx context.Context, id string) error
|
|
}
|
|
|
|
// IssuerHandler handles HTTP requests for issuer operations.
|
|
type IssuerHandler struct {
|
|
svc IssuerService
|
|
logger *slog.Logger
|
|
}
|
|
|
|
// NewIssuerHandler creates a new IssuerHandler with a service dependency.
|
|
func NewIssuerHandler(svc IssuerService) IssuerHandler {
|
|
return IssuerHandler{svc: svc, logger: slog.Default()}
|
|
}
|
|
|
|
// NewIssuerHandlerWithLogger creates a new IssuerHandler with a custom logger.
|
|
func NewIssuerHandlerWithLogger(svc IssuerService, logger *slog.Logger) IssuerHandler {
|
|
return IssuerHandler{svc: svc, logger: logger}
|
|
}
|
|
|
|
// ListIssuers lists all configured issuers.
|
|
// GET /api/v1/issuers?page=1&per_page=50
|
|
func (h IssuerHandler) ListIssuers(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodGet {
|
|
Error(w, http.StatusMethodNotAllowed, "Method not allowed")
|
|
return
|
|
}
|
|
|
|
requestID := middleware.GetRequestID(r.Context())
|
|
|
|
page := 1
|
|
perPage := 50
|
|
query := r.URL.Query()
|
|
if p := query.Get("page"); p != "" {
|
|
if parsed, err := strconv.Atoi(p); err == nil && parsed > 0 {
|
|
page = parsed
|
|
}
|
|
}
|
|
if pp := query.Get("per_page"); pp != "" {
|
|
if parsed, err := strconv.Atoi(pp); err == nil && parsed > 0 && parsed <= 500 {
|
|
perPage = parsed
|
|
}
|
|
}
|
|
|
|
issuers, total, err := h.svc.ListIssuers(r.Context(), page, perPage)
|
|
if err != nil {
|
|
ErrorWithRequestID(w, http.StatusInternalServerError, "Failed to list issuers", requestID)
|
|
return
|
|
}
|
|
|
|
response := PagedResponse{
|
|
Data: issuers,
|
|
Total: total,
|
|
Page: page,
|
|
PerPage: perPage,
|
|
}
|
|
|
|
JSON(w, http.StatusOK, response)
|
|
}
|
|
|
|
// GetIssuer retrieves a single issuer by ID.
|
|
// GET /api/v1/issuers/{id}
|
|
func (h IssuerHandler) GetIssuer(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodGet {
|
|
Error(w, http.StatusMethodNotAllowed, "Method not allowed")
|
|
return
|
|
}
|
|
|
|
requestID := middleware.GetRequestID(r.Context())
|
|
|
|
id := strings.TrimPrefix(r.URL.Path, "/api/v1/issuers/")
|
|
if id == "" || strings.Contains(id, "/") {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "Issuer ID is required", requestID)
|
|
return
|
|
}
|
|
|
|
issuer, err := h.svc.GetIssuer(r.Context(), id)
|
|
if err != nil {
|
|
ErrorWithRequestID(w, http.StatusNotFound, "Issuer not found", requestID)
|
|
return
|
|
}
|
|
|
|
JSON(w, http.StatusOK, issuer)
|
|
}
|
|
|
|
// CreateIssuer creates a new issuer configuration.
|
|
// POST /api/v1/issuers
|
|
func (h IssuerHandler) CreateIssuer(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodPost {
|
|
Error(w, http.StatusMethodNotAllowed, "Method not allowed")
|
|
return
|
|
}
|
|
|
|
requestID := middleware.GetRequestID(r.Context())
|
|
|
|
var issuer domain.Issuer
|
|
if err := json.NewDecoder(r.Body).Decode(&issuer); err != nil {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "Invalid request body", requestID)
|
|
return
|
|
}
|
|
|
|
// Validate required fields
|
|
if err := ValidateRequired("name", issuer.Name); err != nil {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, err.Error(), requestID)
|
|
return
|
|
}
|
|
if err := ValidateStringLength("name", issuer.Name, 255); err != nil {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, err.Error(), requestID)
|
|
return
|
|
}
|
|
if issuer.Type == "" {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "type is required", requestID)
|
|
return
|
|
}
|
|
|
|
created, err := h.svc.CreateIssuer(r.Context(), issuer)
|
|
if err != nil {
|
|
h.logger.Error("failed to create issuer", "error", err, "name", issuer.Name, "type", issuer.Type)
|
|
errMsg := err.Error()
|
|
switch {
|
|
case strings.Contains(errMsg, "unique") || strings.Contains(errMsg, "duplicate"):
|
|
ErrorWithRequestID(w, http.StatusConflict, "An issuer with this name already exists", requestID)
|
|
case strings.Contains(errMsg, "unsupported issuer type"):
|
|
ErrorWithRequestID(w, http.StatusBadRequest, errMsg, requestID)
|
|
default:
|
|
ErrorWithRequestID(w, http.StatusInternalServerError, "Failed to create issuer", requestID)
|
|
}
|
|
return
|
|
}
|
|
|
|
JSON(w, http.StatusCreated, created)
|
|
}
|
|
|
|
// UpdateIssuer updates an existing issuer configuration.
|
|
// PUT /api/v1/issuers/{id}
|
|
func (h IssuerHandler) UpdateIssuer(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodPut {
|
|
Error(w, http.StatusMethodNotAllowed, "Method not allowed")
|
|
return
|
|
}
|
|
|
|
requestID := middleware.GetRequestID(r.Context())
|
|
|
|
id := strings.TrimPrefix(r.URL.Path, "/api/v1/issuers/")
|
|
parts := strings.Split(id, "/")
|
|
if len(parts) == 0 || parts[0] == "" {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "Issuer ID is required", requestID)
|
|
return
|
|
}
|
|
id = parts[0]
|
|
|
|
var issuer domain.Issuer
|
|
if err := json.NewDecoder(r.Body).Decode(&issuer); err != nil {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "Invalid request body", requestID)
|
|
return
|
|
}
|
|
|
|
updated, err := h.svc.UpdateIssuer(r.Context(), id, issuer)
|
|
if err != nil {
|
|
h.logger.Error("failed to update issuer", "error", err, "id", id)
|
|
errMsg := err.Error()
|
|
switch {
|
|
case strings.Contains(errMsg, "unique") || strings.Contains(errMsg, "duplicate"):
|
|
ErrorWithRequestID(w, http.StatusConflict, "An issuer with this name already exists", requestID)
|
|
case strings.Contains(errMsg, "not found"):
|
|
ErrorWithRequestID(w, http.StatusNotFound, "Issuer not found", requestID)
|
|
default:
|
|
ErrorWithRequestID(w, http.StatusInternalServerError, "Failed to update issuer", requestID)
|
|
}
|
|
return
|
|
}
|
|
|
|
JSON(w, http.StatusOK, updated)
|
|
}
|
|
|
|
// DeleteIssuer deletes an issuer configuration.
|
|
// DELETE /api/v1/issuers/{id}
|
|
func (h IssuerHandler) DeleteIssuer(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodDelete {
|
|
Error(w, http.StatusMethodNotAllowed, "Method not allowed")
|
|
return
|
|
}
|
|
|
|
requestID := middleware.GetRequestID(r.Context())
|
|
|
|
id := strings.TrimPrefix(r.URL.Path, "/api/v1/issuers/")
|
|
if id == "" || strings.Contains(id, "/") {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "Issuer ID is required", requestID)
|
|
return
|
|
}
|
|
|
|
if err := h.svc.DeleteIssuer(r.Context(), id); err != nil {
|
|
if repository.IsForeignKeyError(err) {
|
|
ErrorWithRequestID(w, http.StatusConflict, "Cannot delete issuer: certificates are still using this issuer", requestID)
|
|
} else if errors.Is(err, repository.ErrNotFound) {
|
|
ErrorWithRequestID(w, http.StatusNotFound, "Issuer not found", requestID)
|
|
} else {
|
|
ErrorWithRequestID(w, http.StatusInternalServerError, "Failed to delete issuer", requestID)
|
|
}
|
|
return
|
|
}
|
|
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
|
|
// TestConnection tests the connection to an issuer.
|
|
// POST /api/v1/issuers/{id}/test
|
|
func (h IssuerHandler) TestConnection(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodPost {
|
|
Error(w, http.StatusMethodNotAllowed, "Method not allowed")
|
|
return
|
|
}
|
|
|
|
requestID := middleware.GetRequestID(r.Context())
|
|
|
|
// Extract issuer ID from path /api/v1/issuers/{id}/test
|
|
path := strings.TrimPrefix(r.URL.Path, "/api/v1/issuers/")
|
|
parts := strings.Split(path, "/")
|
|
if len(parts) < 2 || parts[0] == "" {
|
|
ErrorWithRequestID(w, http.StatusBadRequest, "Issuer ID is required", requestID)
|
|
return
|
|
}
|
|
issuerID := parts[0]
|
|
|
|
if err := h.svc.TestConnection(r.Context(), issuerID); err != nil {
|
|
ErrorWithRequestID(w, http.StatusInternalServerError, "Connection test failed", requestID)
|
|
return
|
|
}
|
|
|
|
response := map[string]string{
|
|
"status": "connection_successful",
|
|
}
|
|
|
|
JSON(w, http.StatusOK, response)
|
|
}
|