mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 20:11:31 +00:00
bd54d5f7fa
Bundle 1 / Phase 2: ships PermissionService, RoleService, ActorRoleService, and the Authorizer primitive that Phase 3 RequirePermission middleware calls on every gated request.
Authorizer.CheckPermission semantics: a grant matches when (a) the permission name equals the requested permission AND (b) the grant is global-scoped OR the grant scope_type+scope_id exactly match the request. Global beats specific; per-resource grants widen the effective set rather than shadowing global. Hot-path query is one ActorRoleRepository.EffectivePermissions JOIN call (already shipped in Phase 1) plus an in-memory walk; Phase 12 will add benchmarks + caching if the JOIN cost shows up at scale.
Privilege-escalation guard: ActorRoleService.Grant and Revoke require the caller to hold auth.role.assign globally. Without it, ErrSelfRoleAssignment. System callers (AsSystemCaller()) bypass the check; bootstrap, migrations, scheduler-initiated grants use this path. Reserved actor actor-demo-anon is rejected on Grant + Revoke so the demo path stays alive even after a misclick (ErrAuthReservedActor).
Caller abstraction: every service entry point takes *Caller (ActorID, ActorType, TenantID, IsSystem). CallerFromContext is a stub returning ErrUnauthenticated; Phase 3 wires the middleware-context bridge that fills the Caller from request context. The contract is pinned by TestCallerFromContext_Phase2ReturnsUnauthenticated so the Phase 3 upgrade is observable.
Audit recording: every mutating service operation calls AuditService.RecordEvent. Bundle 1 Phase 8 adds the event_category column + parameter and back-fills 'auth' for these calls; until then the rows go in with the default category.
Test coverage: in-memory fakeRoleRepo / fakePermissionRepo / fakeActorRoleRepo / fakeAudit pin the privilege-escalation invariants (ErrUnauthenticated for nil caller, ErrForbidden for missing perm, ErrInvalidPermission for non-canonical permission name, ErrSelfRoleAssignment for Grant without auth.role.assign, ErrAuthReservedActor for actor-demo-anon mutations, system-caller bypass) without requiring testcontainers. Phase 12 will add live-Postgres integration coverage.
Branch: dev/auth-bundle-1. Phase 1 was 19497ee (RBAC schema + repo). Phase 3 (middleware integration) is the next commit on this branch.
117 lines
3.5 KiB
Go
117 lines
3.5 KiB
Go
package auth
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
authdomain "github.com/certctl-io/certctl/internal/domain/auth"
|
|
"github.com/certctl-io/certctl/internal/repository"
|
|
)
|
|
|
|
// Authorizer is the load-bearing "can this actor do this thing on this
|
|
// resource" check. Bundle 1 Phase 3 wires it into the RequirePermission
|
|
// middleware factory; every gated request runs through this on the hot
|
|
// path.
|
|
//
|
|
// Semantics: a permission grant matches when ALL of the following hold:
|
|
//
|
|
// 1. The granted permission name equals the requested permission name.
|
|
// 2. Either the grant is global-scoped (covers all resources of that
|
|
// type) OR the grant scope_type + scope_id exactly match the
|
|
// request's scope.
|
|
//
|
|
// Global beats specific: an actor with `cert.read` at scope `global`
|
|
// can read every certificate, regardless of per-cert scoped grants.
|
|
// Per-resource grants do NOT shadow global grants; they widen the
|
|
// effective set.
|
|
//
|
|
// The actor's effective permission set is the deduplicated union
|
|
// across every role they hold. ActorRoleRepository.EffectivePermissions
|
|
// already returns the union via SQL JOIN, so the in-memory matcher
|
|
// just walks the result.
|
|
type Authorizer struct {
|
|
actorRepo repository.ActorRoleRepository
|
|
}
|
|
|
|
// NewAuthorizer constructs an Authorizer.
|
|
func NewAuthorizer(actorRepo repository.ActorRoleRepository) *Authorizer {
|
|
return &Authorizer{actorRepo: actorRepo}
|
|
}
|
|
|
|
// CheckPermission returns true when the actor holds the named
|
|
// permission at the requested scope (or globally). Returns false (no
|
|
// error) when the actor exists but lacks the permission. Returns an
|
|
// error only on repository / database failure; callers treat that as
|
|
// a 500-class problem.
|
|
//
|
|
// The synthetic actor `actor-demo-anon` (used when CERTCTL_AUTH_TYPE=
|
|
// none) holds the admin role per the migration seed; CheckPermission
|
|
// resolves through that grant just like any other actor.
|
|
func (a *Authorizer) CheckPermission(
|
|
ctx context.Context,
|
|
actorID string,
|
|
actorType authdomain.ActorTypeValue,
|
|
tenantID string,
|
|
permission string,
|
|
scopeType authdomain.ScopeType,
|
|
scopeID *string,
|
|
) (bool, error) {
|
|
if actorID == "" {
|
|
return false, nil
|
|
}
|
|
if tenantID == "" {
|
|
tenantID = authdomain.DefaultTenantID
|
|
}
|
|
|
|
effective, err := a.actorRepo.EffectivePermissions(ctx, actorID, actorType, tenantID)
|
|
if err != nil {
|
|
return false, fmt.Errorf("authorizer.CheckPermission: %w", err)
|
|
}
|
|
|
|
for _, ep := range effective {
|
|
if ep.PermissionName != permission {
|
|
continue
|
|
}
|
|
// Global grant always matches.
|
|
if ep.ScopeType == authdomain.ScopeTypeGlobal {
|
|
return true, nil
|
|
}
|
|
// Specific grant requires scope_type + scope_id match.
|
|
if ep.ScopeType != scopeType {
|
|
continue
|
|
}
|
|
if scopeID == nil || ep.ScopeID == nil {
|
|
// Scope-typed grant without ID, or request without ID.
|
|
// Treat as no match: per-profile / per-issuer scopes
|
|
// require an explicit ID.
|
|
continue
|
|
}
|
|
if *ep.ScopeID == *scopeID {
|
|
return true, nil
|
|
}
|
|
}
|
|
return false, nil
|
|
}
|
|
|
|
// HoldsAnyOf returns true when the actor holds at least one of the
|
|
// named permissions globally. Used by privilege-escalation guards
|
|
// (e.g. ActorRoleService.Grant: caller must hold auth.role.assign).
|
|
func (a *Authorizer) HoldsAnyOf(
|
|
ctx context.Context,
|
|
actorID string,
|
|
actorType authdomain.ActorTypeValue,
|
|
tenantID string,
|
|
permissions ...string,
|
|
) (bool, error) {
|
|
for _, p := range permissions {
|
|
ok, err := a.CheckPermission(ctx, actorID, actorType, tenantID, p, authdomain.ScopeTypeGlobal, nil)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
if ok {
|
|
return true, nil
|
|
}
|
|
}
|
|
return false, nil
|
|
}
|