mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 17:02:43 +00:00
8526314a44
All 7 handler files now have test coverage: jobs (14 tests), notifications (11), policies (15), issuers (15), targets (14). Negative-path integration tests cover nonexistent resources, invalid payloads, malformed CSR, expired cert lifecycle, and method-not-allowed errors. CI now enforces coverage thresholds (service 60%+, handler 50%+) and includes connector tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
428 lines
11 KiB
Go
428 lines
11 KiB
Go
package handler
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/shankar0123/certctl/internal/domain"
|
|
)
|
|
|
|
// MockIssuerService is a mock implementation of IssuerService interface.
|
|
type MockIssuerService struct {
|
|
ListIssuersFn func(page, perPage int) ([]domain.Issuer, int64, error)
|
|
GetIssuerFn func(id string) (*domain.Issuer, error)
|
|
CreateIssuerFn func(issuer domain.Issuer) (*domain.Issuer, error)
|
|
UpdateIssuerFn func(id string, issuer domain.Issuer) (*domain.Issuer, error)
|
|
DeleteIssuerFn func(id string) error
|
|
TestConnectionFn func(id string) error
|
|
}
|
|
|
|
func (m *MockIssuerService) ListIssuers(page, perPage int) ([]domain.Issuer, int64, error) {
|
|
if m.ListIssuersFn != nil {
|
|
return m.ListIssuersFn(page, perPage)
|
|
}
|
|
return nil, 0, nil
|
|
}
|
|
|
|
func (m *MockIssuerService) GetIssuer(id string) (*domain.Issuer, error) {
|
|
if m.GetIssuerFn != nil {
|
|
return m.GetIssuerFn(id)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (m *MockIssuerService) CreateIssuer(issuer domain.Issuer) (*domain.Issuer, error) {
|
|
if m.CreateIssuerFn != nil {
|
|
return m.CreateIssuerFn(issuer)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (m *MockIssuerService) UpdateIssuer(id string, issuer domain.Issuer) (*domain.Issuer, error) {
|
|
if m.UpdateIssuerFn != nil {
|
|
return m.UpdateIssuerFn(id, issuer)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (m *MockIssuerService) DeleteIssuer(id string) error {
|
|
if m.DeleteIssuerFn != nil {
|
|
return m.DeleteIssuerFn(id)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (m *MockIssuerService) TestConnection(id string) error {
|
|
if m.TestConnectionFn != nil {
|
|
return m.TestConnectionFn(id)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func TestListIssuers_Success(t *testing.T) {
|
|
now := time.Now()
|
|
iss1 := domain.Issuer{
|
|
ID: "iss-local",
|
|
Name: "Local CA",
|
|
Type: "LocalCA",
|
|
Enabled: true,
|
|
CreatedAt: now,
|
|
UpdatedAt: now,
|
|
}
|
|
iss2 := domain.Issuer{
|
|
ID: "iss-acme",
|
|
Name: "ACME Staging",
|
|
Type: "ACME",
|
|
Enabled: true,
|
|
CreatedAt: now,
|
|
UpdatedAt: now,
|
|
}
|
|
|
|
mock := &MockIssuerService{
|
|
ListIssuersFn: func(page, perPage int) ([]domain.Issuer, int64, error) {
|
|
return []domain.Issuer{iss1, iss2}, 2, nil
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/issuers", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.ListIssuers(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected status 200, got %d", w.Code)
|
|
}
|
|
|
|
var resp PagedResponse
|
|
if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
|
|
t.Fatalf("failed to decode response: %v", err)
|
|
}
|
|
if resp.Total != 2 {
|
|
t.Errorf("expected total 2, got %d", resp.Total)
|
|
}
|
|
}
|
|
|
|
func TestListIssuers_Pagination(t *testing.T) {
|
|
var capturedPage, capturedPerPage int
|
|
mock := &MockIssuerService{
|
|
ListIssuersFn: func(page, perPage int) ([]domain.Issuer, int64, error) {
|
|
capturedPage = page
|
|
capturedPerPage = perPage
|
|
return []domain.Issuer{}, 0, nil
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/issuers?page=2&per_page=10", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.ListIssuers(w, req)
|
|
|
|
if capturedPage != 2 {
|
|
t.Errorf("expected page 2, got %d", capturedPage)
|
|
}
|
|
if capturedPerPage != 10 {
|
|
t.Errorf("expected per_page 10, got %d", capturedPerPage)
|
|
}
|
|
}
|
|
|
|
func TestListIssuers_ServiceError(t *testing.T) {
|
|
mock := &MockIssuerService{
|
|
ListIssuersFn: func(page, perPage int) ([]domain.Issuer, int64, error) {
|
|
return nil, 0, ErrMockServiceFailed
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/issuers", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.ListIssuers(w, req)
|
|
|
|
if w.Code != http.StatusInternalServerError {
|
|
t.Fatalf("expected status 500, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestListIssuers_MethodNotAllowed(t *testing.T) {
|
|
handler := NewIssuerHandler(&MockIssuerService{})
|
|
req := httptest.NewRequest(http.MethodDelete, "/api/v1/issuers", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.ListIssuers(w, req)
|
|
|
|
if w.Code != http.StatusMethodNotAllowed {
|
|
t.Fatalf("expected status 405, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestGetIssuer_Success(t *testing.T) {
|
|
now := time.Now()
|
|
mock := &MockIssuerService{
|
|
GetIssuerFn: func(id string) (*domain.Issuer, error) {
|
|
return &domain.Issuer{
|
|
ID: id,
|
|
Name: "Local CA",
|
|
Type: "LocalCA",
|
|
Enabled: true,
|
|
CreatedAt: now,
|
|
UpdatedAt: now,
|
|
}, nil
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/issuers/iss-local", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.GetIssuer(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected status 200, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestGetIssuer_NotFound(t *testing.T) {
|
|
mock := &MockIssuerService{
|
|
GetIssuerFn: func(id string) (*domain.Issuer, error) {
|
|
return nil, ErrMockNotFound
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/issuers/nonexistent", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.GetIssuer(w, req)
|
|
|
|
if w.Code != http.StatusNotFound {
|
|
t.Fatalf("expected status 404, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestGetIssuer_EmptyID(t *testing.T) {
|
|
handler := NewIssuerHandler(&MockIssuerService{})
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/issuers/", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.GetIssuer(w, req)
|
|
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Fatalf("expected status 400, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestCreateIssuer_Success(t *testing.T) {
|
|
now := time.Now()
|
|
mock := &MockIssuerService{
|
|
CreateIssuerFn: func(issuer domain.Issuer) (*domain.Issuer, error) {
|
|
issuer.ID = "iss-new"
|
|
issuer.CreatedAt = now
|
|
issuer.UpdatedAt = now
|
|
return &issuer, nil
|
|
},
|
|
}
|
|
|
|
body := map[string]interface{}{
|
|
"name": "New Issuer",
|
|
"type": "LocalCA",
|
|
}
|
|
bodyBytes, _ := json.Marshal(body)
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/issuers", bytes.NewReader(bodyBytes))
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.CreateIssuer(w, req)
|
|
|
|
if w.Code != http.StatusCreated {
|
|
t.Fatalf("expected status 201, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestCreateIssuer_MissingName(t *testing.T) {
|
|
body := map[string]interface{}{
|
|
"type": "LocalCA",
|
|
}
|
|
bodyBytes, _ := json.Marshal(body)
|
|
|
|
handler := NewIssuerHandler(&MockIssuerService{})
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/issuers", bytes.NewReader(bodyBytes))
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.CreateIssuer(w, req)
|
|
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Fatalf("expected status 400, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestCreateIssuer_MissingType(t *testing.T) {
|
|
body := map[string]interface{}{
|
|
"name": "New Issuer",
|
|
}
|
|
bodyBytes, _ := json.Marshal(body)
|
|
|
|
handler := NewIssuerHandler(&MockIssuerService{})
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/issuers", bytes.NewReader(bodyBytes))
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.CreateIssuer(w, req)
|
|
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Fatalf("expected status 400, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestCreateIssuer_InvalidJSON(t *testing.T) {
|
|
handler := NewIssuerHandler(&MockIssuerService{})
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/issuers", bytes.NewReader([]byte("{invalid")))
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.CreateIssuer(w, req)
|
|
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Fatalf("expected status 400, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestCreateIssuer_NameTooLong(t *testing.T) {
|
|
longName := ""
|
|
for i := 0; i < 256; i++ {
|
|
longName += "x"
|
|
}
|
|
body := map[string]interface{}{
|
|
"name": longName,
|
|
"type": "LocalCA",
|
|
}
|
|
bodyBytes, _ := json.Marshal(body)
|
|
|
|
handler := NewIssuerHandler(&MockIssuerService{})
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/issuers", bytes.NewReader(bodyBytes))
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.CreateIssuer(w, req)
|
|
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Fatalf("expected status 400, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestDeleteIssuer_Success(t *testing.T) {
|
|
var deletedID string
|
|
mock := &MockIssuerService{
|
|
DeleteIssuerFn: func(id string) error {
|
|
deletedID = id
|
|
return nil
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodDelete, "/api/v1/issuers/iss-local", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.DeleteIssuer(w, req)
|
|
|
|
if w.Code != http.StatusNoContent {
|
|
t.Fatalf("expected status 204, got %d", w.Code)
|
|
}
|
|
if deletedID != "iss-local" {
|
|
t.Errorf("expected deleted ID 'iss-local', got '%s'", deletedID)
|
|
}
|
|
}
|
|
|
|
func TestDeleteIssuer_ServiceError(t *testing.T) {
|
|
mock := &MockIssuerService{
|
|
DeleteIssuerFn: func(id string) error {
|
|
return ErrMockServiceFailed
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodDelete, "/api/v1/issuers/iss-local", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.DeleteIssuer(w, req)
|
|
|
|
if w.Code != http.StatusInternalServerError {
|
|
t.Fatalf("expected status 500, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestTestConnection_Success(t *testing.T) {
|
|
mock := &MockIssuerService{
|
|
TestConnectionFn: func(id string) error {
|
|
return nil
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/issuers/iss-local/test", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.TestConnection(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected status 200, got %d", w.Code)
|
|
}
|
|
|
|
var resp map[string]string
|
|
if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
|
|
t.Fatalf("failed to decode response: %v", err)
|
|
}
|
|
if resp["status"] != "connection_successful" {
|
|
t.Errorf("expected status 'connection_successful', got '%s'", resp["status"])
|
|
}
|
|
}
|
|
|
|
func TestTestConnection_Failure(t *testing.T) {
|
|
mock := &MockIssuerService{
|
|
TestConnectionFn: func(id string) error {
|
|
return ErrMockServiceFailed
|
|
},
|
|
}
|
|
|
|
handler := NewIssuerHandler(mock)
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/issuers/iss-local/test", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.TestConnection(w, req)
|
|
|
|
if w.Code != http.StatusInternalServerError {
|
|
t.Fatalf("expected status 500, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestTestConnection_EmptyID(t *testing.T) {
|
|
handler := NewIssuerHandler(&MockIssuerService{})
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/issuers//test", nil)
|
|
req = req.WithContext(contextWithRequestID())
|
|
w := httptest.NewRecorder()
|
|
|
|
handler.TestConnection(w, req)
|
|
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Fatalf("expected status 400, got %d", w.Code)
|
|
}
|
|
}
|