mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 15:01:32 +00:00
shankar0123
1caedd5fd3
Bundle: ci-pipeline-cleanup, Phase 1. Pure relocation — no behavior change. Each guard's bash logic is byte-identical to the prior inline version; the only changes are: (a) the guard becomes a sibling script under scripts/ci-guards/<id>.sh, (b) ci.yml's per-guard step is replaced by a single loop step that iterates all scripts. 20 scripts extracted (alphabetized): B-1-orphan-crud.sh, D-1-D-2-statusbadge-phantom.sh, G-1-jwt-auth-literal.sh, G-2-api-key-hash-json.sh, G-3-env-docs-drift.sh, H-001-bare-from.sh, H-009-readme-jwt.sh, L-001-insecure-skip-verify.sh, L-1-bulk-action-loop.sh, M-012-no-root-user.sh, P-1-documented-orphan-fns.sh, S-1-hardcoded-source-counts.sh, S-2-strings-contains-err.sh, T-1-frontend-page-coverage.sh, U-2-plaintext-healthcheck.sh, U-3-migration-mount.sh, bundle-8-L-015-target-blank-rel-noopener.sh, bundle-8-L-019-dangerously-set-inner-html.sh, bundle-8-M-009-bare-usemutation.sh, test-naming-convention.sh Plus scripts/ci-guards/README.md documenting the contract: - Each script must exit 0 on clean repo, non-zero with ::error:: prefix on regression - Runnable from repo root via 'bash scripts/ci-guards/<id>.sh' - Adding a new guard: drop a new <id>.sh; CI auto-picks it up ci.yml dropped 1488 → 557 lines (-931, -63%). Single CI loop step now collects ALL guard failures before failing the build instead of fail-fast — UX win for regressions that hit two guards at once. Two guards (QA-doc Part-count + seed-count, ci.yml lines 868-917) deliberately NOT extracted — they move to 'make verify-docs' in Phase 11 because they protect docs-the-operator-reads, not the product itself. Verification (sandbox): - All 20 scripts pass against HEAD (chmod +x; for g in scripts/ci-guards/*.sh; do bash $g; done) - New ci.yml YAML-parses cleanly - Job boundaries preserved: go-build-and-test, frontend-build, helm-lint, deploy-vendor-e2e, deploy-vendor-e2e-windows - Loop step appears twice (once at end of go-build-and-test, once at end of frontend-build) so both jobs continue running their set of guards
66 lines
2.4 KiB
Bash
Executable File
66 lines
2.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# scripts/ci-guards/G-1-jwt-auth-literal.sh
|
|
#
|
|
# G-1 closed the JWT silent auth downgrade by removing "jwt" from the
|
|
# accepted CERTCTL_AUTH_TYPE values. This script grep-fails the build
|
|
# if "jwt" reappears in any of the *additive* auth-type surfaces:
|
|
# the validAuthTypes / ValidAuthTypes() set, the OpenAPI enum, the
|
|
# helm chart's allowed-types list, or the .env.example default.
|
|
# Comment lines and the dedicated rejection branch in config.go
|
|
# (`c.Auth.Type == "jwt"`) are intentionally exempt — those are the
|
|
# G-1 fix itself, not a regression.
|
|
#
|
|
# Connector packages (internal/connector/) are exempt because the
|
|
# Google OAuth2 service-account JWT and step-ca provisioner one-
|
|
# time-token JWT are external-protocol uses, unrelated to certctl's
|
|
# own auth shape. Test files (_test.go) are exempt so negative
|
|
# tests can pass the literal.
|
|
#
|
|
# See docs/upgrade-to-v2-jwt-removal.md for the closure rationale,
|
|
# or internal/config/config.go::ValidAuthTypes for the allowed set.
|
|
|
|
set -e
|
|
|
|
# Scoped patterns that indicate "jwt" being added back to an
|
|
# allowed-set surface. Each catches a regression shape we've
|
|
# actually seen in pre-G-1 code:
|
|
# - Go map/slice literal: "jwt": true or "jwt",
|
|
# - Go switch case: case "jwt"
|
|
# - YAML enum: enum: [..., jwt, ...] or - jwt
|
|
# - .env conditional: AUTH_TYPE.*"jwt"|=jwt$
|
|
BAD=$(grep -rnEH \
|
|
-e '"jwt"\s*:\s*true' \
|
|
-e '"jwt"\s*,' \
|
|
-e 'case\s+"jwt"' \
|
|
-e 'enum:.*\bjwt\b' \
|
|
-e '^\s*-\s*jwt\s*$' \
|
|
-e 'AUTH_TYPE\s*=\s*jwt\s*$' \
|
|
-e 'AUTH_TYPE\s*=\s*jwt\s*#' \
|
|
-e 'auth\.type\s*=\s*jwt\s*$' \
|
|
-e 'AuthType\("jwt"\)' \
|
|
internal/config/ \
|
|
internal/api/ \
|
|
cmd/ \
|
|
api/openapi.yaml \
|
|
.env.example \
|
|
deploy/.env.example \
|
|
deploy/helm/certctl/values.yaml \
|
|
deploy/helm/certctl/templates/ \
|
|
2>/dev/null \
|
|
| grep -v '_test.go' \
|
|
| grep -vE '^\s*[^:]+:[0-9]+:\s*(//|#)' \
|
|
| grep -v 'is no longer accepted' \
|
|
|| true)
|
|
if [ -n "$BAD" ]; then
|
|
echo "::error::G-1 regression: \"jwt\" reappeared in an allowed-set surface:"
|
|
echo "$BAD"
|
|
echo ""
|
|
echo "Allowed surface for 'jwt' literals: comment lines, the"
|
|
echo "dedicated rejection branch in internal/config/config.go,"
|
|
echo "and connector packages (Google OAuth2, step-ca)."
|
|
echo "See docs/upgrade-to-v2-jwt-removal.md and"
|
|
echo "internal/config/config.go::ValidAuthTypes()."
|
|
exit 1
|
|
fi
|
|
echo "G-1 jwt-auth-literal: clean."
|