mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 15:11:29 +00:00
8b75e0311b
Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol
sub-module's go.mod, every Go file's import path (361 files), and a rebuild of
the checked-in f5-mock-icontrol binary so its embedded build-info reflects the
new module path. No behavior change.
Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A
(keep module path declared as github.com/shankar0123/certctl regardless of
repo URL) shipped on the day of the org transfer (2026-05-03) since we had no
external Go consumers; this commit closes that deferral.
Backward-compat: GitHub HTTP redirects continue to forward
github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL
level, but Go's module proxy uses the path declared in go.mod as the
canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...`
hit a "module path mismatch" error because go.mod said
github.com/shankar0123/certctl and the URL they fetched it from said
certctl-io/certctl. Post-fix, the canonical name and the URL agree, so
go get / go install / external Go consumers / Go-tooling integrations
work cleanly via either the new path (preferred) or the old path (which
redirects and Go follows the redirect for source fetch).
Anyone still importing the old path inside their own code keeps working
provided they update their go.mod's `require` line to match — the module
path declared in their consumer's go.sum / go.mod is the authoritative
import name, so a mass sed across their import statements is the migration
on the consumer side. No external consumers exist today.
Diff shape:
361 *.go files — import path replacement only
2 go.mod — module declaration replacement only
1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt
so embedded build-info reflects the new path (8618965 vs
8618933 bytes; 32-byte diff is the build-info change)
Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure
mechanical substitution.
Verification:
gofmt: 17 files needed re-alignment after sed (the new path is one char
shorter than the old, so column-aligned import groups drifted). Applied
`gofmt -w` to fix.
go mod tidy: clean exit on both modules.
go vet ./...: clean exit.
go build ./...: clean exit.
go test -short -count=1 on representative packages: all green
(internal/domain, internal/validation, internal/crypto, internal/crypto/signer,
cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...`
confirming the module path resolves correctly.
binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns
nothing; `strings | grep certctl-io/certctl` shows the new module path
embedded in build-info.
Files intentionally NOT touched in this commit:
README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io
URLs in commit 0729ee4 (the post-transfer URL refresh). This commit is
purely the Go-tooling layer.
Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account
namespace, not a Go import or GitHub repo URL. Stays.
This is a non-blocking, non-customer-impacting change. Operators pulling
container images, running `make verify`, hitting the API, or installing the
agent see no functional difference. Only Go-tooling consumers (none today)
are affected, and they're enabled — not broken — by this commit.
649 lines
18 KiB
Go
649 lines
18 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"math/big"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/certctl-io/certctl/internal/connector/issuer"
|
|
)
|
|
|
|
// mockConnectorLayerIssuer is a test implementation of issuer.Connector
|
|
type mockConnectorLayerIssuer struct {
|
|
issueResult *issuer.IssuanceResult
|
|
issueErr error
|
|
renewResult *issuer.IssuanceResult
|
|
renewErr error
|
|
lastIssueReq *issuer.IssuanceRequest
|
|
lastRenewReq *issuer.RenewalRequest
|
|
validateErr error
|
|
revokeErr error
|
|
orderStatusErr error
|
|
orderStatus *issuer.OrderStatus
|
|
renewalInfoResult *issuer.RenewalInfoResult
|
|
renewalInfoErr error
|
|
renewalInfoNil bool // flag to force nil result
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) ValidateConfig(ctx context.Context, config json.RawMessage) error {
|
|
return m.validateErr
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) IssueCertificate(ctx context.Context, request issuer.IssuanceRequest) (*issuer.IssuanceResult, error) {
|
|
m.lastIssueReq = &request
|
|
if m.issueErr != nil {
|
|
return nil, m.issueErr
|
|
}
|
|
if m.issueResult != nil {
|
|
return m.issueResult, nil
|
|
}
|
|
// Return default result
|
|
now := time.Now()
|
|
return &issuer.IssuanceResult{
|
|
CertPEM: "-----BEGIN CERTIFICATE-----\ndefault-cert\n-----END CERTIFICATE-----",
|
|
ChainPEM: "-----BEGIN CERTIFICATE-----\ndefault-chain\n-----END CERTIFICATE-----",
|
|
Serial: "default-serial-123",
|
|
NotBefore: now,
|
|
NotAfter: now.AddDate(1, 0, 0),
|
|
OrderID: "order-default",
|
|
}, nil
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) RenewCertificate(ctx context.Context, request issuer.RenewalRequest) (*issuer.IssuanceResult, error) {
|
|
m.lastRenewReq = &request
|
|
if m.renewErr != nil {
|
|
return nil, m.renewErr
|
|
}
|
|
if m.renewResult != nil {
|
|
return m.renewResult, nil
|
|
}
|
|
// Return default result
|
|
now := time.Now()
|
|
return &issuer.IssuanceResult{
|
|
CertPEM: "-----BEGIN CERTIFICATE-----\ndefault-renewed-cert\n-----END CERTIFICATE-----",
|
|
ChainPEM: "-----BEGIN CERTIFICATE-----\ndefault-renewed-chain\n-----END CERTIFICATE-----",
|
|
Serial: "default-renewed-serial-456",
|
|
NotBefore: now,
|
|
NotAfter: now.AddDate(1, 0, 0),
|
|
OrderID: "order-renewed",
|
|
}, nil
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) RevokeCertificate(ctx context.Context, request issuer.RevocationRequest) error {
|
|
return m.revokeErr
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) GetOrderStatus(ctx context.Context, orderID string) (*issuer.OrderStatus, error) {
|
|
if m.orderStatusErr != nil {
|
|
return nil, m.orderStatusErr
|
|
}
|
|
if m.orderStatus != nil {
|
|
return m.orderStatus, nil
|
|
}
|
|
status := "pending"
|
|
return &issuer.OrderStatus{
|
|
OrderID: orderID,
|
|
Status: status,
|
|
UpdatedAt: time.Now(),
|
|
}, nil
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) GenerateCRL(ctx context.Context, revokedCerts []issuer.RevokedCertEntry) ([]byte, error) {
|
|
return []byte("mock-crl-data"), nil
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) SignOCSPResponse(ctx context.Context, req issuer.OCSPSignRequest) ([]byte, error) {
|
|
return []byte("mock-ocsp-response"), nil
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) GetCACertPEM(ctx context.Context) (string, error) {
|
|
return "-----BEGIN CERTIFICATE-----\nmock-ca-cert\n-----END CERTIFICATE-----", nil
|
|
}
|
|
|
|
func (m *mockConnectorLayerIssuer) GetRenewalInfo(ctx context.Context, certPEM string) (*issuer.RenewalInfoResult, error) {
|
|
if m.renewalInfoErr != nil {
|
|
return nil, m.renewalInfoErr
|
|
}
|
|
if m.renewalInfoNil {
|
|
return nil, nil
|
|
}
|
|
if m.renewalInfoResult != nil {
|
|
return m.renewalInfoResult, nil
|
|
}
|
|
now := time.Now()
|
|
return &issuer.RenewalInfoResult{
|
|
SuggestedWindowStart: now,
|
|
SuggestedWindowEnd: now.Add(7 * 24 * time.Hour),
|
|
}, nil
|
|
}
|
|
|
|
// Tests for IssueCertificate
|
|
|
|
func TestIssuerConnectorAdapter_IssueCertificate_Success(t *testing.T) {
|
|
ctx := context.Background()
|
|
now := time.Now()
|
|
notAfter := now.AddDate(1, 0, 0)
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
issueResult: &issuer.IssuanceResult{
|
|
CertPEM: "-----BEGIN CERTIFICATE-----\ntest-cert\n-----END CERTIFICATE-----",
|
|
ChainPEM: "-----BEGIN CERTIFICATE-----\ntest-chain\n-----END CERTIFICATE-----",
|
|
Serial: "test-serial-001",
|
|
NotBefore: now,
|
|
NotAfter: notAfter,
|
|
OrderID: "order-123",
|
|
},
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
result, err := adapter.IssueCertificate(ctx, "example.com", []string{"www.example.com"}, "-----BEGIN CERTIFICATE REQUEST-----\nCSR\n-----END CERTIFICATE REQUEST-----", nil, 0, false)
|
|
|
|
if err != nil {
|
|
t.Fatalf("IssueCertificate failed: %v", err)
|
|
}
|
|
|
|
if result.Serial != "test-serial-001" {
|
|
t.Errorf("expected serial test-serial-001, got %s", result.Serial)
|
|
}
|
|
|
|
if result.CertPEM != "-----BEGIN CERTIFICATE-----\ntest-cert\n-----END CERTIFICATE-----" {
|
|
t.Errorf("expected CertPEM test-cert, got %s", result.CertPEM)
|
|
}
|
|
|
|
if result.ChainPEM != "-----BEGIN CERTIFICATE-----\ntest-chain\n-----END CERTIFICATE-----" {
|
|
t.Errorf("expected ChainPEM test-chain, got %s", result.ChainPEM)
|
|
}
|
|
|
|
if !result.NotBefore.Equal(now) {
|
|
t.Errorf("expected NotBefore %v, got %v", now, result.NotBefore)
|
|
}
|
|
|
|
if !result.NotAfter.Equal(notAfter) {
|
|
t.Errorf("expected NotAfter %v, got %v", notAfter, result.NotAfter)
|
|
}
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_IssueCertificate_Error(t *testing.T) {
|
|
ctx := context.Background()
|
|
testErr := errors.New("issuer connection failed")
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
issueErr: testErr,
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
result, err := adapter.IssueCertificate(ctx, "example.com", []string{}, "csr", nil, 0, false)
|
|
|
|
if err == nil {
|
|
t.Fatal("expected error, got nil")
|
|
}
|
|
|
|
if !errors.Is(err, testErr) {
|
|
t.Errorf("expected error %v, got %v", testErr, err)
|
|
}
|
|
|
|
if result != nil {
|
|
t.Errorf("expected nil result, got %v", result)
|
|
}
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_IssueCertificate_RequestTranslation(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
issueResult: &issuer.IssuanceResult{
|
|
CertPEM: "cert",
|
|
ChainPEM: "chain",
|
|
Serial: "serial",
|
|
NotBefore: time.Now(),
|
|
NotAfter: time.Now().AddDate(1, 0, 0),
|
|
},
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
commonName := "test.example.com"
|
|
sans := []string{"www.test.example.com", "api.test.example.com"}
|
|
csrPEM := "-----BEGIN CERTIFICATE REQUEST-----\nCSR\n-----END CERTIFICATE REQUEST-----"
|
|
|
|
_, err := adapter.IssueCertificate(ctx, commonName, sans, csrPEM, nil, 0, false)
|
|
|
|
if err != nil {
|
|
t.Fatalf("IssueCertificate failed: %v", err)
|
|
}
|
|
|
|
// Verify request was passed through correctly
|
|
if mock.lastIssueReq == nil {
|
|
t.Fatal("expected request to be recorded")
|
|
}
|
|
|
|
if mock.lastIssueReq.CommonName != commonName {
|
|
t.Errorf("expected CommonName %s, got %s", commonName, mock.lastIssueReq.CommonName)
|
|
}
|
|
|
|
if len(mock.lastIssueReq.SANs) != len(sans) {
|
|
t.Errorf("expected %d SANs, got %d", len(sans), len(mock.lastIssueReq.SANs))
|
|
}
|
|
|
|
for i, san := range sans {
|
|
if mock.lastIssueReq.SANs[i] != san {
|
|
t.Errorf("expected SAN[%d] %s, got %s", i, san, mock.lastIssueReq.SANs[i])
|
|
}
|
|
}
|
|
|
|
if mock.lastIssueReq.CSRPEM != csrPEM {
|
|
t.Errorf("expected CSRPEM %s, got %s", csrPEM, mock.lastIssueReq.CSRPEM)
|
|
}
|
|
}
|
|
|
|
// Tests for RenewCertificate
|
|
|
|
func TestIssuerConnectorAdapter_RenewCertificate_Success(t *testing.T) {
|
|
ctx := context.Background()
|
|
now := time.Now()
|
|
notAfter := now.AddDate(1, 0, 0)
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
renewResult: &issuer.IssuanceResult{
|
|
CertPEM: "-----BEGIN CERTIFICATE-----\nrenewed-cert\n-----END CERTIFICATE-----",
|
|
ChainPEM: "-----BEGIN CERTIFICATE-----\nrenewed-chain\n-----END CERTIFICATE-----",
|
|
Serial: "renewed-serial-002",
|
|
NotBefore: now,
|
|
NotAfter: notAfter,
|
|
OrderID: "order-456",
|
|
},
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
result, err := adapter.RenewCertificate(ctx, "example.com", []string{"www.example.com"}, "-----BEGIN CERTIFICATE REQUEST-----\nCSR\n-----END CERTIFICATE REQUEST-----", nil, 0, false)
|
|
|
|
if err != nil {
|
|
t.Fatalf("RenewCertificate failed: %v", err)
|
|
}
|
|
|
|
if result.Serial != "renewed-serial-002" {
|
|
t.Errorf("expected serial renewed-serial-002, got %s", result.Serial)
|
|
}
|
|
|
|
if result.CertPEM != "-----BEGIN CERTIFICATE-----\nrenewed-cert\n-----END CERTIFICATE-----" {
|
|
t.Errorf("expected CertPEM renewed-cert, got %s", result.CertPEM)
|
|
}
|
|
|
|
if result.ChainPEM != "-----BEGIN CERTIFICATE-----\nrenewed-chain\n-----END CERTIFICATE-----" {
|
|
t.Errorf("expected ChainPEM renewed-chain, got %s", result.ChainPEM)
|
|
}
|
|
|
|
if !result.NotBefore.Equal(now) {
|
|
t.Errorf("expected NotBefore %v, got %v", now, result.NotBefore)
|
|
}
|
|
|
|
if !result.NotAfter.Equal(notAfter) {
|
|
t.Errorf("expected NotAfter %v, got %v", notAfter, result.NotAfter)
|
|
}
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_RenewCertificate_Error(t *testing.T) {
|
|
ctx := context.Background()
|
|
testErr := errors.New("renewal failed")
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
renewErr: testErr,
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
result, err := adapter.RenewCertificate(ctx, "example.com", []string{}, "csr", nil, 0, false)
|
|
|
|
if err == nil {
|
|
t.Fatal("expected error, got nil")
|
|
}
|
|
|
|
if !errors.Is(err, testErr) {
|
|
t.Errorf("expected error %v, got %v", testErr, err)
|
|
}
|
|
|
|
if result != nil {
|
|
t.Errorf("expected nil result, got %v", result)
|
|
}
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_RenewCertificate_RequestTranslation(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
renewResult: &issuer.IssuanceResult{
|
|
CertPEM: "cert",
|
|
ChainPEM: "chain",
|
|
Serial: "serial",
|
|
NotBefore: time.Now(),
|
|
NotAfter: time.Now().AddDate(1, 0, 0),
|
|
},
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
commonName := "renew.example.com"
|
|
sans := []string{"www.renew.example.com"}
|
|
csrPEM := "-----BEGIN CERTIFICATE REQUEST-----\nRENEW-CSR\n-----END CERTIFICATE REQUEST-----"
|
|
|
|
_, err := adapter.RenewCertificate(ctx, commonName, sans, csrPEM, nil, 0, false)
|
|
|
|
if err != nil {
|
|
t.Fatalf("RenewCertificate failed: %v", err)
|
|
}
|
|
|
|
// Verify request was passed through correctly
|
|
if mock.lastRenewReq == nil {
|
|
t.Fatal("expected request to be recorded")
|
|
}
|
|
|
|
if mock.lastRenewReq.CommonName != commonName {
|
|
t.Errorf("expected CommonName %s, got %s", commonName, mock.lastRenewReq.CommonName)
|
|
}
|
|
|
|
if len(mock.lastRenewReq.SANs) != len(sans) {
|
|
t.Errorf("expected %d SANs, got %d", len(sans), len(mock.lastRenewReq.SANs))
|
|
}
|
|
|
|
for i, san := range sans {
|
|
if mock.lastRenewReq.SANs[i] != san {
|
|
t.Errorf("expected SAN[%d] %s, got %s", i, san, mock.lastRenewReq.SANs[i])
|
|
}
|
|
}
|
|
|
|
if mock.lastRenewReq.CSRPEM != csrPEM {
|
|
t.Errorf("expected CSRPEM %s, got %s", csrPEM, mock.lastRenewReq.CSRPEM)
|
|
}
|
|
}
|
|
|
|
// Tests for RevokeCertificate
|
|
|
|
func TestIssuerConnectorAdapter_RevokeCertificate_Success(t *testing.T) {
|
|
ctx := context.Background()
|
|
mock := &mockConnectorLayerIssuer{}
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
err := adapter.RevokeCertificate(ctx, "serial-123", "keyCompromise")
|
|
if err != nil {
|
|
t.Fatalf("RevokeCertificate failed: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_RevokeCertificate_Error(t *testing.T) {
|
|
ctx := context.Background()
|
|
testErr := errors.New("revocation failed at issuer")
|
|
mock := &mockConnectorLayerIssuer{revokeErr: testErr}
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
err := adapter.RevokeCertificate(ctx, "serial-123", "keyCompromise")
|
|
if err == nil {
|
|
t.Fatal("expected error, got nil")
|
|
}
|
|
if !errors.Is(err, testErr) {
|
|
t.Errorf("expected error %v, got %v", testErr, err)
|
|
}
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_RevokeCertificate_EmptyReason(t *testing.T) {
|
|
ctx := context.Background()
|
|
mock := &mockConnectorLayerIssuer{}
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
// Empty reason should pass nil to the connector
|
|
err := adapter.RevokeCertificate(ctx, "serial-456", "")
|
|
if err != nil {
|
|
t.Fatalf("RevokeCertificate with empty reason failed: %v", err)
|
|
}
|
|
}
|
|
|
|
// M15b: CRL and OCSP Adapter Tests
|
|
|
|
func TestIssuerConnectorAdapter_GenerateCRL_Success(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
// Mock returns a valid DER CRL when GenerateCRL is called
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
// Call GenerateCRL on adapter
|
|
crl, err := adapter.GenerateCRL(ctx, nil)
|
|
|
|
if err != nil {
|
|
t.Fatalf("GenerateCRL failed: %v", err)
|
|
}
|
|
|
|
if crl == nil {
|
|
t.Fatal("expected non-nil CRL, got nil")
|
|
}
|
|
|
|
// Verify we got the mock CRL bytes
|
|
if string(crl) != "mock-crl-data" {
|
|
t.Errorf("expected mock-crl-data, got %s", string(crl))
|
|
}
|
|
|
|
t.Log("CRL generation delegated to connector successfully")
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_GenerateCRL_WithEntries(t *testing.T) {
|
|
ctx := context.Background()
|
|
mock := &mockConnectorLayerIssuer{}
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
// Create test entries
|
|
entries := []CRLEntry{
|
|
{SerialNumber: big.NewInt(111), RevokedAt: time.Now(), ReasonCode: 1},
|
|
{SerialNumber: big.NewInt(222), RevokedAt: time.Now(), ReasonCode: 4},
|
|
}
|
|
|
|
crl, err := adapter.GenerateCRL(ctx, entries)
|
|
|
|
if err != nil {
|
|
t.Fatalf("GenerateCRL with entries failed: %v", err)
|
|
}
|
|
|
|
if crl == nil {
|
|
t.Fatal("expected non-nil CRL")
|
|
}
|
|
|
|
if len(crl) == 0 {
|
|
t.Fatal("expected non-empty CRL")
|
|
}
|
|
|
|
t.Logf("CRL with %d entries generated via adapter", len(entries))
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_SignOCSPResponse_Good(t *testing.T) {
|
|
ctx := context.Background()
|
|
mock := &mockConnectorLayerIssuer{}
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
now := time.Now()
|
|
req := OCSPSignRequest{
|
|
CertSerial: big.NewInt(12345),
|
|
CertStatus: 0, // good
|
|
ThisUpdate: now,
|
|
NextUpdate: now.Add(1 * time.Hour),
|
|
}
|
|
|
|
resp, err := adapter.SignOCSPResponse(ctx, req)
|
|
|
|
if err != nil {
|
|
t.Fatalf("SignOCSPResponse failed: %v", err)
|
|
}
|
|
|
|
if resp == nil {
|
|
t.Fatal("expected non-nil OCSP response")
|
|
}
|
|
|
|
if len(resp) == 0 {
|
|
t.Fatal("expected non-empty OCSP response")
|
|
}
|
|
|
|
if string(resp) != "mock-ocsp-response" {
|
|
t.Errorf("expected mock-ocsp-response, got %s", string(resp))
|
|
}
|
|
|
|
t.Log("OCSP response for good cert signed via adapter")
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_SignOCSPResponse_Revoked(t *testing.T) {
|
|
ctx := context.Background()
|
|
mock := &mockConnectorLayerIssuer{}
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
now := time.Now()
|
|
req := OCSPSignRequest{
|
|
CertSerial: big.NewInt(67890),
|
|
CertStatus: 1, // revoked
|
|
RevokedAt: now.Add(-24 * time.Hour),
|
|
RevocationReason: 1, // keyCompromise
|
|
ThisUpdate: now,
|
|
NextUpdate: now.Add(1 * time.Hour),
|
|
}
|
|
|
|
resp, err := adapter.SignOCSPResponse(ctx, req)
|
|
|
|
if err != nil {
|
|
t.Fatalf("SignOCSPResponse for revoked cert failed: %v", err)
|
|
}
|
|
|
|
if resp == nil || len(resp) == 0 {
|
|
t.Fatal("expected non-empty OCSP response for revoked cert")
|
|
}
|
|
|
|
t.Log("OCSP response for revoked cert signed via adapter")
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_SignOCSPResponse_Unknown(t *testing.T) {
|
|
ctx := context.Background()
|
|
mock := &mockConnectorLayerIssuer{}
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
now := time.Now()
|
|
req := OCSPSignRequest{
|
|
CertSerial: big.NewInt(99999),
|
|
CertStatus: 2, // unknown
|
|
ThisUpdate: now,
|
|
NextUpdate: now.Add(1 * time.Hour),
|
|
}
|
|
|
|
resp, err := adapter.SignOCSPResponse(ctx, req)
|
|
|
|
if err != nil {
|
|
t.Fatalf("SignOCSPResponse for unknown cert failed: %v", err)
|
|
}
|
|
|
|
if resp == nil || len(resp) == 0 {
|
|
t.Fatal("expected non-empty OCSP response for unknown cert")
|
|
}
|
|
|
|
t.Log("OCSP response for unknown cert signed via adapter")
|
|
}
|
|
|
|
// Tests for GetRenewalInfo
|
|
|
|
func TestIssuerConnectorAdapter_GetRenewalInfo_Success(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
mock := &mockConnectorLayerIssuer{}
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
testCertPEM := "-----BEGIN CERTIFICATE-----\ntest-cert\n-----END CERTIFICATE-----"
|
|
|
|
result, err := adapter.GetRenewalInfo(ctx, testCertPEM)
|
|
|
|
if err != nil {
|
|
t.Fatalf("GetRenewalInfo failed: %v", err)
|
|
}
|
|
|
|
if result == nil {
|
|
t.Fatal("expected non-nil result")
|
|
}
|
|
|
|
if result.SuggestedWindowStart.IsZero() {
|
|
t.Error("SuggestedWindowStart should not be zero")
|
|
}
|
|
|
|
if result.SuggestedWindowEnd.IsZero() {
|
|
t.Error("SuggestedWindowEnd should not be zero")
|
|
}
|
|
|
|
if result.SuggestedWindowEnd.Before(result.SuggestedWindowStart) {
|
|
t.Error("SuggestedWindowEnd should be after SuggestedWindowStart")
|
|
}
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_GetRenewalInfo_Nil(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
renewalInfoNil: true,
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
result, err := adapter.GetRenewalInfo(ctx, "test-cert-pem")
|
|
|
|
if err != nil {
|
|
t.Fatalf("GetRenewalInfo failed: %v", err)
|
|
}
|
|
|
|
if result != nil {
|
|
t.Error("expected nil result when underlying connector returns nil")
|
|
}
|
|
}
|
|
|
|
func TestIssuerConnectorAdapter_GetRenewalInfo_ResultTranslation(t *testing.T) {
|
|
ctx := context.Background()
|
|
now := time.Now()
|
|
windowStart := now
|
|
windowEnd := now.Add(24 * time.Hour)
|
|
retryAfter := now.Add(1 * time.Hour)
|
|
explanationURL := "https://example.com/renewal-info"
|
|
|
|
mock := &mockConnectorLayerIssuer{
|
|
renewalInfoResult: &issuer.RenewalInfoResult{
|
|
SuggestedWindowStart: windowStart,
|
|
SuggestedWindowEnd: windowEnd,
|
|
RetryAfter: retryAfter,
|
|
ExplanationURL: explanationURL,
|
|
},
|
|
}
|
|
|
|
adapter := NewIssuerConnectorAdapter(mock)
|
|
|
|
result, err := adapter.GetRenewalInfo(ctx, "test-cert-pem")
|
|
|
|
if err != nil {
|
|
t.Fatalf("GetRenewalInfo failed: %v", err)
|
|
}
|
|
|
|
if result == nil {
|
|
t.Fatal("expected non-nil result")
|
|
}
|
|
|
|
if !result.SuggestedWindowStart.Equal(windowStart) {
|
|
t.Errorf("expected SuggestedWindowStart %v, got %v", windowStart, result.SuggestedWindowStart)
|
|
}
|
|
|
|
if !result.SuggestedWindowEnd.Equal(windowEnd) {
|
|
t.Errorf("expected SuggestedWindowEnd %v, got %v", windowEnd, result.SuggestedWindowEnd)
|
|
}
|
|
|
|
if !result.RetryAfter.Equal(retryAfter) {
|
|
t.Errorf("expected RetryAfter %v, got %v", retryAfter, result.RetryAfter)
|
|
}
|
|
|
|
if result.ExplanationURL != explanationURL {
|
|
t.Errorf("expected ExplanationURL %s, got %s", explanationURL, result.ExplanationURL)
|
|
}
|
|
}
|