mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 12:31:29 +00:00
shankar0123
1caedd5fd3
Bundle: ci-pipeline-cleanup, Phase 1. Pure relocation — no behavior change. Each guard's bash logic is byte-identical to the prior inline version; the only changes are: (a) the guard becomes a sibling script under scripts/ci-guards/<id>.sh, (b) ci.yml's per-guard step is replaced by a single loop step that iterates all scripts. 20 scripts extracted (alphabetized): B-1-orphan-crud.sh, D-1-D-2-statusbadge-phantom.sh, G-1-jwt-auth-literal.sh, G-2-api-key-hash-json.sh, G-3-env-docs-drift.sh, H-001-bare-from.sh, H-009-readme-jwt.sh, L-001-insecure-skip-verify.sh, L-1-bulk-action-loop.sh, M-012-no-root-user.sh, P-1-documented-orphan-fns.sh, S-1-hardcoded-source-counts.sh, S-2-strings-contains-err.sh, T-1-frontend-page-coverage.sh, U-2-plaintext-healthcheck.sh, U-3-migration-mount.sh, bundle-8-L-015-target-blank-rel-noopener.sh, bundle-8-L-019-dangerously-set-inner-html.sh, bundle-8-M-009-bare-usemutation.sh, test-naming-convention.sh Plus scripts/ci-guards/README.md documenting the contract: - Each script must exit 0 on clean repo, non-zero with ::error:: prefix on regression - Runnable from repo root via 'bash scripts/ci-guards/<id>.sh' - Adding a new guard: drop a new <id>.sh; CI auto-picks it up ci.yml dropped 1488 → 557 lines (-931, -63%). Single CI loop step now collects ALL guard failures before failing the build instead of fail-fast — UX win for regressions that hit two guards at once. Two guards (QA-doc Part-count + seed-count, ci.yml lines 868-917) deliberately NOT extracted — they move to 'make verify-docs' in Phase 11 because they protect docs-the-operator-reads, not the product itself. Verification (sandbox): - All 20 scripts pass against HEAD (chmod +x; for g in scripts/ci-guards/*.sh; do bash $g; done) - New ci.yml YAML-parses cleanly - Job boundaries preserved: go-build-and-test, frontend-build, helm-lint, deploy-vendor-e2e, deploy-vendor-e2e-windows - Loop step appears twice (once at end of go-build-and-test, once at end of frontend-build) so both jobs continue running their set of guards
54 lines
2.5 KiB
Bash
Executable File
54 lines
2.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# scripts/ci-guards/B-1-orphan-crud.sh
|
|
#
|
|
# B-1 master closed four audit findings — three orphan-update fns
|
|
# (cat-b-31ceb6aaa9f1, cat-b-7a34f893a8f9) and one orphan CRUD
|
|
# surface (cat-b-4631ca092bee, RenewalPolicy) — by wiring per-page
|
|
# Edit modals so every backend write endpoint has at least one
|
|
# GUI consumer. The fourth finding (cat-b-9b97ffb35ef7) deleted
|
|
# the dead `exportCertificatePEM` duplicate.
|
|
#
|
|
# Pre-B-1 the failure mode was: backend ships a CRUD handler,
|
|
# client.ts ships the matching `update*` / `delete*` / `create*`
|
|
# function, but no page imports it. Operators were forced to
|
|
# `psql` directly to edit team names, owner emails, agent-group
|
|
# match rules, issuer names, profile names, or any renewal-policy
|
|
# field — turning a 30-second GUI task into a 30-minute database
|
|
# excursion with audit-trail gaps.
|
|
#
|
|
# This script fails the build if any of the eight previously-orphan
|
|
# client functions loses its page consumer (i.e. a future refactor
|
|
# accidentally re-orphans them). Each fn must have ≥1 non-test
|
|
# consumer under web/src/pages/. Tests (*.test.ts(x)) and the
|
|
# client.ts definition file itself are exempt.
|
|
#
|
|
# See coverage-gap-audit-2026-04-24-v5/unified-audit.md
|
|
# cat-b-31ceb6aaa9f1, cat-b-7a34f893a8f9, cat-b-4631ca092bee,
|
|
# cat-b-9b97ffb35ef7 for closure rationale.
|
|
|
|
set -e
|
|
ORPHAN_FNS="updateOwner updateTeam updateAgentGroup updateIssuer updateProfile createRenewalPolicy updateRenewalPolicy deleteRenewalPolicy"
|
|
FAIL=0
|
|
for fn in $ORPHAN_FNS; do
|
|
HITS=$(grep -rE "\b${fn}\b" web/src/pages/ 2>/dev/null \
|
|
| grep -vE '\.test\.(ts|tsx):' \
|
|
| wc -l)
|
|
if [ "$HITS" -eq 0 ]; then
|
|
echo "::error::B-1 regression: client function '${fn}' has zero consumers under web/src/pages/."
|
|
echo " Every backend CRUD endpoint must have a GUI consumer to avoid forcing operators to psql."
|
|
echo " Either restore the page consumer or delete the client function in the same commit."
|
|
FAIL=1
|
|
fi
|
|
done
|
|
# cat-b-9b97ffb35ef7: exportCertificatePEM was deleted as a dead
|
|
# duplicate of downloadCertificatePEM. Block resurrection.
|
|
if grep -nE 'export\s+const\s+exportCertificatePEM' web/src/api/client.ts >/dev/null 2>&1; then
|
|
echo "::error::B-1 regression: exportCertificatePEM was removed as a dead duplicate of downloadCertificatePEM."
|
|
echo " If a JSON variant is needed, add an explicit page consumer in the same commit."
|
|
FAIL=1
|
|
fi
|
|
if [ "$FAIL" -ne 0 ]; then
|
|
exit 1
|
|
fi
|
|
echo "B-1 orphan-CRUD: clean (all 8 functions have page consumers)."
|