Files
shankar0123 a485e31f63 fix(repo,service): SCALE-002 — push pagination into SQL for target/issuer/team/agent_group
Sprint 2 unified-master-audit closure. Pre-fix four service List
endpoints (target, issuer, team, agent_group) called repoFoo.List(ctx)
to fetch the full table then sliced in memory:

    rows, _ := s.repo.List(ctx)
    total := int64(len(rows))
    start := (page - 1) * perPage
    end := start + perPage
    return rows[start:end], total, nil

This page-sliced in memory pattern marshals every row per request —
fine on small fleets but unacceptable for multi-tenant or large-fleet
deploys. The agent_group case was worse — the service explicitly
ignored page/perPage and returned the entire slice.

Fix:
  - New ListPaginated(ctx, limit, offset) method on each of the four
    repositories. Postgres implementations push LIMIT + OFFSET into
    the SQL plus a SELECT COUNT(*) for the total. Mirrors the cursor
    pattern already in internal/repository/postgres/certificate.go.
  - Each ListPaginated normalises limit≤0→50 and offset<0→0,
    matching the service-layer defaults that already existed.
  - Repository interfaces grow the new method so adapters stay
    swappable.
  - Service List methods now call repoFoo.ListPaginated(ctx, perPage,
    (page-1)*perPage) directly — no more memory-slice.
  - AgentGroupService.ListAgentGroups closes the Bundle E / Audit
    L-020 'page/perPage unused' gap.

Test changes:
  - sliceWindow generic helper in testutil_test.go mirrors the SQL
    LIMIT/OFFSET semantics for in-memory mocks.
  - Six mock implementers (lifecycle_test, testutil_test x2,
    agent_group_test, team_test) gain ListPaginated methods.
  - TestTeamService_List_SCALE002_PaginationPropagatesToRepo pins
    the page=2, perPage=3 → 3 rows of 10 invariant.

Closes SCALE-002.
2026-05-16 04:01:45 +00:00

243 lines
7.0 KiB
Go

// Copyright 2026 certctl LLC. All rights reserved.
// SPDX-License-Identifier: BUSL-1.1
package postgres
import (
"context"
"database/sql"
"fmt"
"github.com/certctl-io/certctl/internal/repository"
"github.com/certctl-io/certctl/internal/domain"
"github.com/google/uuid"
)
// IssuerRepository implements repository.IssuerRepository
type IssuerRepository struct {
db *sql.DB
}
// NewIssuerRepository creates a new IssuerRepository
func NewIssuerRepository(db *sql.DB) *IssuerRepository {
return &IssuerRepository{db: db}
}
// List returns all issuers
func (r *IssuerRepository) List(ctx context.Context) ([]*domain.Issuer, error) {
rows, err := r.db.QueryContext(ctx, `
SELECT id, name, type, config, COALESCE(encrypted_config, NULL), enabled,
last_tested_at, COALESCE(test_status, 'untested'), COALESCE(source, 'database'),
created_at, updated_at
FROM issuers
ORDER BY created_at DESC
`)
if err != nil {
return nil, fmt.Errorf("failed to query issuers: %w", err)
}
defer rows.Close()
var issuers []*domain.Issuer
for rows.Next() {
var issuer domain.Issuer
if err := rows.Scan(&issuer.ID, &issuer.Name, &issuer.Type, &issuer.Config,
&issuer.EncryptedConfig, &issuer.Enabled,
&issuer.LastTestedAt, &issuer.TestStatus, &issuer.Source,
&issuer.CreatedAt, &issuer.UpdatedAt); err != nil {
return nil, fmt.Errorf("failed to scan issuer: %w", err)
}
issuers = append(issuers, &issuer)
}
if err := rows.Err(); err != nil {
return nil, fmt.Errorf("error iterating issuer rows: %w", err)
}
return issuers, nil
}
// ListPaginated returns a slice of issuers bounded by limit/offset plus the
// total count. SCALE-002 closure (Sprint 2, 2026-05-16).
func (r *IssuerRepository) ListPaginated(ctx context.Context, limit, offset int) ([]*domain.Issuer, int64, error) {
if limit <= 0 {
limit = 50
}
if offset < 0 {
offset = 0
}
var total int64
if err := r.db.QueryRowContext(ctx, `SELECT COUNT(*) FROM issuers`).Scan(&total); err != nil {
return nil, 0, fmt.Errorf("failed to count issuers: %w", err)
}
rows, err := r.db.QueryContext(ctx, `
SELECT id, name, type, config, COALESCE(encrypted_config, NULL), enabled,
last_tested_at, COALESCE(test_status, 'untested'), COALESCE(source, 'database'),
created_at, updated_at
FROM issuers
ORDER BY created_at DESC
LIMIT $1 OFFSET $2
`, limit, offset)
if err != nil {
return nil, 0, fmt.Errorf("failed to query issuers: %w", err)
}
defer rows.Close()
var issuers []*domain.Issuer
for rows.Next() {
var iss domain.Issuer
if err := rows.Scan(&iss.ID, &iss.Name, &iss.Type, &iss.Config,
&iss.EncryptedConfig, &iss.Enabled,
&iss.LastTestedAt, &iss.TestStatus, &iss.Source,
&iss.CreatedAt, &iss.UpdatedAt); err != nil {
return nil, 0, fmt.Errorf("failed to scan issuer: %w", err)
}
issuers = append(issuers, &iss)
}
if err := rows.Err(); err != nil {
return nil, 0, fmt.Errorf("error iterating issuer rows: %w", err)
}
return issuers, total, nil
}
// Get retrieves an issuer by ID
func (r *IssuerRepository) Get(ctx context.Context, id string) (*domain.Issuer, error) {
var issuer domain.Issuer
err := r.db.QueryRowContext(ctx, `
SELECT id, name, type, config, COALESCE(encrypted_config, NULL), enabled,
last_tested_at, COALESCE(test_status, 'untested'), COALESCE(source, 'database'),
created_at, updated_at
FROM issuers
WHERE id = $1
`, id).Scan(&issuer.ID, &issuer.Name, &issuer.Type, &issuer.Config,
&issuer.EncryptedConfig, &issuer.Enabled,
&issuer.LastTestedAt, &issuer.TestStatus, &issuer.Source,
&issuer.CreatedAt, &issuer.UpdatedAt)
if err != nil {
if err == sql.ErrNoRows {
return nil, fmt.Errorf("issuer not found: %w", repository.ErrNotFound)
}
return nil, fmt.Errorf("failed to query issuer: %w", err)
}
return &issuer, nil
}
// Create stores a new issuer
func (r *IssuerRepository) Create(ctx context.Context, issuer *domain.Issuer) error {
if issuer.ID == "" {
issuer.ID = uuid.New().String()
}
source := issuer.Source
if source == "" {
source = "database"
}
testStatus := issuer.TestStatus
if testStatus == "" {
testStatus = "untested"
}
err := r.db.QueryRowContext(ctx, `
INSERT INTO issuers (id, name, type, config, encrypted_config, enabled,
last_tested_at, test_status, source, created_at, updated_at)
VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11)
RETURNING id
`, issuer.ID, issuer.Name, issuer.Type, issuer.Config, issuer.EncryptedConfig,
issuer.Enabled, issuer.LastTestedAt, testStatus, source,
issuer.CreatedAt, issuer.UpdatedAt).Scan(&issuer.ID)
if err != nil {
return fmt.Errorf("failed to create issuer: %w", err)
}
return nil
}
// CreateIfNotExists creates an issuer only if the ID doesn't already exist.
// Used for env var seeding on first boot. Returns true if created, false if already existed.
func (r *IssuerRepository) CreateIfNotExists(ctx context.Context, issuer *domain.Issuer) (bool, error) {
source := issuer.Source
if source == "" {
source = "env"
}
testStatus := issuer.TestStatus
if testStatus == "" {
testStatus = "untested"
}
var id string
err := r.db.QueryRowContext(ctx, `
INSERT INTO issuers (id, name, type, config, encrypted_config, enabled,
last_tested_at, test_status, source, created_at, updated_at)
VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11)
ON CONFLICT (id) DO NOTHING
RETURNING id
`, issuer.ID, issuer.Name, issuer.Type, issuer.Config, issuer.EncryptedConfig,
issuer.Enabled, issuer.LastTestedAt, testStatus, source,
issuer.CreatedAt, issuer.UpdatedAt).Scan(&id)
if err != nil {
if err == sql.ErrNoRows {
// ON CONFLICT DO NOTHING — row already existed
return false, nil
}
return false, fmt.Errorf("failed to create issuer: %w", err)
}
return true, nil
}
// Update modifies an existing issuer
func (r *IssuerRepository) Update(ctx context.Context, issuer *domain.Issuer) error {
result, err := r.db.ExecContext(ctx, `
UPDATE issuers SET
name = $1,
type = $2,
config = $3,
encrypted_config = $4,
enabled = $5,
last_tested_at = $6,
test_status = $7,
updated_at = $8
WHERE id = $9
`, issuer.Name, issuer.Type, issuer.Config, issuer.EncryptedConfig,
issuer.Enabled, issuer.LastTestedAt, issuer.TestStatus,
issuer.UpdatedAt, issuer.ID)
if err != nil {
return fmt.Errorf("failed to update issuer: %w", err)
}
rows, err := result.RowsAffected()
if err != nil {
return fmt.Errorf("failed to get rows affected: %w", err)
}
if rows == 0 {
return fmt.Errorf("issuer not found: %w", repository.ErrNotFound)
}
return nil
}
// Delete removes an issuer
func (r *IssuerRepository) Delete(ctx context.Context, id string) error {
result, err := r.db.ExecContext(ctx, "DELETE FROM issuers WHERE id = $1", id)
if err != nil {
return fmt.Errorf("failed to delete issuer: %w", err)
}
rows, err := result.RowsAffected()
if err != nil {
return fmt.Errorf("failed to get rows affected: %w", err)
}
if rows == 0 {
return fmt.Errorf("issuer not found: %w", repository.ErrNotFound)
}
return nil
}