mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-08 19:38:51 +00:00
shankar0123
8b75e0311b
Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol
sub-module's go.mod, every Go file's import path (361 files), and a rebuild of
the checked-in f5-mock-icontrol binary so its embedded build-info reflects the
new module path. No behavior change.
Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A
(keep module path declared as github.com/shankar0123/certctl regardless of
repo URL) shipped on the day of the org transfer (2026-05-03) since we had no
external Go consumers; this commit closes that deferral.
Backward-compat: GitHub HTTP redirects continue to forward
github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL
level, but Go's module proxy uses the path declared in go.mod as the
canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...`
hit a "module path mismatch" error because go.mod said
github.com/shankar0123/certctl and the URL they fetched it from said
certctl-io/certctl. Post-fix, the canonical name and the URL agree, so
go get / go install / external Go consumers / Go-tooling integrations
work cleanly via either the new path (preferred) or the old path (which
redirects and Go follows the redirect for source fetch).
Anyone still importing the old path inside their own code keeps working
provided they update their go.mod's `require` line to match — the module
path declared in their consumer's go.sum / go.mod is the authoritative
import name, so a mass sed across their import statements is the migration
on the consumer side. No external consumers exist today.
Diff shape:
361 *.go files — import path replacement only
2 go.mod — module declaration replacement only
1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt
so embedded build-info reflects the new path (8618965 vs
8618933 bytes; 32-byte diff is the build-info change)
Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure
mechanical substitution.
Verification:
gofmt: 17 files needed re-alignment after sed (the new path is one char
shorter than the old, so column-aligned import groups drifted). Applied
`gofmt -w` to fix.
go mod tidy: clean exit on both modules.
go vet ./...: clean exit.
go build ./...: clean exit.
go test -short -count=1 on representative packages: all green
(internal/domain, internal/validation, internal/crypto, internal/crypto/signer,
cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...`
confirming the module path resolves correctly.
binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns
nothing; `strings | grep certctl-io/certctl` shows the new module path
embedded in build-info.
Files intentionally NOT touched in this commit:
README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io
URLs in commit 0729ee4 (the post-transfer URL refresh). This commit is
purely the Go-tooling layer.
Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account
namespace, not a Go import or GitHub repo URL. Stays.
This is a non-blocking, non-customer-impacting change. Operators pulling
container images, running `make verify`, hitting the API, or installing the
agent see no functional difference. Only Go-tooling consumers (none today)
are affected, and they're enabled — not broken — by this commit.
97 lines
3.1 KiB
Go
97 lines
3.1 KiB
Go
package iis
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"log/slog"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/certctl-io/certctl/internal/connector/target"
|
|
)
|
|
|
|
// Phase 8 of the deploy-hardening I master bundle: IIS ValidateOnly
|
|
// real implementation tests. IIS already has explicit pre-deploy
|
|
// backup + post-rollback re-import semantics; the new bit is the
|
|
// PowerShell health probe via Get-WebSite.
|
|
|
|
type stubExecutor struct {
|
|
out string
|
|
err error
|
|
}
|
|
|
|
func (s *stubExecutor) Execute(_ context.Context, _ string) (string, error) {
|
|
return s.out, s.err
|
|
}
|
|
|
|
func quietLogger() *slog.Logger {
|
|
return slog.New(slog.NewTextHandler(os.NewFile(0, os.DevNull), &slog.HandlerOptions{Level: slog.LevelError}))
|
|
}
|
|
|
|
func TestIIS_ValidateOnly_GetWebSite_Succeeds(t *testing.T) {
|
|
c := NewWithExecutor(&Config{SiteName: "Default Web Site"}, quietLogger(), &stubExecutor{out: "Default Web Site"})
|
|
if err := c.ValidateOnly(context.Background(), target.DeploymentRequest{}); err != nil {
|
|
t.Errorf("got %v, want nil", err)
|
|
}
|
|
}
|
|
|
|
func TestIIS_ValidateOnly_GetWebSite_Fails(t *testing.T) {
|
|
c := NewWithExecutor(&Config{SiteName: "Missing"}, quietLogger(), &stubExecutor{
|
|
out: "Get-WebSite : Cannot find a Web site with name 'Missing'",
|
|
err: errors.New("PowerShell exit 1"),
|
|
})
|
|
err := c.ValidateOnly(context.Background(), target.DeploymentRequest{})
|
|
if err == nil {
|
|
t.Fatal("expected error")
|
|
}
|
|
if errors.Is(err, target.ErrValidateOnlyNotSupported) {
|
|
t.Errorf("got sentinel, want wrapped error: %v", err)
|
|
}
|
|
if !strings.Contains(err.Error(), "Cannot find") {
|
|
t.Errorf("error missing PowerShell stderr: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestIIS_ValidateOnly_NilExecutor_ReturnsSentinel(t *testing.T) {
|
|
c := &Connector{config: &Config{SiteName: "x"}, logger: quietLogger()}
|
|
if err := c.ValidateOnly(context.Background(), target.DeploymentRequest{}); !errors.Is(err, target.ErrValidateOnlyNotSupported) {
|
|
t.Errorf("got %v, want sentinel", err)
|
|
}
|
|
}
|
|
|
|
func TestIIS_ValidateOnly_SiteNameQuoted(t *testing.T) {
|
|
// Verify the script PROPERLY quotes site names with spaces (a common
|
|
// IIS site name pattern).
|
|
captured := ""
|
|
exec := &stubExecutor{out: "Default Web Site"}
|
|
c := NewWithExecutor(&Config{SiteName: "Default Web Site"}, quietLogger(), exec)
|
|
// Wrap exec to capture script.
|
|
c.executor = captureExec{wrapped: exec, captured: &captured}
|
|
c.ValidateOnly(context.Background(), target.DeploymentRequest{})
|
|
if !strings.Contains(captured, `"Default Web Site"`) {
|
|
t.Errorf("script missing quoted site name: %q", captured)
|
|
}
|
|
}
|
|
|
|
type captureExec struct {
|
|
wrapped PowerShellExecutor
|
|
captured *string
|
|
}
|
|
|
|
func (c captureExec) Execute(ctx context.Context, script string) (string, error) {
|
|
*c.captured = script
|
|
return c.wrapped.Execute(ctx, script)
|
|
}
|
|
|
|
func TestIIS_ValidateOnly_OutputContextInError(t *testing.T) {
|
|
c := NewWithExecutor(&Config{SiteName: "DWS"}, quietLogger(), &stubExecutor{
|
|
out: "WARNING: This site is in stopped state",
|
|
err: errors.New("exit 1"),
|
|
})
|
|
err := c.ValidateOnly(context.Background(), target.DeploymentRequest{})
|
|
if err == nil || !strings.Contains(err.Error(), "stopped state") {
|
|
t.Errorf("got %v", err)
|
|
}
|
|
}
|