Commit Graph

2 Commits

Author SHA1 Message Date
Shankar fe0912c683 Bundle H follow-up: fix Pass 3 test mock shape mismatches caught by CI
CI surfaced two real failures in the Pass 3 tests:

1. ObservabilityPage.test.tsx — tests 2 + 3 mocked getMetrics with only

   the uptime field, but ObservabilityPage.tsx:85 reads metrics.gauge

   .certificate_total. Test 2 silently 'passed' because the page error

   bailed out before any rendering took place — its assertions (no live

   <script>, __xss_pwned__ undefined) became vacuous; test 3 surfaced

   the actual TypeError. Fix: every getMetrics mock now returns the full

   MetricsResponse shape (gauge / counter / uptime) per src/api/types.ts

   :517 — sanity-checked against the actual TS interface.

2. CertificateDetailPage.test.tsx — the xssCert mock was missing

   updated_at, which CertificateDetailPage.tsx:605 reads through

   formatDateTime. formatDateTime tolerates undefined per utils.ts:6,

   so the page didn't throw, but the cert mock should mirror the real

   ManagedCertificate shape — added updated_at.

Both fixes are mock-shape corrections; no production code changes.
2026-04-27 03:18:51 +00:00
Shankar ec29d20dee M-029 Pass 3 batch B: T-1 tests for 4 detail pages — XSS hardening
Continues Pass 3. Each detail page has its own narrow attack surface

(subject DN, last_test_message, error_message) that the test exercises

with literal <script> payloads in every text field.

Test files added:

  - CertificateDetailPage.test.tsx  cert subject / SANs / serial / PEM

                                     across 7 sidecar queries (getCertificate,

                                     getCertificateVersions, getTargets,

                                     getProfile, getProfiles, getRenewalPolicies,

                                     getJobs all mocked in beforeEach)

  - IssuerDetailPage.test.tsx       issuer name / type / config / last_test_message

                                     (router-aware test using Routes + useParams)

  - TargetDetailPage.test.tsx       target name / config / last_test_message

                                     (router-aware test pattern)

  - JobDetailPage.test.tsx          job error_message / type / details

                                     (3-query mock: getJob + getJobVerification +

                                     getAuditEvents)

Closes 9 of 14 T-1-deferred pages toward M-029 Pass 3 completion (5 batch A,

+ 4 batch B = 9; 5 to go in batch C).
2026-04-27 03:05:52 +00:00