3 Commits

Author	SHA1	Message	Date
shankar0123	5dc698307b	chore: rename Go module path to github.com/certctl-io/certctl ... Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol sub-module's go.mod, every Go file's import path (361 files), and a rebuild of the checked-in f5-mock-icontrol binary so its embedded build-info reflects the new module path. No behavior change. Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A (keep module path declared as github.com/shankar0123/certctl regardless of repo URL) shipped on the day of the org transfer (2026-05-03) since we had no external Go consumers; this commit closes that deferral. Backward-compat: GitHub HTTP redirects continue to forward github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL level, but Go's module proxy uses the path declared in go.mod as the canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...` hit a "module path mismatch" error because go.mod said github.com/shankar0123/certctl and the URL they fetched it from said certctl-io/certctl. Post-fix, the canonical name and the URL agree, so go get / go install / external Go consumers / Go-tooling integrations work cleanly via either the new path (preferred) or the old path (which redirects and Go follows the redirect for source fetch). Anyone still importing the old path inside their own code keeps working provided they update their go.mod's `require` line to match — the module path declared in their consumer's go.sum / go.mod is the authoritative import name, so a mass sed across their import statements is the migration on the consumer side. No external consumers exist today. Diff shape: 361 *.go files — import path replacement only 2 go.mod — module declaration replacement only 1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt so embedded build-info reflects the new path (8618965 vs 8618933 bytes; 32-byte diff is the build-info change) Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure mechanical substitution. Verification: gofmt: 17 files needed re-alignment after sed (the new path is one char shorter than the old, so column-aligned import groups drifted). Applied `gofmt -w` to fix. go mod tidy: clean exit on both modules. go vet ./...: clean exit. go build ./...: clean exit. go test -short -count=1 on representative packages: all green (internal/domain, internal/validation, internal/crypto, internal/crypto/signer, cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...` confirming the module path resolves correctly. binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns nothing; `strings | grep certctl-io/certctl` shows the new module path embedded in build-info. Files intentionally NOT touched in this commit: README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io URLs in commit bc6039a (the post-transfer URL refresh). This commit is purely the Go-tooling layer. Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account namespace, not a Go import or GitHub repo URL. Stays. This is a non-blocking, non-customer-impacting change. Operators pulling container images, running `make verify`, hitting the API, or installing the agent see no functional difference. Only Go-tooling consumers (none today) are affected, and they're enabled — not broken — by this commit.	2026-05-04 00:30:29 +00:00
shankar0123	825fcf39a4	asyncpoll: refactor Sectigo / Entrust / GlobalSign to bounded polling (Phase 2) ... Phase 2 of the #5 acquisition-readiness fix from the 2026-05-01 issuer coverage audit. Phase 1 (commit 593210f) shipped the shared asyncpoll package and refactored DigiCert as the reference. This commit applies the same pattern to the remaining three async-CA connectors and adds the operator-facing docs. Per-connector refactors: - Sectigo (sectigo.go): GetOrderStatus now wraps pollEnrollmentOnce in asyncpoll.Poll. The collectNotReady sentinel (cert approved by SCM but not yet retrievable from the collect endpoint) maps to StillPending and rides the backoff schedule rather than the prior "return pending immediately" branch. Added isPermanentStatusError helper to distinguish transient HTTP errors (5xx / 429 / network) from permanent ones (4xx / parse failure) — the wrapped checkStatus errors get triaged at the poll closure boundary. - Entrust (entrust.go): GetOrderStatus wraps pollEnrollmentOnce. The AWAITING_APPROVAL status maps to StillPending; operators using approval-pending workflows where humans approve enrollments should bump CERTCTL_ENTRUST_POLL_MAX_WAIT_SECONDS to 86400 (24h) so a single scheduler tick can wait through the approval window. The default 10-minute deadline matches the other three connectors. - GlobalSign (globalsign.go): GetOrderStatus wraps pollCertificateOnce. GlobalSign tracks orders by serial number rather than order ID, but the polling shape is identical to the other three. Status-code triage matches DigiCert: 4xx (not 429) is permanent, 5xx / 429 / network is transient. Per-connector Config field added: - DigiCert.PollMaxWaitSeconds (env CERTCTL_DIGICERT_POLL_MAX_WAIT_SECONDS) - Sectigo.PollMaxWaitSeconds (env CERTCTL_SECTIGO_POLL_MAX_WAIT_SECONDS) - Entrust.PollMaxWaitSeconds (env CERTCTL_ENTRUST_POLL_MAX_WAIT_SECONDS) - GlobalSign.PollMaxWaitSeconds (env CERTCTL_GLOBALSIGN_POLL_MAX_WAIT_SECONDS) internal/config/config.go env-var loaders updated for all four. Default is 600 seconds (10 minutes); zero falls back to the asyncpoll package default. Test-helper updates: every existing test that exercises the pending branch (collectNotReady, AWAITING_APPROVAL, status="pending", etc.) now sets PollMaxWaitSeconds=1 in its Config so the test doesn't block on the production-default 10-minute deadline. Tests that exercise permanent-error branches (404, 401, malformed JSON, etc.) continue to return immediately. Test sites updated: - buildSectigoConnector helper + GetOrderStatus_CollectNotReady test - buildEntrustConnector helper + GetOrderStatus_Pending test - buildGlobalsignConnector helper + GetOrderStatus_Pending test + the GetHTTPClient_NoMTLSCertPaths test (network failure now rides the backoff schedule rather than returning immediately) Documentation: - docs/async-polling.md: new operator reference covering the backoff schedule, status-code triage, the four env vars, failure modes, and where the implementation lives. Audit blocker citation included. - docs/connectors.md: per-issuer sections for DigiCert, Sectigo, Entrust, GlobalSign each gain the PollMaxWaitSeconds env var row and a cross-link to async-polling.md. Lint cleanup: simplified the isPermanentStatusError branch to satisfy staticcheck S1008 (single-line return for a final boolean check). Verified locally: - gofmt -l . clean - go vet ./... clean - staticcheck ./... clean - golangci-lint run --timeout 5m ./... → 0 issues - go test -short -count=1 across all 4 connector packages + config + asyncpoll: green Audit reference: cowork/issuer-coverage-audit-2026-05-01/RESULTS.md Top-10 fix #5 — Phase 2.	2026-05-02 02:41:36 +00:00
Shankar	dd79096b70	feat(M49): Entrust, GlobalSign & EJBCA issuer connectors ... Add three new issuer connectors completing commercial and open-source CA coverage. Entrust uses mTLS client certificate auth with sync/async issuance. GlobalSign Atlas uses mTLS + API key/secret dual auth with serial-based tracking. EJBCA supports dual auth (mTLS or OAuth2) for self-hosted Keyfactor CAs. Each connector implements the full issuer.Connector interface (9 methods), includes httptest-based unit tests (~14 each), and follows established patterns (injectable HTTP clients, RFC 5280 revocation reason mapping, CRL/OCSP delegated to CA). Also includes: issuer factory cases, env var seeding, config structs, domain types, seed data (3 rows, all disabled), OpenAPI enum updates, frontend issuer catalog entries with config fields, and full docs (connectors.md, architecture.md, features.md, README). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-15 22:24:12 -04:00