Phase 4 of the deploy-hardening I master bundle. The canonical NGINX
implementation that Phases 5-9 model on. Replaces the historical
os.WriteFile flow at internal/connector/target/nginx/nginx.go:99
with deploy.Apply() and adds three production-grade competitor-gap
features: atomic deploy with rollback, post-deploy TLS verify, file
ownership preservation.
NGINX connector — internal/connector/target/nginx/nginx.go:
- DeployCertificate now wires deploy.Apply with PreCommit running
the operator's ValidateCommand (e.g. `nginx -t`), PostCommit
running ReloadCommand (e.g. `nginx -s reload`), and an explicit
post-deploy TLS verify step that dials the configured endpoint,
pulls the leaf cert SHA-256, and compares against what was just
deployed. SHA-256 mismatch (wrong vhost / cached cert / NGINX
still serving stale) triggers automatic rollback: backup files
are restored + reload fired again. Failed-second-reload returns
ErrRollbackFailed (operator-actionable; loud audit + alert).
- ValidateOnly replaces the Phase 3 stub: runs the operator's
ValidateCommand without touching the live cert. V2 contract is
syntax-only validation (full pre-deploy temp-config validation
is V3-Pro). Returns ErrValidateOnlyNotSupported when no
ValidateCommand is configured.
- New per-target Config fields: PostDeployVerify (frozen-decision-
0.3 default ON), PostDeployVerifyAttempts (default 3 — defends
against load-balanced targets where the verify might hit a
different pod that hasn't picked up the new cert yet),
PostDeployVerifyBackoff (default 2s exponential), per-file
Mode/Owner/Group overrides (KeyFileMode, CertFileMode,
KeyFileOwner, etc.), and BackupRetention (default 3, -1 to
disable backups entirely — documented foot-gun).
- buildPlan honors per-distro nginx user (Debian: www-data,
Alpine: nginx, Red Hat: nginx) by checking the local user
database; falls back to no-chown when neither exists. Means
the connector is portable across distros without operator
config.
Deploy package — internal/deploy/ownership.go:
- applyOwnership now silently swallows chown failures when the
agent isn't running as root. Production agents always run as
root and chown failures are real bugs; dev / CI runs as a
regular user where chown to a different uid will always fail
with EPERM (or EINVAL on some tmpfs configs) and would
otherwise force every test to run with sudo. Production-grade
contract preserved (uid 0 still hard-fails on chown errors).
Test suite — internal/connector/target/nginx/nginx_atomic_test.go
ships 42 new named tests (NGINX total: 17 pre-existing + 42 new = 59,
above the prompt's >=40 bar; matches the IIS depth bar of 41):
- Atomic-deploy invariants (cert+chain+key all-or-nothing,
validate-fails-no-files-changed, reload-fails-rollback,
rollback-also-fails-escalation)
- SHA-256 idempotency (full match skips, partial match deploys all)
- Post-deploy TLS verify (fingerprint-match-success,
SHA256-mismatch-rollback, dial-timeout-rollback, retries-until-
match, retries-exhausted-rollback, no-endpoint-skips,
disabled-skips-entirely, default-10s-timeout, endpoint-forwarded)
- Ownership / mode preservation (existing-mode-preserved, override-
wins, KeyFileMode override applied)
- Backup retention (keeps-last-N, disabled-creates-no-backups,
fresh-deploy-creates-backup)
- Concurrency (same-paths-serialize via deploy package's file mutex,
different-paths-parallelize)
- ValidateOnly (happy-path-nil, command-fails-wrapped-error,
no-config-returns-sentinel, ctx-cancelled, stderr-in-message)
- Edge cases (no-chain, no-key, no-chain-path, empty-cert-PEM,
ctx-cancelled, all-four-one-apply)
- Result.Metadata + DeploymentID shape contracts
Coverage: NGINX 91.0% (above the >=85% prompt bar). Race detector
clean. golangci-lint v2.11.4 clean. Existing 17 tests still all pass
(no behavior change in the legacy paths exercised there).
Phase 5 next: mirror this implementation for Apache + lift its
test count from 3 to >=30. Same template applies through Phases
6-9 for the remaining 11 connectors.
Fixes 12 production bugs preventing the full issuance→deployment flow
from working with ACME (Pebble/Let's Encrypt) and step-ca issuers:
ACME connector (acme.go):
- Save orderURI before WaitOrder overwrites it (Go crypto/acme bug)
- Add CreateOrderCert fallback via WaitOrder+FetchCert
- Remove defer-reset in ValidateConfig that caused nil pointer panic
- Add Insecure TLS option for self-signed ACME servers (Pebble)
step-ca connector (stepca.go, jwe.go):
- Real JWE provisioner key loading + decryption (was using ephemeral keys)
- Fix JWT audience (/1.0/sign), sha claim (key fingerprint), kid header
- Custom root CA trust via RootCertPath config
- Remove hardcoded 90-day validity default (let step-ca decide)
NGINX target connector (nginx.go):
- Use sh -c for validate/reload commands (shell interpretation)
- Use filepath.Dir instead of fragile string slicing
- Add private key file writing (agent-mode keys were never deployed)
- Make chain_path write conditional
Server/service layer:
- TriggerRenewalWithActor now creates actual Job records (was no-op)
- createDeploymentJobs falls back to DB query when cert.TargetIDs empty
- ProcessPendingJobs skips agent-routed deployment jobs
- Agent cert pickup path parsing: len(parts)<4 → len(parts)<3
- Health/ready/auth-info endpoints bypass auth middleware
- Write timeout 15s→120s for ACME issuance
- Cert fingerprint computed on CSR submission
Integration test environment (deploy/test/):
- 10-phase test script covering Local CA, ACME, step-ca, revocation,
discovery, renewal, and API spot checks
- Docker Compose with 7 containers (server, agent, postgres, nginx,
pebble, challtestsrv, step-ca) on isolated network
- TLS verification checks SAN (not just Subject CN) for modern CA compat
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Added TestSlack_ClientHasTimeout to verify 10-second timeout
- Added TestTeams_ClientHasTimeout to verify 10-second timeout
- Added TestPagerDuty_ClientHasTimeout to verify 10-second timeout
- Added TestOpsGenie_ClientHasTimeout to verify 10-second timeout
- All notifiers already configured with 10 second timeout in New()
- Tests verify timeout is set and matches expected value
Upgrade from Go 1.22 to 1.25 (minimum for MCP SDK, actively supported).
CI updated to match.
Codebase audit fixes:
- Local CA parseIP() now uses net.ParseIP — IP SANs no longer silently dropped
- Nil pointer guards in agent.go GetWorkWithTargets for target/cert enrichment
- MCP CreateCertificateInput marks owner_id/team_id as required
- NGINX connector uses CombinedOutput() — captures diagnostic output on failure
- Jobs handler validates JSON decode on rejection body — returns 400 on malformed
- CRL/OCSP handlers propagate requestID for error tracing
MCP server tests (26 tests):
- client_test.go: HTTP client coverage (GET/POST/PUT/DELETE, auth, 204, errors, binary)
- tools_test.go: tool registration, pagination, end-to-end flows with mock API
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes Go Report Card gofmt score from 52% to 100%.
Pure formatting changes — no logic modifications.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backend hardening:
- Fix 6 nginx.go non-constant format string build errors
- Add validation.go with hostname, PEM, and enum validators
- Apply input validation to all POST/PUT handlers (certificates,
agents, CSR, policies, teams, owners, targets, issuers)
- Fix unchecked JSON decode in TriggerDeployment handler
Frontend (Vite + React + TypeScript):
- Migrate from single-file SPA to proper build pipeline
- 7 pages: Dashboard, Certificates (list+detail), Agents, Jobs,
Notifications, Policies, Audit Trail
- TanStack Query for server state with auto-refetch intervals
- Certificate detail with version history and renewal trigger
- Job cancellation, status/type filtering, expiry countdowns
- Reusable components: DataTable, StatusBadge, ErrorState, PageHeader
- Dark theme with Tailwind CSS, sidebar nav via React Router
Server integration:
- Go server serves web/dist/ (Vite output) with SPA fallback
- Falls back to web/index.html for legacy mode
- .gitignore updated for web/node_modules/ and web/dist/
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shankar0123