2 Commits

Author	SHA1	Message	Date
shankar0123	5dc698307b	chore: rename Go module path to github.com/certctl-io/certctl ... Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol sub-module's go.mod, every Go file's import path (361 files), and a rebuild of the checked-in f5-mock-icontrol binary so its embedded build-info reflects the new module path. No behavior change. Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A (keep module path declared as github.com/shankar0123/certctl regardless of repo URL) shipped on the day of the org transfer (2026-05-03) since we had no external Go consumers; this commit closes that deferral. Backward-compat: GitHub HTTP redirects continue to forward github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL level, but Go's module proxy uses the path declared in go.mod as the canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...` hit a "module path mismatch" error because go.mod said github.com/shankar0123/certctl and the URL they fetched it from said certctl-io/certctl. Post-fix, the canonical name and the URL agree, so go get / go install / external Go consumers / Go-tooling integrations work cleanly via either the new path (preferred) or the old path (which redirects and Go follows the redirect for source fetch). Anyone still importing the old path inside their own code keeps working provided they update their go.mod's `require` line to match — the module path declared in their consumer's go.sum / go.mod is the authoritative import name, so a mass sed across their import statements is the migration on the consumer side. No external consumers exist today. Diff shape: 361 *.go files — import path replacement only 2 go.mod — module declaration replacement only 1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt so embedded build-info reflects the new path (8618965 vs 8618933 bytes; 32-byte diff is the build-info change) Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure mechanical substitution. Verification: gofmt: 17 files needed re-alignment after sed (the new path is one char shorter than the old, so column-aligned import groups drifted). Applied `gofmt -w` to fix. go mod tidy: clean exit on both modules. go vet ./...: clean exit. go build ./...: clean exit. go test -short -count=1 on representative packages: all green (internal/domain, internal/validation, internal/crypto, internal/crypto/signer, cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...` confirming the module path resolves correctly. binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns nothing; `strings | grep certctl-io/certctl` shows the new module path embedded in build-info. Files intentionally NOT touched in this commit: README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io URLs in commit bc6039a (the post-transfer URL refresh). This commit is purely the Go-tooling layer. Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account namespace, not a Go import or GitHub repo URL. Stays. This is a non-blocking, non-customer-impacting change. Operators pulling container images, running `make verify`, hitting the API, or installing the agent see no functional difference. Only Go-tooling consumers (none today) are affected, and they're enabled — not broken — by this commit.	2026-05-04 00:30:29 +00:00
Shankar	cdacac6bbe	crl/ocsp: admin observability endpoint + Phase 6 e2e scaffold ... Phase 5 (admin endpoint slice) + Phase 6 (e2e test stub) of the CRL/OCSP responder bundle. Closes the deferred items from the backend-slice merge (4e234fa). What landed: Phase 5 — admin observability: * GET /api/v1/admin/crl/cache (handler.AdminCRLCacheHandler): - Per-issuer cache state + most recent N generation events - Admin-gated via middleware.IsAdmin (M-003 pattern); non-admin callers get 403 + the service is never invoked - Reveals issuer set + CRL cadence, hence the gate - Returns CachePresent=false rows for never-generated issuers so the GUI can show 'not yet generated' instead of 404 - Per-issuer Get failures decorate the row's RecentEvents rather than failing the whole response * AdminCRLCacheServiceImpl: thin handler-side composition over repository.CRLCacheRepository + an issuer-IDs callback (avoids importing internal/service from internal/api/handler) * M-008 admin-gate pin updated: admin_crl_cache.go added to AdminGatedHandlers; full triplet of tests (NonAdmin_Returns403, AdminExplicitFalse_Returns403, AdminPermitted_ForwardsActor) + RejectsNonGetMethod + PropagatesServiceError * Router registration + HandlerRegistry field + main.go wiring (callback closure over issuerRegistry.List) * OpenAPI entry under CRL & OCSP tag Phase 6 — e2e scaffold: * deploy/test/crl_ocsp_e2e_test.go with TestCRLOCSPLifecycle + TestCRLOCSPPostEndpoint * Lifecycle test exercises issue → fetch OCSP (Good) → revoke → wait → fetch CRL (entry present) → fetch OCSP (Revoked) → verify dedicated responder cert + id-pkix-ocsp-nocheck * Helpers (issueLocalCert, revokeCertViaAPI, fetchCRL, fetchOCSP, fetchCACert) currently call t.Skip with TODO markers — sandbox has no Docker so the harness can't be wired end-to-end here; when CI / a fresh dev workstation runs, the implementer wires each helper to the existing integration_test.go primitives * Build-tagged //go:build integration so the standard go test sweep skips it; runs via the deploy/test integration workflow Coverage: handler 80.6% (above 75 floor; was 79.8% pre-Phase-5). All other packages unchanged. Backward compat: admin endpoint inert until an admin Bearer key is configured. The e2e test stub is no-op (skips) until wired. Deferred: * GUI cert-detail-page revocation panel — pure frontend work, no backend impact, separate session * E2E test helper wiring — depends on extracting the existing integration-test harness primitives into shared helpers; doable in a follow-up that has Docker available * V3-Pro polish (delta CRLs, OCSP rate-limiting, OCSP stapling)	2026-04-29 01:55:39 +00:00