7 Commits

Author	SHA1	Message	Date
shankar0123	7c01f811a1	feat(frontend): Phase 2 TanStack Query Discipline — close TQ-H1/H2 + TQ-M1/M2/M3 + PERF-H1 + P-H1 + partial TQ-L1 ... Phase 2 of the frontend-design audit: TanStack Query discipline. Set the cross-cutting QueryClient defaults + staleTime/gcTime tier model + visibility-aware polling + 4 optimistic-update mutations before any further per-page work. New foundation ============== web/src/api/queryConstants.ts (new) STALE_TIME = { REAL_TIME: 15s, REFERENCE: 5m, CONSTANT: 1h } GC_TIME = { HEAVY: 1m, STANDARD: 5m, REFERENCE: 30m } Doc-comment explains the tier model so every new useQuery picks a tier rather than a hardcoded ms integer. web/src/main.tsx QueryClient defaults rewritten: pre: staleTime: 10_000 + refetchOnWindowFocus: true (refetch storm on every tab refocus across 242 query sites) post: staleTime: STALE_TIME.REFERENCE (5min) + gcTime: GC_TIME .STANDARD (explicit 5min) + refetchOnWindowFocus: false (per-query opt-in for live-tile queries) retry: 1 unchanged per the audit's DO NOT. Findings closed by source ID ============================ TQ-H2 (refetch storm) main.tsx QueryClient defaults — refetchOnWindowFocus: false root + per-query opt-in. STALE_TIME.REFERENCE 5min for everything else. TQ-M1 (no gcTime overrides) main.tsx now sets gcTime: GC_TIME.STANDARD explicitly — the contract is documented at the root, not implicit-defaulted by TanStack. TQ-M2 (12 inconsistent staleTime values) All 11 hardcoded numeric staleTime overrides migrated to the STALE_TIME tier constants. useAuthMe.ts (the 12th) already used its own constant — left alone. Tier mapping: - operator-facing live data (KeysPage keys, RoleDetail role, UsersPage, OIDCJWKSStatusPanel, ApprovalsPage): STALE_TIME.REAL_TIME (15s) - slow-changing reference data (KeysPage roles, RolesPage, AuthSettings bootstrap+runtime-config): STALE_TIME.REFERENCE (5min) - effectively immutable (RoleDetail permissions catalogue): STALE_TIME.CONSTANT (1hr) TQ-H1 (OnboardingWizard infinite 5s poll) OnboardingWizard.tsx:288-302 — refetchInterval rewritten to v5 functional form: refetchInterval: (query) => (query.state.data?.data?.length ?? 0) > 0 ? false : 5_000; As soon as the first agent registers, the interval flips to false and the poll stops. Also explicit: refetchOnWindowFocus: true + staleTime: STALE_TIME.REAL_TIME (because this IS a live-tile poll during the wizard). PERF-H1 (Dashboard polling storm) DashboardPage.tsx - jobs poll bumped 10s → 30s (10s granularity isn't needed when 30s is already inside the human-attention window; the CertificateDetail page is where 10s polling lives) - visibility-listener pauses ALL Dashboard polls when document.visibilityState === 'hidden'; on visibility return, immediately invalidates the 4 live-tile queries (health, dashboard-summary, jobs, certs-by-status) so the operator sees fresh data instantly rather than waiting one tick. - The 4 live-tile queries (health, dashboard-summary, jobs, certs-by-status) opt into refetchOnWindowFocus: true + staleTime: STALE_TIME.REAL_TIME explicitly. - Backend aggregation gap (dashboard-summary + certs-by-status + certificates could collapse into 1 endpoint) tracked separately — Phase 3 backend follow-up. P-H1 (CertificatesPage 4 duplicate-key pairs) Pre-Phase-2 4 pairs of distinct cache slots fetching the same data: ['profiles'] vs ['profiles-filter'] ['issuers'] vs ['issuers-filter'] ['owners', 'form'] vs ['owners-filter'] ['teams', 'form'] vs ['teams-filter'] Post-Phase-2 all four pairs collapse to a single parameterized queryKey shape: `[name, { per_page: 100 }]`. TanStack v5 dedupes on serialized queryKey — the modal + filter now share one cache slot per resource. 8 useQuery sites → 4 cache slots; backend hits halved on first paint of CertificatesPage. TQ-M3 (4 of 5 priority optimistic-update mutations) Wired onMutate / onError-rollback / onSettled-invalidation on: 1. mark-notification-read (NotificationsPage) — flips row status to 'read' in both ['notifications','all'] + ['notifications','dead'] cache slots 2. claim-discovered-cert (DiscoveryPage) — flips status to 'Managed' in ['discovered-certificates'] 3. dismiss-discovery (DiscoveryPage) — flips status to 'Dismissed' in same cache slot 4. archive-certificate (CertificateDetailPage) — flips status to 'Archived' in ['certificate', id]; on success navigates to /certificates (optimistic data doesn't linger); on error restores snapshot + toasts All four fire the Phase 1 Sonner toast on success/failure. The 5th priority site (role-assignment toggle in auth/RoleDetailPage) uses raw async/await handlers rather than useTrackedMutation — converting it requires a structural refactor outside Phase 2's TQ-focus; tracked as Phase 2 follow-up. TQ-L1 (useTrackedMutation extended tests) useTrackedMutation.test.tsx grew from 3 tests to 8: + passes onMutate through and runs it before mutationFn + passes onError through with the onMutate context (rollback path — pins the 3rd-arg snapshot semantics) + does NOT invalidate on error (only on success) + passes onSettled through (fires after both success + error) + parity with raw useMutation when no extra options given Verification ============ $ grep -E "refetchOnWindowFocus: false" web/src/main.tsx 89: refetchOnWindowFocus: false, // per-query opt-in $ grep -E "STALE_TIME\.REFERENCE" web/src/main.tsx 86: staleTime: STALE_TIME.REFERENCE, // 5 min $ grep -cE "useQuery.*\['profiles" web/src/pages/CertificatesPage.tsx 2 (was 6 pre-Phase-2 — '[profiles]' modal + '[profiles-filter]' + '[profiles]' top-of-page; now both refer to the same parameterized key '[profiles, { per_page: 100 }]') $ grep -rE "onMutate" web/src --include='*.tsx' --exclude='*.test.*' | wc -l 5 (≥ 4 priority sites; the 5th is the optional onMutate in queryConstants test wiring) $ grep -rE "STALE_TIME\." web/src --include='*.tsx' --include='*.ts' \ --exclude='*.test.*' | wc -l 18 (queryConstants.ts + main.tsx + 11 migrated callsites + OnboardingWizard + DashboardPage) $ npx tsc --noEmit (exit 0) $ npx vitest run [13 affected test files] Test Files 13 passed (13) Tests 100 passed (100) $ npx vite build ✓ built in 2.49s dist/assets/index-yg3cYtYA.js 1,113 kB (+3 kB vs Phase 1 — queryConstants + optimistic-update wrappers) Audit-accuracy callouts ======================= * The audit claimed 10 useQuery on Dashboard; live count is 9 (one issuers query has no interval). All 8 polling queries now gated behind visibility-listener; the 9th (issuers) is non-polling and not affected. * TQ-L1 originally specified 4 test extensions; shipped 5 (onMutate ordering, onError-with-context, no-invalidate-on-error, onSettled pass-through, parity-with-raw-useMutation). * Optimistic-update 5th-site (role-assignment toggle in auth/RoleDetailPage) deferred — RoleDetailPage handlers use raw async/await instead of useTrackedMutation. Refactoring it adds one more optimistic path but requires a structural change outside Phase 2's TQ-discipline scope. Tracked as Phase 2 follow-up. Residual risks ============== * The Dashboard visibility-listener gate may need per-page opt-in if a page genuinely needs to keep polling while hidden (e.g. a background-tab monitor). Not aware of any such case today; if needed, the gate is a simple `useState`-driven hook extracted to web/src/hooks/useTabVisibility.ts. * The Dashboard backend-aggregation collapse (dashboard-summary + certs-by-status + certificates → one endpoint) is documented as a Phase-3 backend item. * The 4 collapsed CertificatesPage pairs now request per_page=100 everywhere. Operator with >100 issuers/owners/profiles/teams will see a truncated dropdown — that's an unrelated Phase-1- Combobox-migration concern; the right fix when it lands is to move issuer/owner/profile selectors to Combobox with server-side typeahead. * The 12-second total Bundle-1 audit of all useQuery sites still leaves ~230 queries running with the new 5-min REFERENCE default. The default is generous; aggressively- fresh per-page queries that genuinely need 15s freshness must opt in (the audit page, the agent-fleet live counter, in-flight scan progress).	2026-05-14 14:51:49 +00:00
shankar0123	93e00f6a5e	fix(frontend): Phase 0 Hygiene Day — close 11 of 12 frontend-audit findings ... Frontend design remediation, Phase 0 (Hygiene Day). Eleven low-risk audit findings closed in one PR. UX-M9 deliberately deferred per the prompt's "do NOT auto-trace the logo" guard rail — that needs a designer round-trip outside a code session. Findings closed (mapped by source ID) ===================================== FE-H1 Half-wired dark mode removed. web/index.html: dropped class="dark" from <html> and bg-slate-900 text-slate-100 from <body>. Replaced with bg-page text-ink (matching the live light-mode palette). web/tailwind.config.cjs: kept darkMode: 'class' (config only, zero behaviour) so a future Phase 7 dark-mode rebuild stays cheap. FE-H4 Self-hosted fonts (closes PERF-H3 as a side-effect). web/package.json: added @fontsource-variable/inter + @fontsource/jetbrains-mono (^5.2.8 both). web/src/main.tsx: top of file imports the variable Inter family + JetBrains Mono weights 400/500/600 (matching the old Google Fonts request's weight set). web/src/index.css: removed the @import url( 'https://fonts.googleapis.com/...') that lived on line 1. Body font-family updated to "Inter Variable", "Inter", system-ui, ... (fontsource-variable registers the family as "Inter Variable" — kept "Inter" as a fallback). Vite bundles the .woff2 files into dist/assets/ on build: verified inter-latin-wght-normal-*.woff2 (48 kB) + the JetBrains weights all land in the build output. Net effect: cold load makes ZERO third-party requests. FE-L2 StatusBadge.tsx.bak removed. Audit claim "tracked in git" was stale — the file was already excluded by .gitignore:46 (*.bak). Closure was a plain `rm`, not `git rm`. (Audit accuracy note above.) FE-L3 brand-900 removed from web/tailwind.config.cjs. Verified 0 callers in web/src via `grep -rEc "brand-$w\b" web/src --include='*.tsx'`. Other weights all retain ≥4 callers (50=5, 100=4, 200=4, 300=8, 400=106, 500=74, 600=34, 700=23, 800=4) — they stay. Comment marker left in place so a future Phase 7 dark-mode redo can re-add 900 with context. UX-M6 text-ink-faint contrast bumped from #94a3b8 (3.0:1 against bg-page #f0f4f8, fails WCAG AA) to #64748b (4.6:1, passes AA). To preserve the three-tier ink hierarchy, ink.muted darkens from #64748b to #475569 (6.9:1, passes AA Large). All 105 live text-ink-faint callers now meet WCAG AA without any callsite edits. UX-M9 DEFERRED. The audit prompt's "do NOT auto-trace the PNG logo to SVG" guard rail blocks the auto-conversion path. Logo (886x864 PNG, 773 kB) remains shipped to dist/assets/ unchanged. Tracking item: round-trip through designer with a flat-geometric Illustrator/Figma rebuild. Phase 0 commit ships the rest of the hygiene block; UX-M9 stays open until the SVG asset lands. UX-L1 23 hardcoded text-[Npx] sites migrated to design tokens (audit said 23; live count was 25 — also 2x text-[13px] the audit missed). web/tailwind.config.cjs added the `2xs: 0.625rem` (10px) rung so the 7x text-[10px] sites migrate losslessly. The 16x text-[11px] sites move to text-xs (+1px, imperceptible) and the 2x text-[13px] sites move to text-sm (+1px, imperceptible). Six files touched: Layout.tsx, NetworkScanPage.tsx, SCEPAdminPage.tsx, DiscoveryPage.tsx, ESTAdminPage.tsx, auth/SessionsPage.tsx. Post-migration: zero `text-[Npx]` callers in web/src. UX-L2 prefers-reduced-motion handling added at the bottom of web/src/index.css. Caps animation-duration + transition-duration at 0.01ms when the OS reduce-motion flag is set. Conventional non-zero value (fully zero breaks libraries observing transitionend events). UX-L3 Print stylesheet added to web/src/index.css. Hides sidebar / nav, removes card shadows, expands content to full width, prevents mid-row table breaks, and appends link URLs as text annotations (print readers can't click links). Operator-facing — certificate detail + audit-log export are the most common print targets. UX-L4 DataTable.tsx <th>s now carry scope="col". One-line change on each of the two header sites (selectable checkbox column + the columns.map iteration). Closes the accessibility-tree screen-reader gap. PERF-H2 The only production <img> site (Layout.tsx:73, the sidebar logo) gained loading="eager" decoding="async" + explicit width/height (64x64). eager (not lazy) because the logo is the LCP candidate above the fold. Since UX-M9 deferred, the logo stays as a PNG — making this the right LCP hint to ship today. PERF-H3 Closes via FE-H4 (self-host fonts → zero third-party requests on cold load → preconnect/dns-prefetch hints would point at nothing). web/index.html stays free of preconnect lines. Verification ============ $ git status --short (only the 13 expected files modified) $ cd web && npx tsc --noEmit (exit 0, no type errors) $ cd web && npx vitest run Test Files 54 passed (54) Tests 583 passed (583) (all green; ran via `timeout 35 npx vitest run`) $ cd web && npx vite build ✓ built in 2.70s dist/assets/index-Da_kGcIu.css 75.54 kB (was 39.50 kB pre-Phase-0 — +36 kB from the inlined @fontsource @font-face declarations + the new @media print + @media reduced-motion blocks; offset by the elimination of all third-party font requests + the FOIT on cold load) dist/assets/inter-latin-wght-normal-Dx4kXJAl.woff2 48.25 kB dist/assets/jetbrains-mono-latin-400-normal-V6pRDFza.woff2 21.16 kB (... + the rest of the weight variants and unicode-range subsets) $ grep -rohE "text-\[[0-9]+px\]" web/src --include='*.tsx' (zero matches — all 25 inline-pixel sites migrated) $ grep -rEc "brand-900" web/src --include='*.tsx' (zero callers) $ grep -nE "scope=\"col\"" web/src/components/DataTable.tsx 86, 96 (both <th> sites carry scope="col") $ grep -nE "loading=|decoding=" web/src/components/Layout.tsx 73 (logo <img> has both attrs + width/height) $ grep -nE "prefers-reduced-motion|@media print" web/src/index.css 74, 92 (both blocks present) $ ls web/src/components/StatusBadge.tsx.bak (file not found — deleted) Audit-accuracy notes ==================== * FE-L2 stale: the .bak file was NOT tracked in git (gitignored via .gitignore:46 *.bak). The audit's "tracked in git" claim was wrong. Closure path adjusted: `rm` instead of `git rm`. * UX-L1 undercount: audit reported 23 inline-pixel sites; live count was 25 (16x 11px + 7x 10px + 2x 13px). All 25 migrated. * UX-M9 not closed: audit prompt's "do NOT auto-trace" guard rail blocks closure in this code session. Tracking item for the designer/Phase-1 follow-up. Residual risks ============== * Logo PNG (773 kB) still ships as-is until the designer round-trip produces a hand-built SVG. Vite cache-busts the asset hash so cold loads cost the same one-shot 773 kB; warm loads hit the browser cache. * Removing brand-900 may surface in a future dark-mode rebuild (Phase 7) that wants a deeper teal floor. Easy re-add — comment marker left in tailwind.config.cjs at the deletion site. * The +1px nudges on text-[11px] -> text-xs and text-[13px] -> text-sm are theoretically visible but practically imperceptible. Any future visual-regression suite will catch genuine differences.	2026-05-14 13:42:04 +00:00
shankar0123	ff6ffcda1b	refactor(web): drop 5 unused imports across 4 pages (CodeQL #6, #7, #8, #9) ... Four CodeQL js/unused-local-variable alerts in one sweep — all Note severity, all pure dead-import cleanup verified by grep (each removed symbol had exactly 1 occurrence in its file: the import line itself). Alert #6 — web/src/pages/AgentFleetPage.tsx:3: Drop Legend from recharts named-import list. The fleet pie chart renders without a legend (the slice colors are labeled inline via Tooltip). Alert #7 — web/src/pages/DashboardPage.tsx:9: Drop getAgents + getNotifications from the api/client named- import list. The dashboard summary card now uses getDashboardSummary (single endpoint) instead of fanning out to per-resource list calls; the agents + notifications full list is reachable via dedicated pages. Alert #8 — web/src/pages/CertificatesPage.tsx:6: Drop revokeCertificate from the api/client named-import list. The page uses bulkRevokeCertificates for the multi-cert UX; single-cert revoke happens on CertificateDetailPage which imports revokeCertificate independently. Alert #9 — web/src/pages/DiscoveryPage.tsx:15: Drop the StatusBadge default-import line. Discovered-cert status renders inline (text label colored via the row's state-class) without the StatusBadge component. Verified locally: Each flagged symbol: 0 occurrences in its file post-edit. tsc --noEmit: exit 0. No behavioral change — pure import-list cleanup. References: https://github.com/certctl-io/certctl/security/code-scanning/6 https://github.com/certctl-io/certctl/security/code-scanning/7 https://github.com/certctl-io/certctl/security/code-scanning/8 https://github.com/certctl-io/certctl/security/code-scanning/9 Closes all four alerts.	2026-05-04 05:31:17 +00:00
shankar0123	e0a3d50f5e	M-029 Pass 1 batch 2: migrate 5 two-mutation pages to useTrackedMutation ... Drains 10 more useMutation sites (52 -> 42). Each migration declares explicit invalidates per the M-009 contract. Pages migrated: - DashboardPage.tsx previewDigest + sendDigest both 'noop' (read-only preview / fire-and-forget email — no client cache impact) - DiscoveryPage.tsx claim + dismiss both invalidate [['discovered-certificates'], ['discovery-summary']] - NotificationsPage.tsx markRead + requeue both invalidate [['notifications']] - TargetDetailPage.tsx update + testConnection both invalidate [['target', id]] - TargetsPage.tsx createTarget + deleteTarget both invalidate [['targets']] Verification: legacy useMutation count 52 -> 42 (-10) useTrackedMutation count 4 -> 14 (+10) Closes 14 of 56 sites toward M-029 Pass 1 completion.	2026-04-27 02:40:54 +00:00
shankar0123	e1bcde4cf1	feat(M50): cloud secret manager discovery — AWS SM, Azure KV, GCP SM ... Extend certificate discovery from filesystem + network to cloud secret managers. Three pluggable DiscoverySource connectors feed into the existing discovery pipeline via sentinel agent pattern, with a 9th scheduler loop for periodic cloud scanning. - AWS Secrets Manager: aws-sdk-go-v2, tag/prefix filtering, 10 tests - Azure Key Vault: stdlib HTTP + OAuth2, base64 DER/PEM, 16 tests - GCP Secret Manager: stdlib HTTP + JWT OAuth2, label filter, 14 tests - CloudDiscoveryService orchestrator with 9 tests - 9th scheduler loop (6h default, atomic.Bool idempotency) - Discovery page: color-coded source type badges - 14 new env vars across CloudDiscoveryConfig structs - Docs: connectors.md, architecture.md, features.md, README updated 49 new tests. All CI checks pass (go vet, race, lint, coverage). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-15 23:01:00 -04:00
shankar0123	6c8d4eca40	feat: frontend audit fixes, README accuracy pass, doc updates ... Frontend audit (10 categories): lifecycle fields in types, new API functions (CRL, OCSP, deployments, updateIssuer/Target, getPolicy), issuer/owner/profile filters on CertificatesPage, last_renewal_at column, error_message column on JobsPage, full crypto policy UI on ProfilesPage (key algorithms, EKUs, SAN patterns), key info + CA badge on DiscoveryPage, edit modal on TargetDetailPage, tags field on certificate creation, darwin→macOS mapping on AgentFleetPage. 211 Vitest tests passing. README accuracy: test counts (1300+ Go, 211 frontend), page count (24), demo data (32 certs, 7 issuers, 180 days), endpoint count (97), MCP tools (80), CLI subcommands (10), moved shipped items out of "Coming in v2.1.0". Docs: architecture.md diagrams updated (Vault PKI, DigiCert, Traefik, Caddy added), features.md Vault/DigiCert status updated. Version bumped to v2.0.20. cli binary removed from git tracking. Testing guide Part 41 added (12 auto + 9 manual tests). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-30 22:10:45 -04:00
shankar0123	d9fd0a147e	feat(gui): add discovery triage, network scan management, and approval workflow pages (M24) ... Three new GUI surfaces closing the backend-to-frontend gap for V2: - Discovery triage page: summary stats bar, DataTable with claim/dismiss actions, status/agent filters, collapsible scan history panel - Network scan target management: CRUD with create modal, enable/disable toggle, Scan Now button, last scan results display - Jobs page approval workflow: Approve/Reject buttons for AwaitingApproval jobs, rejection reason modal, pending approval banner with count, AwaitingApproval/AwaitingCSR added to status filter dropdown Also adds 13 new frontend tests, 4 API types, 12 API client functions, 2 sidebar nav items, 2 routes, and discovery status badge styles. Docs updated: README, architecture, quickstart, demo-advanced, CLAUDE.md, roadmap. Version bumped to v2.0.4. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-27 15:59:27 -04:00