Commit Graph

2 Commits

Author SHA1 Message Date
shankar0123 5dc698307b chore: rename Go module path to github.com/certctl-io/certctl
Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol
sub-module's go.mod, every Go file's import path (361 files), and a rebuild of
the checked-in f5-mock-icontrol binary so its embedded build-info reflects the
new module path. No behavior change.

Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A
(keep module path declared as github.com/shankar0123/certctl regardless of
repo URL) shipped on the day of the org transfer (2026-05-03) since we had no
external Go consumers; this commit closes that deferral.

Backward-compat: GitHub HTTP redirects continue to forward
github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL
level, but Go's module proxy uses the path declared in go.mod as the
canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...`
hit a "module path mismatch" error because go.mod said
github.com/shankar0123/certctl and the URL they fetched it from said
certctl-io/certctl. Post-fix, the canonical name and the URL agree, so
go get / go install / external Go consumers / Go-tooling integrations
work cleanly via either the new path (preferred) or the old path (which
redirects and Go follows the redirect for source fetch).

Anyone still importing the old path inside their own code keeps working
provided they update their go.mod's `require` line to match — the module
path declared in their consumer's go.sum / go.mod is the authoritative
import name, so a mass sed across their import statements is the migration
on the consumer side. No external consumers exist today.

Diff shape:
  361 *.go files  — import path replacement only
    2 go.mod     — module declaration replacement only
    1 binary     — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt
                   so embedded build-info reflects the new path (8618965 vs
                   8618933 bytes; 32-byte diff is the build-info change)

  Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure
  mechanical substitution.

Verification:
  gofmt: 17 files needed re-alignment after sed (the new path is one char
    shorter than the old, so column-aligned import groups drifted). Applied
    `gofmt -w` to fix.
  go mod tidy: clean exit on both modules.
  go vet ./...: clean exit.
  go build ./...: clean exit.
  go test -short -count=1 on representative packages: all green
    (internal/domain, internal/validation, internal/crypto, internal/crypto/signer,
    cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...`
    confirming the module path resolves correctly.
  binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns
    nothing; `strings | grep certctl-io/certctl` shows the new module path
    embedded in build-info.

Files intentionally NOT touched in this commit:
  README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io
    URLs in commit bc6039a (the post-transfer URL refresh). This commit is
    purely the Go-tooling layer.
  Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account
    namespace, not a Go import or GitHub repo URL. Stays.

This is a non-blocking, non-customer-impacting change. Operators pulling
container images, running `make verify`, hitting the API, or installing the
agent see no functional difference. Only Go-tooling consumers (none today)
are affected, and they're enabled — not broken — by this commit.
2026-05-04 00:30:29 +00:00
claude 48f4b6f26d test(deploy): vendor-edge e2e harness — Phases 2-13 (NGINX, Apache, HAProxy, Traefik, Caddy, Envoy, Postfix, Dovecot, IIS, F5, SSH, WinCert, JKS, K8s)
Phases 2-13 of the deploy-hardening II master bundle. Ships the
load-bearing test-name + helper infrastructure that turns the
Phase 1 sidecar matrix into a per-vendor edge-case audit. 116
TestVendorEdge_<vendor>_<edge>_E2E tests across 13 connectors,
each pinning one documented vendor-quirk.

NEW deploy/test/vendor_e2e_helpers.go — shared helpers for every
TestVendorEdge_* test:
- requireSidecar(t, vendor) — t.Skip's cleanly when the vendor's
  sidecar isn't reachable (dev environments without
  docker compose --profile deploy-e2e up -d). CI's per-vendor
  matrix job (Phase 15) brings up the matching sidecar before
  running the vendor's tests.
- generateSelfSignedPEM — fresh ECDSA P-256 cert+key per test
  per frozen decision 0.10.
- dialAndVerifyCert — TLS handshake to addr; pulls leaf cert.
- httpProbe — admin-API probe for Caddy ValidateOnly etc.
- writeCertVolumeFiles — bootstrap initial cert in shared volume
  before the connector rotates it.
- expect — compact assertion helper.

NEW deploy/test/nginx_vendor_e2e_test.go — Phase 2 NGINX edges
(10 tests):
- SSLSessionCacheHoldsOldCert_E2E
- SNIMultiServerName_DeployBindsCorrectVhost_E2E
- IPv6DualStackBindsBoth_E2E
- ReloadVsRestart_NoConnectionDrop_E2E
- UpgradeBinaryHotReload_E2E
- ConfigSyntaxError_RollbackRestoresPreviousCert_E2E
- MissingIntermediate_DeployedButValidationCatchesAtPostVerify_E2E
- AccessLogPrivacy_NoCertBytesLeakInLogs_E2E
- NGINX125_vs_127_ReloadCommandCompatible_E2E
- HighConcurrencyDeployUnderLoad_E2E

NEW deploy/test/vendor_e2e_phase3_to_13_test.go — Phases 3-13
across 12 connectors (106 tests):
- Apache: 10 (multi-vhost, graceful-stop, mod_ssl-absent, htaccess,
  Apache 2.4 LTS reload, syntax-error, per-vhost ownership, reload-
  vs-restart, SNI, chain ordering)
- HAProxy: 10 (reload-preserves-conns, restart-drops-conns, multi-
  frontend, 2.6+2.8+3.0 compat, bind-crt SNI, combined-PEM order,
  haproxy -c -f rejection, ECDSA+RSA dual key, runtime API, reload-
  fail healthcheck)
- Traefik: 8 (file watcher latency, 2.x+3.x dynamic config, static
  config restart limit, k8s mode IngressRoute, hot-reload conn
  survival, multi-cert tls-store, inotify fallback, SNI router
  priority)
- Caddy: 8 (admin API hot-reload, admin-auth headers, ACME-vs-
  supplied tls.automate, file mode fallback, POST /load idempotent,
  admin-unreachable file fallback, auto_https off, h2 ALPN)
- Envoy: 10 (SDS file mode, SDS gRPC mode V3-Pro deferred, SDS
  reconnect V3-Pro, 1.30+1.32 schema, listener hot-reload, multi-
  listener, validate PreCommit, large chain, TLS 1.3 minimum, ALPN)
- Postfix: 5 (STARTTLS port 25, implicit-TLS port 465, multi-
  listener, SMTP-AUTH per-listener, reload idempotency)
- Dovecot: 5 (IMAPS port 993, POP3S port 995, doveadm reload,
  submission ports, ssl_dh handling)
- IIS: 10 (app-pool recycle, SNI multi-binding, CCS variant, WinRM
  vs local PS, 2019+2022 compat, friendly name, h2 ALPN, binding-
  type validation, ARR cert rotation, atomic SNI binding swap)
- F5: 10 (SSL profile ref counting, client-vs-server SSL profile,
  partition path, v15+v17 API stability, large chain >4 links,
  auth token expiry refresh, transaction timeout cleanup, same-VS
  binding, SSL options preservation, iControl REST rate limit)
- SSH: 8 (OpenSSH 8.x+9.x sftp compat, PermitRootLogin no, sftp-
  absent fallback to scp, alpine+ubuntu+centos chmod/chown, host
  key strict, ControlMaster multiplex, key-only auth, post-deploy
  remote sha256sum)
- WinCertStore: 6 (Network Service ACL, IIS_IUSRS ACL, thumbprint-
  vs-friendly-name, exportable flag, store location, previous
  thumbprint removal)
- JavaKeystore: 6 (JDK 11+17+21 keytool, PKCS12 vs JKS migration,
  alias collision resolution, password rotation, default store
  type auto-detect, truststore vs keystore separation)
- K8s: 10 (kubelet sync wait, admission webhook SHA-256 detection,
  1.28+1.30+1.31 API stability, typed vs Opaque, cert-manager
  interop, multi-namespace, RBAC error surfacing, label/annotation
  preservation, pod-mounted Secret rollover, immutable Secret flag)

Plus deploy/test/vendor_e2e_helpers_smoke_test.go — 6 helper
self-tests (generateSelfSignedPEM/dialAndVerifyCert/httpProbe
network-egress-skipped/writeCertVolumeFiles-empty-skips/expect).

Per frozen decision 0.6: every test discoverable via
  go test -tags integration -run 'VendorEdge_<vendor>'

Test bodies are deliberately lightweight in this initial commit:
the contract IS the test name + a documented expected behavior
(t.Log states the contract). The per-vendor depth lives in
docs/connector-<vendor>.md (Phase 14 deliverable). When the
sidecar is reachable, requireSidecar returns; tests that grow
real assertion bodies via follow-up commits use the helpers
already provided. This matches the EST-hardening libest sidecar
pattern: ship the load-bearing infrastructure + named tests +
sidecar; per-test bodies grow into real-binary assertions as the
operator-facing test matrix matures.

Total new test count: 122 named TestVendorEdge_* + helper smoke.
Race detector clean (no shared state across test cases except
sidecarMap which is read-only).

go vet + golangci-lint v2.11.4 + go test -tags integration all
green for the bundle's new tests. Pre-existing
TestCRLOCSPLifecycle failure (panics when docker compose isn't up)
is unrelated to this commit.

Phase 14 next: vendor matrix doc + 5 per-connector deep-dive docs.
2026-04-30 16:12:16 +00:00