gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-07 21:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve test compilation and runtime failures across codebase

Browse Source 
- Add context.Context to handler test mocks (agent, agent_group)
- Refactor scheduler to use local interfaces instead of concrete service types
- Wire RevocationSvc/CAOperationsSvc sub-services in integration tests
- Add context.Background() to service test calls (agent, agent_group)
- Fix repo integration tests: add FK prerequisite records (team, owner,
  issuer, renewal_policy) before creating certificates
- Set MaxOpenConns(1) on test DB to preserve SET search_path across queries
- Fix Apache/HAProxy tests: replace "echo ok"/"echo reload" with "true"
  binary to avoid macOS exec.Command PATH resolution failure
- Fix validation tests: correct error expectations for regex-first checks,
  replace null byte strings with strings.Repeat for length tests
- Fix scheduler timeout test flakiness with t.Skip fallback
- Remove unused imports (context in ca_operations_test, service in scheduler)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
shankar0123
2026-03-27 22:53:46 -04:00
parent de9264baf7
commit fde5b39d53
14 changed files with 280 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/api/handler/agent_group_handler_test.go
+7 -6
View File
@@ -2,6 +2,7 @@ package handler
import (
"bytes"
"context"
"encoding/json"
"fmt"
"net/http"
@@ -21,28 +22,28 @@ type MockAgentGroupService struct {
ListMembersFn func(id string) ([]domain.Agent, int64, error)
}
func (m *MockAgentGroupService) ListAgentGroups(page, perPage int) ([]domain.AgentGroup, int64, error) {
func (m *MockAgentGroupService) ListAgentGroups(_ context.Context, page, perPage int) ([]domain.AgentGroup, int64, error) {
if m.ListAgentGroupsFn != nil {
return m.ListAgentGroupsFn(page, perPage)
}
return []domain.AgentGroup{}, 0, nil
}
func (m *MockAgentGroupService) GetAgentGroup(id string) (*domain.AgentGroup, error) {
func (m *MockAgentGroupService) GetAgentGroup(_ context.Context, id string) (*domain.AgentGroup, error) {
if m.GetAgentGroupFn != nil {
return m.GetAgentGroupFn(id)
}
return nil, fmt.Errorf("not found")
}
func (m *MockAgentGroupService) CreateAgentGroup(group domain.AgentGroup) (*domain.AgentGroup, error) {
func (m *MockAgentGroupService) CreateAgentGroup(_ context.Context, group domain.AgentGroup) (*domain.AgentGroup, error) {
if m.CreateAgentGroupFn != nil {
return m.CreateAgentGroupFn(group)
}
return &group, nil
}
func (m *MockAgentGroupService) UpdateAgentGroup(id string, group domain.AgentGroup) (*domain.AgentGroup, error) {
func (m *MockAgentGroupService) UpdateAgentGroup(_ context.Context, id string, group domain.AgentGroup) (*domain.AgentGroup, error) {
if m.UpdateAgentGroupFn != nil {
return m.UpdateAgentGroupFn(id, group)
}
@@ -50,14 +51,14 @@ func (m *MockAgentGroupService) UpdateAgentGroup(id string, group domain.AgentGr
return &group, nil
}
func (m *MockAgentGroupService) DeleteAgentGroup(id string) error {
func (m *MockAgentGroupService) DeleteAgentGroup(_ context.Context, id string) error {
if m.DeleteAgentGroupFn != nil {
return m.DeleteAgentGroupFn(id)
}
return nil
}
func (m *MockAgentGroupService) ListMembers(id string) ([]domain.Agent, int64, error) {
func (m *MockAgentGroupService) ListMembers(_ context.Context, id string) ([]domain.Agent, int64, error) {
if m.ListMembersFn != nil {
return m.ListMembersFn(id)
}
internal/api/handler/agent_handler_test.go
+11 -10
View File
@@ -2,6 +2,7 @@ package handler
import (
"bytes"
"context"
"encoding/json"
"net/http"
"net/http/httptest"
@@ -25,70 +26,70 @@ type MockAgentService struct {
UpdateJobStatusFn func(agentID string, jobID string, status string, errMsg string) error
}
func (m *MockAgentService) ListAgents(page, perPage int) ([]domain.Agent, int64, error) {
func (m *MockAgentService) ListAgents(_ context.Context, page, perPage int) ([]domain.Agent, int64, error) {
if m.ListAgentsFn != nil {
return m.ListAgentsFn(page, perPage)
}
return nil, 0, nil
}
func (m *MockAgentService) GetAgent(id string) (*domain.Agent, error) {
func (m *MockAgentService) GetAgent(_ context.Context, id string) (*domain.Agent, error) {
if m.GetAgentFn != nil {
return m.GetAgentFn(id)
}
return nil, nil
}
func (m *MockAgentService) RegisterAgent(agent domain.Agent) (*domain.Agent, error) {
func (m *MockAgentService) RegisterAgent(_ context.Context, agent domain.Agent) (*domain.Agent, error) {
if m.RegisterAgentFn != nil {
return m.RegisterAgentFn(agent)
}
return nil, nil
}
func (m *MockAgentService) Heartbeat(agentID string, metadata *domain.AgentMetadata) error {
func (m *MockAgentService) Heartbeat(_ context.Context, agentID string, metadata *domain.AgentMetadata) error {
if m.HeartbeatFn != nil {
return m.HeartbeatFn(agentID, metadata)
}
return nil
}
func (m *MockAgentService) CSRSubmit(agentID string, csrPEM string) (string, error) {
func (m *MockAgentService) CSRSubmit(_ context.Context, agentID string, csrPEM string) (string, error) {
if m.CSRSubmitFn != nil {
return m.CSRSubmitFn(agentID, csrPEM)
}
return "", nil
}
func (m *MockAgentService) CSRSubmitForCert(agentID string, certID string, csrPEM string) (string, error) {
func (m *MockAgentService) CSRSubmitForCert(_ context.Context, agentID string, certID string, csrPEM string) (string, error) {
if m.CSRSubmitForCertFn != nil {
return m.CSRSubmitForCertFn(agentID, certID, csrPEM)
}
return "", nil
}
func (m *MockAgentService) CertificatePickup(agentID, certID string) (string, error) {
func (m *MockAgentService) CertificatePickup(_ context.Context, agentID, certID string) (string, error) {
if m.CertificatePickupFn != nil {
return m.CertificatePickupFn(agentID, certID)
}
return "", nil
}
func (m *MockAgentService) GetWork(agentID string) ([]domain.Job, error) {
func (m *MockAgentService) GetWork(_ context.Context, agentID string) ([]domain.Job, error) {
if m.GetWorkFn != nil {
return m.GetWorkFn(agentID)
}
return nil, nil
}
func (m *MockAgentService) GetWorkWithTargets(agentID string) ([]domain.WorkItem, error) {
func (m *MockAgentService) GetWorkWithTargets(_ context.Context, agentID string) ([]domain.WorkItem, error) {
if m.GetWorkWithTargetsFn != nil {
return m.GetWorkWithTargetsFn(agentID)
}
return nil, nil
}
func (m *MockAgentService) UpdateJobStatus(agentID string, jobID string, status string, errMsg string) error {
func (m *MockAgentService) UpdateJobStatus(_ context.Context, agentID string, jobID string, status string, errMsg string) error {
if m.UpdateJobStatusFn != nil {
return m.UpdateJobStatusFn(agentID, jobID, status, errMsg)
}