gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-11 00:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve golangci-lint issues in wincertstore connector

Browse Source 
Remove unnecessary fmt.Sprintf wrapping a string literal (staticcheck S1039),
remove unused tempFileForPFX function, and clean up unused os import.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Shankar
2026-04-05 19:16:34 -04:00
parent e05424d188
commit ecee45967e
1 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/connector/target/wincertstore/wincertstore.go
+1 -19
View File
@@ -14,7 +14,6 @@ import (
"encoding/json" "encoding/json"
"fmt" "fmt"
"log/slog" "log/slog"
"os"
"os/exec" "os/exec"
"regexp" "regexp"
"strings" "strings"
@@ -242,7 +241,7 @@ func (c *Connector) buildImportScript(pfxB64, pfxPassword, thumbprint string) st
// Remove expired certs with same subject (optional) // Remove expired certs with same subject (optional)
if c.config.RemoveExpired { if c.config.RemoveExpired {
sb.WriteString(fmt.Sprintf(" $subject = $cert.Subject\n")) sb.WriteString(" $subject = $cert.Subject\n")
sb.WriteString(fmt.Sprintf(" Get-ChildItem 'Cert:\\%s\\%s' | Where-Object { $_.Subject -eq $subject -and $_.NotAfter -lt (Get-Date) -and $_.Thumbprint -ne '%s' } | Remove-Item -Force\n", sb.WriteString(fmt.Sprintf(" Get-ChildItem 'Cert:\\%s\\%s' | Where-Object { $_.Subject -eq $subject -and $_.NotAfter -lt (Get-Date) -and $_.Thumbprint -ne '%s' } | Remove-Item -Force\n",
c.config.StoreLocation, c.config.StoreName, thumbprint)) c.config.StoreLocation, c.config.StoreName, thumbprint))
} }
@@ -312,20 +311,3 @@ func (c *Connector) ValidateDeployment(ctx context.Context, request target.Valid
// Ensure Connector implements target.Connector. // Ensure Connector implements target.Connector.
var _ target.Connector = (*Connector)(nil) var _ target.Connector = (*Connector)(nil)
// tempFileForPFX is a helper used only in WinRM mode — writes PFX to temp file.
// In WinRM mode, the PFX is base64-encoded and transferred in the PowerShell script
// (same pattern as IIS WinRM deployment).
func tempFileForPFX(pfxData []byte) (string, func(), error) {
f, err := os.CreateTemp("", "certctl-pfx-*.pfx")
if err != nil {
return "", nil, fmt.Errorf("create temp PFX file: %w", err)
}
if _, err := f.Write(pfxData); err != nil {
f.Close()
os.Remove(f.Name())
return "", nil, fmt.Errorf("write temp PFX file: %w", err)
}
f.Close()
cleanup := func() { os.Remove(f.Name()) }
return f.Name(), cleanup, nil
}