gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-13 11:38:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

M-2 PR-B: Collapse IssuerService + TargetService to ctx-first signatures

Browse Source 
- Delete bare TestConnection wrapper in IssuerService; rename
  TestConnectionWithContext → TestConnection
- Delete TestTargetConnection delegate shim in TargetService (canonical
  TestConnection already ctx-first)
- Add ctx first param to 10 handler-interface methods
  (ListIssuers/GetIssuer/CreateIssuer/UpdateIssuer/DeleteIssuer and
  ListTargets/GetTarget/CreateTarget/UpdateTarget/DeleteTarget)
- Replace 16 context.Background() call sites with received ctx
- Thread r.Context() through 12 HTTP handler sites in issuers.go and
  targets.go (outer TargetHandler.TestTargetConnection HTTP method name
  preserved for router compatibility)
- Update MockIssuerService, MockTargetService, and mockTargetService
  (integration) for ctx-first forwarding; update test callsite literals

Audit complete. Commit: 1f6cf0eafa. Sections: 12. Findings: 2/7/10/4/6.
This commit is contained in:
shankar0123
2026-04-18 00:46:58 +00:00
parent bbb628243f
commit eb14236166
9 changed files with 150 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/service/target_test.go
+12 -6
View File
@@ -344,7 +344,8 @@ func TestTargetService_ListTargets_Success(t *testing.T) {
targetRepo.AddTarget(target2)
// Call handler-interface method
targets, total, err := svc.ListTargets(1, 50)
ctx := context.Background()
targets, total, err := svc.ListTargets(ctx, 1, 50)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
@@ -364,7 +365,8 @@ func TestTargetService_GetTarget_Success(t *testing.T) {
target := &domain.DeploymentTarget{ID: "t-1", Name: "Target 1", Type: domain.TargetTypeNGINX}
targetRepo.AddTarget(target)
result, err := svc.GetTarget("t-1")
ctx := context.Background()
result, err := svc.GetTarget(ctx, "t-1")
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
@@ -382,7 +384,8 @@ func TestTargetService_CreateTarget_Success(t *testing.T) {
Type: domain.TargetTypeNGINX,
}
result, err := svc.CreateTarget(target)
ctx := context.Background()
result, err := svc.CreateTarget(ctx, target)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
@@ -405,7 +408,8 @@ func TestTargetService_CreateTarget_InvalidType(t *testing.T) {
Type: domain.TargetType("Unknown"),
}
_, err := svc.CreateTarget(target)
ctx := context.Background()
_, err := svc.CreateTarget(ctx, target)
if err == nil {
t.Fatalf("expected error for invalid type, got nil")
}
@@ -424,7 +428,8 @@ func TestTargetService_UpdateTarget_Success(t *testing.T) {
Type: domain.TargetTypeApache,
}
result, err := svc.UpdateTarget("t-1", updated)
ctx := context.Background()
result, err := svc.UpdateTarget(ctx, "t-1", updated)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
@@ -442,7 +447,8 @@ func TestTargetService_DeleteTarget_Success(t *testing.T) {
targetRepo.AddTarget(target)
// Delete it
err := svc.DeleteTarget("t-1")
ctx := context.Background()
err := svc.DeleteTarget(ctx, "t-1")
if err != nil {
t.Fatalf("unexpected error: %v", err)
}