mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-12 23:18:52 +00:00
G-1: renewal-policies API + frontend FK-drift fix
Three frontend call sites (OnboardingWizard.tsx:603, CertificatesPage.tsx:52,
CertificateDetailPage.tsx:169) populated the renewal_policy_id dropdown from
getPolicies() — the compliance-rule endpoint returning pol-* IDs — which
violated the FK managed_certificates.renewal_policy_id REFERENCES
renewal_policies(id) ON DELETE RESTRICT. Create would fail pg 23503 at insert.
Backend (new):
- RenewalPolicyRepository CRUD + ListAll/ExistsByID (pg 23503 → ErrRenewalPolicyInUse
→ HTTP 409; pg 23505 → ErrRenewalPolicyDuplicateName → HTTP 409)
- RenewalPolicyService with repo-only constructor. Service sentinels
var-alias the repo sentinels so errors.Is walks across layers.
- RenewalPolicyHandler with validation bounds: name 1–255;
renewal_window_days [1,365] default 30; max_retries [0,10] not defaulted;
retry_interval_seconds [60,86400] default 3600; alert_thresholds_days
[0,365] default [30,14,7,0]. Auto-generated IDs rp-<slug(name)>.
- Router registers 5 routes under /api/v1/renewal-policies[/{id}].
Frontend:
- CertificatesPage/CertificateDetailPage/OnboardingWizard now call
getRenewalPolicies() and render rp-* IDs.
- client.ts adds getRenewalPolicies/createRenewalPolicy/updateRenewalPolicy/
deleteRenewalPolicy. types.ts adds the RenewalPolicy shape.
OpenAPI: RenewalPolicies tag + 5 operations + 3 schemas (RenewalPolicy,
RenewalPolicyCreateRequest, RenewalPolicyUpdateRequest). 409 responses
on create/update duplicate-name and delete FK-in-use.
No migration — renewal_policies table already exists from the initial
schema (000001).
Tests:
- internal/service/renewal_policy_test.go: CRUD + validation + sentinel
error wrapping.
- internal/api/handler/renewal_policy_handler_test.go: handler endpoint
contracts including 400/404/409.
- web/src/api/client.test.ts: 4 subtests covering the 4 new API functions.
Phase 3 gates all green: go vet, build, short tests, race tests (service/
handler/router/scheduler), staticcheck (G-1 packages), govulncheck (0
reachable), coverage (service 69.7%, handler 79.0%, domain 86.9%,
middleware 80.6% — all above thresholds), tsc, vitest (256 passed),
vite build, OpenAPI structural validation.
This commit is contained in:
@@ -39,7 +39,10 @@ vi.mock('../api/client', () => ({
|
||||
getProfiles: vi.fn(),
|
||||
getOwners: vi.fn(),
|
||||
getTeams: vi.fn(),
|
||||
getPolicies: vi.fn(),
|
||||
// G-1: wizard populates the renewal_policy_id dropdown from
|
||||
// getRenewalPolicies (rp-* ids), not getPolicies (which returns compliance
|
||||
// rules with pol-* ids and violates the FK).
|
||||
getRenewalPolicies: vi.fn(),
|
||||
createIssuer: vi.fn(),
|
||||
testIssuerConnection: vi.fn(),
|
||||
createCertificate: vi.fn(),
|
||||
@@ -85,7 +88,9 @@ function stubAllQueriesEmpty() {
|
||||
vi.mocked(client.getTeams).mockResolvedValue({
|
||||
data: [], total: 0, page: 1, per_page: 500,
|
||||
} as never);
|
||||
vi.mocked(client.getPolicies).mockResolvedValue({
|
||||
// G-1: wizard populates renewal_policy_id from getRenewalPolicies, not
|
||||
// getPolicies. See comment on the mock factory above.
|
||||
vi.mocked(client.getRenewalPolicies).mockResolvedValue({
|
||||
data: [], total: 0, page: 1, per_page: 500,
|
||||
} as never);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user