mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-13 09:18:52 +00:00
M-2 PR-C: Collapse Policy/Profile/Owner/Team services to ctx-first signatures
- Add ctx first param to 21 service-layer handler-interface methods
across policy.go (6), profile.go (5), owner.go (5), team.go (5)
- Replace 24 context.Background() call sites with received ctx; use
context.WithoutCancel(ctx) for subsidiary audit-recording ops to
preserve fire-and-forget audit semantics without inheriting caller
cancellation
- Add ctx first param to 21 handler-interface method signatures across
policies.go (6), profiles.go (5), owners.go (5), teams.go (5)
- Thread r.Context() through 21 HTTP handler sites (ListPolicies,
GetPolicy, CreatePolicy, UpdatePolicy, DeletePolicy, ListViolations,
ListProfiles, GetProfile, CreateProfile, UpdateProfile, DeleteProfile,
ListOwners, GetOwner, CreateOwner, UpdateOwner, DeleteOwner,
ListTeams, GetTeam, CreateTeam, UpdateTeam, DeleteTeam)
- Update MockPolicyService/MockProfileService/MockOwnerService/
MockTeamService mock method impls with _ context.Context first param
(Fn fields unchanged — closures do not need ctx); update mock impls
in integration/lifecycle_test.go for all four services
- Update 12 service-layer test callsites (policy_test.go ×2,
owner_test.go ×5, team_test.go ×5, profile_test.go ×13) to pass
context.Background() at the call site
Audit complete. Commit: 855124a9d9. Sections: 12. Findings: 2/7/10/4/6.
This commit is contained in:
@@ -638,7 +638,7 @@ func TestOwnerService_ListOwners_HandlerInterface(t *testing.T) {
|
||||
|
||||
ownerService := NewOwnerService(ownerRepo, auditService)
|
||||
|
||||
owners, total, err := ownerService.ListOwners(1, 50)
|
||||
owners, total, err := ownerService.ListOwners(context.Background(), 1, 50)
|
||||
if err != nil {
|
||||
t.Fatalf("ListOwners failed: %v", err)
|
||||
}
|
||||
@@ -678,7 +678,7 @@ func TestOwnerService_GetOwner_HandlerInterface(t *testing.T) {
|
||||
|
||||
ownerService := NewOwnerService(ownerRepo, auditService)
|
||||
|
||||
retrieved, err := ownerService.GetOwner("owner-001")
|
||||
retrieved, err := ownerService.GetOwner(context.Background(), "owner-001")
|
||||
if err != nil {
|
||||
t.Fatalf("GetOwner failed: %v", err)
|
||||
}
|
||||
@@ -702,7 +702,7 @@ func TestOwnerService_CreateOwner_HandlerInterface(t *testing.T) {
|
||||
TeamID: "team-001",
|
||||
}
|
||||
|
||||
created, err := ownerService.CreateOwner(owner)
|
||||
created, err := ownerService.CreateOwner(context.Background(), owner)
|
||||
if err != nil {
|
||||
t.Fatalf("CreateOwner failed: %v", err)
|
||||
}
|
||||
@@ -752,7 +752,7 @@ func TestOwnerService_UpdateOwner_HandlerInterface(t *testing.T) {
|
||||
TeamID: "team-002",
|
||||
}
|
||||
|
||||
updated, err := ownerService.UpdateOwner("owner-001", updatedOwner)
|
||||
updated, err := ownerService.UpdateOwner(context.Background(), "owner-001", updatedOwner)
|
||||
if err != nil {
|
||||
t.Fatalf("UpdateOwner failed: %v", err)
|
||||
}
|
||||
@@ -798,7 +798,7 @@ func TestOwnerService_DeleteOwner_HandlerInterface(t *testing.T) {
|
||||
|
||||
ownerService := NewOwnerService(ownerRepo, auditService)
|
||||
|
||||
err := ownerService.DeleteOwner("owner-001")
|
||||
err := ownerService.DeleteOwner(context.Background(), "owner-001")
|
||||
if err != nil {
|
||||
t.Fatalf("DeleteOwner failed: %v", err)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user