mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-13 10:58:52 +00:00
M-2 PR-C: Collapse Policy/Profile/Owner/Team services to ctx-first signatures
- Add ctx first param to 21 service-layer handler-interface methods
across policy.go (6), profile.go (5), owner.go (5), team.go (5)
- Replace 24 context.Background() call sites with received ctx; use
context.WithoutCancel(ctx) for subsidiary audit-recording ops to
preserve fire-and-forget audit semantics without inheriting caller
cancellation
- Add ctx first param to 21 handler-interface method signatures across
policies.go (6), profiles.go (5), owners.go (5), teams.go (5)
- Thread r.Context() through 21 HTTP handler sites (ListPolicies,
GetPolicy, CreatePolicy, UpdatePolicy, DeletePolicy, ListViolations,
ListProfiles, GetProfile, CreateProfile, UpdateProfile, DeleteProfile,
ListOwners, GetOwner, CreateOwner, UpdateOwner, DeleteOwner,
ListTeams, GetTeam, CreateTeam, UpdateTeam, DeleteTeam)
- Update MockPolicyService/MockProfileService/MockOwnerService/
MockTeamService mock method impls with _ context.Context first param
(Fn fields unchanged — closures do not need ctx); update mock impls
in integration/lifecycle_test.go for all four services
- Update 12 service-layer test callsites (policy_test.go ×2,
owner_test.go ×5, team_test.go ×5, profile_test.go ×13) to pass
context.Background() at the call site
Audit complete. Commit: 855124a9d9. Sections: 12. Findings: 2/7/10/4/6.
This commit is contained in:
+10
-10
@@ -126,7 +126,7 @@ func (s *OwnerService) Delete(ctx context.Context, id string, actor string) erro
|
||||
}
|
||||
|
||||
// ListOwners returns paginated owners (handler interface method).
|
||||
func (s *OwnerService) ListOwners(page, perPage int) ([]domain.Owner, int64, error) {
|
||||
func (s *OwnerService) ListOwners(ctx context.Context, page, perPage int) ([]domain.Owner, int64, error) {
|
||||
if page < 1 {
|
||||
page = 1
|
||||
}
|
||||
@@ -134,7 +134,7 @@ func (s *OwnerService) ListOwners(page, perPage int) ([]domain.Owner, int64, err
|
||||
perPage = 50
|
||||
}
|
||||
|
||||
owners, err := s.ownerRepo.List(context.Background())
|
||||
owners, err := s.ownerRepo.List(ctx)
|
||||
if err != nil {
|
||||
return nil, 0, fmt.Errorf("failed to list owners: %w", err)
|
||||
}
|
||||
@@ -151,12 +151,12 @@ func (s *OwnerService) ListOwners(page, perPage int) ([]domain.Owner, int64, err
|
||||
}
|
||||
|
||||
// GetOwner returns a single owner (handler interface method).
|
||||
func (s *OwnerService) GetOwner(id string) (*domain.Owner, error) {
|
||||
return s.ownerRepo.Get(context.Background(), id)
|
||||
func (s *OwnerService) GetOwner(ctx context.Context, id string) (*domain.Owner, error) {
|
||||
return s.ownerRepo.Get(ctx, id)
|
||||
}
|
||||
|
||||
// CreateOwner creates a new owner (handler interface method).
|
||||
func (s *OwnerService) CreateOwner(owner domain.Owner) (*domain.Owner, error) {
|
||||
func (s *OwnerService) CreateOwner(ctx context.Context, owner domain.Owner) (*domain.Owner, error) {
|
||||
if owner.ID == "" {
|
||||
owner.ID = generateID("owner")
|
||||
}
|
||||
@@ -167,22 +167,22 @@ func (s *OwnerService) CreateOwner(owner domain.Owner) (*domain.Owner, error) {
|
||||
if owner.UpdatedAt.IsZero() {
|
||||
owner.UpdatedAt = now
|
||||
}
|
||||
if err := s.ownerRepo.Create(context.Background(), &owner); err != nil {
|
||||
if err := s.ownerRepo.Create(ctx, &owner); err != nil {
|
||||
return nil, fmt.Errorf("failed to create owner: %w", err)
|
||||
}
|
||||
return &owner, nil
|
||||
}
|
||||
|
||||
// UpdateOwner modifies an owner (handler interface method).
|
||||
func (s *OwnerService) UpdateOwner(id string, owner domain.Owner) (*domain.Owner, error) {
|
||||
func (s *OwnerService) UpdateOwner(ctx context.Context, id string, owner domain.Owner) (*domain.Owner, error) {
|
||||
owner.ID = id
|
||||
if err := s.ownerRepo.Update(context.Background(), &owner); err != nil {
|
||||
if err := s.ownerRepo.Update(ctx, &owner); err != nil {
|
||||
return nil, fmt.Errorf("failed to update owner: %w", err)
|
||||
}
|
||||
return &owner, nil
|
||||
}
|
||||
|
||||
// DeleteOwner removes an owner (handler interface method).
|
||||
func (s *OwnerService) DeleteOwner(id string) error {
|
||||
return s.ownerRepo.Delete(context.Background(), id)
|
||||
func (s *OwnerService) DeleteOwner(ctx context.Context, id string) error {
|
||||
return s.ownerRepo.Delete(ctx, id)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user