From 76f3038c0991e382f31753e8b28d421bbe97c1c5 Mon Sep 17 00:00:00 2001
From: cowork <cowork@certctl.local>
Date: Mon, 27 Apr 2026 21:48:54 +0000
Subject: [PATCH] Bundle N.A/B-extended CI follow-up: QF1002 tagged-switch fix
 in digicert
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

CI's golangci-lint flagged 3 staticcheck QF1002 hits on
internal/connector/issuer/digicert/digicert_failure_test.go at
lines 32, 51, 70 — 'could use tagged switch on r.URL.Path'.

Fix: convert each 'switch { case r.URL.Path == "/user/me": ... }'
to 'switch r.URL.Path { case "/user/me": ... }'. Same shape as
the Bundle J QF1002 fix-up.

Why digicert and not sectigo: sectigo's switches mix literal path
checks (case r.URL.Path == "/ssl/v1/types") with prefix checks
(case strings.HasPrefix(r.URL.Path, "/ssl/v1/collect/")), which
can't be expressed as a tagged switch. CI didn't flag sectigo.

Verification
=================
  - go test -short -count=1 ./internal/connector/issuer/digicert/...:
    PASS in 0.6s
  - go vet ./internal/connector/issuer/digicert/...: clean
  - staticcheck -checks=QF1002 across all extension test files:
    clean (0 hits)

Bundle: N.AB-ci-fix
---
 .../issuer/digicert/digicert_failure_test.go         | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/internal/connector/issuer/digicert/digicert_failure_test.go b/internal/connector/issuer/digicert/digicert_failure_test.go
index 7814e23..9ee545d 100644
--- a/internal/connector/issuer/digicert/digicert_failure_test.go
+++ b/internal/connector/issuer/digicert/digicert_failure_test.go
@@ -29,8 +29,8 @@ func buildDigicertConnector(t *testing.T, baseURL string) *digicert.Connector {
 
 func TestDigicert_GetOrderStatus_404_ReturnsError(t *testing.T) {
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		switch {
-		case r.URL.Path == "/user/me":
+		switch r.URL.Path {
+		case "/user/me":
 			w.WriteHeader(http.StatusOK)
 			_, _ = w.Write([]byte(`{"id":1}`))
 		default:
@@ -48,8 +48,8 @@ func TestDigicert_GetOrderStatus_404_ReturnsError(t *testing.T) {
 
 func TestDigicert_GetOrderStatus_MalformedJSON_ReturnsError(t *testing.T) {
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		switch {
-		case r.URL.Path == "/user/me":
+		switch r.URL.Path {
+		case "/user/me":
 			w.WriteHeader(http.StatusOK)
 			_, _ = w.Write([]byte(`{"id":1}`))
 		default:
@@ -67,8 +67,8 @@ func TestDigicert_GetOrderStatus_MalformedJSON_ReturnsError(t *testing.T) {
 
 func TestDigicert_GetOrderStatus_IssuedButCertIDMissing(t *testing.T) {
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		switch {
-		case r.URL.Path == "/user/me":
+		switch r.URL.Path {
+		case "/user/me":
 			w.WriteHeader(http.StatusOK)
 			_, _ = w.Write([]byte(`{"id":1}`))
 		default: