fix(ci): resolve 9 remaining staticcheck issues

- SA5011: use t.Fatal instead of t.Error before nil pointer access in
  verification handler tests (stops test execution on nil)
- SA4006: replace unused lvalues with _ in repo_test.go and team_test.go
- ST1020: fix comment format on ListViolations to match method name

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
shankar0123
2026-03-27 23:20:28 -04:00
parent 09ff51c5ae
commit c617a686d6
4 changed files with 7 additions and 7 deletions
@@ -66,7 +66,7 @@ func TestVerifyDeployment_Success(t *testing.T) {
// Verify result was recorded
result := mockSvc.results["j-test1"]
if result == nil {
t.Error("expected verification result to be recorded")
t.Fatal("expected verification result to be recorded")
}
if !result.Verified {
t.Error("expected Verified to be true")
@@ -98,7 +98,7 @@ func TestVerifyDeployment_FingerPrintMismatch(t *testing.T) {
result := mockSvc.results["j-test2"]
if result == nil {
t.Error("expected verification result to be recorded")
t.Fatal("expected verification result to be recorded")
}
if result.Verified {
t.Error("expected Verified to be false")