gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-10 14:28:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): sidebar footer simplification + onboarding doc links — operator-reported drift

Browse Source 
Two small, operator-reported regressions in the live demo:

1. SIDEBAR FOOTER
   Pre-fix the bottom-left of the sidebar had:

     Built and maintained by Shankar         <- only "Shankar" linked
     certctl                          [⎋]     <- "certctl" label + logout

   Operator dropped the "certctl" label as redundant (the brand mark +
   product name are already in the sidebar header), and asked for the
   WHOLE attribution sentence to be the LinkedIn link rather than only
   "Shankar". Post-fix the entire sidebar footer is one row:

     Built and maintained by Shankar             [⎋]

   The full sentence is now an ExternalLink to
   https://www.linkedin.com/in/shankar-k-a1b6853ba. Logout sits flush-
   right via `flex justify-between` and only renders when authRequired
   is true (unchanged contract). Same Phase 5 / Hotfix #8 chokepoint
   (ExternalLink) means the L-015 CI guard stays green — caught my
   first attempt where the explanatory comment text contained the
   literal `target="_blank"` string and the line-grep guard fired on
   the comment itself. Fixed by rephrasing the comment.

2. ONBOARDING WIZARD DOC LINKS
   The CompleteStep ("You're all set!") screen had three doc links at
   the bottom — all 404s:

     Quickstart Guide → docs/quickstart.md         (gone)
     Architecture     → docs/architecture.md       (gone)
     Connectors       → docs/connectors.md         (gone)

   Root cause: the 2026-05-04 docs overhaul reorganized into the
   audience-organized tree (`getting-started/`, `reference/`,
   `operator/`, etc.). The CompleteStep links weren't updated. Every
   operator who completed the wizard hit three 404s.

   Verified against the live repo BEFORE writing the new links — the
   exact paths that exist today:

     docs/getting-started/quickstart.md
     docs/reference/architecture.md
     docs/reference/connectors/index.md  (29 per-connector .md siblings)

   New links point at those paths. Each still uses target="_blank" +
   rel="noopener noreferrer" on the same line so the L-015 guard
   passes.

Verification:
  • npx tsc --noEmit — exits 0
  • Layout 7/7 + OnboardingWizard 4/4 = 11/11 green
  • All 34 CI guards pass (L-015 included)
  • npx vite build ✓ in 3.30s
This commit is contained in:
shankar0123
2026-05-14 18:02:51 +00:00
parent a9e229bd2a
commit c146e8f75b
2 changed files with 33 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/pages/onboarding/CompleteStep.tsx
+10 -3
View File
@@ -72,10 +72,17 @@ export default function CompleteStep({ onFinish, issuerName, certName }: {
Go to Dashboard
</button>
{/* Doc links updated 2026-05-14 to match the post-2026-05-04
audience-organized doc tree (getting-started/ + reference/).
Pre-fix the three links pointed at docs/quickstart.md,
docs/architecture.md, docs/connectors.md — none of those paths
exist any more; they were 404s the operator hit on every
successful onboarding completion. Verified against `ls docs/`
before writing. */}
<div className="flex justify-center gap-6 text-xs">
<a href="https://github.com/certctl-io/certctl/blob/master/docs/quickstart.md" target="_blank" rel="noopener noreferrer" className="text-accent hover:text-accent-bright">Quickstart Guide</a>
<a href="https://github.com/certctl-io/certctl/blob/master/docs/architecture.md" target="_blank" rel="noopener noreferrer" className="text-accent hover:text-accent-bright">Architecture</a>
<a href="https://github.com/certctl-io/certctl/blob/master/docs/connectors.md" target="_blank" rel="noopener noreferrer" className="text-accent hover:text-accent-bright">Connectors</a>
<a href="https://github.com/certctl-io/certctl/blob/master/docs/getting-started/quickstart.md" target="_blank" rel="noopener noreferrer" className="text-accent hover:text-accent-bright">Quickstart Guide</a>
<a href="https://github.com/certctl-io/certctl/blob/master/docs/reference/architecture.md" target="_blank" rel="noopener noreferrer" className="text-accent hover:text-accent-bright">Architecture</a>
<a href="https://github.com/certctl-io/certctl/blob/master/docs/reference/connectors/index.md" target="_blank" rel="noopener noreferrer" className="text-accent hover:text-accent-bright">Connectors</a>
</div>
</div>
);