gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-12 04:28:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove extra context.Context args from CRL/OCSP tests

Browse Source 
GenerateDERCRL and GetOCSPResponse don't take a context parameter,
but all 8 test calls passed context.Background() as the first arg.
Pre-existing issue never caught because CI wasn't running on v2-dev.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Shankar
2026-03-22 15:40:38 -04:00
parent 522b13e296
commit 8f8b4f2a2f
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/service/revocation_test.go
+8 -8
View File
@@ -435,7 +435,7 @@ func TestGenerateDERCRL_Success(t *testing.T) {
}, },
} }
crl, err := svc.GenerateDERCRL(context.Background(), "iss-local") crl, err := svc.GenerateDERCRL("iss-local")
if err != nil { if err != nil {
t.Fatalf("expected no error, got: %v", err) t.Fatalf("expected no error, got: %v", err)
@@ -458,7 +458,7 @@ func TestGenerateDERCRL_EmptyCRL(t *testing.T) {
// No revoked certs for this issuer // No revoked certs for this issuer
revocationRepo.Revocations = []*domain.CertificateRevocation{} revocationRepo.Revocations = []*domain.CertificateRevocation{}
crl, err := svc.GenerateDERCRL(context.Background(), "iss-local") crl, err := svc.GenerateDERCRL("iss-local")
if err != nil { if err != nil {
t.Fatalf("expected no error, got: %v", err) t.Fatalf("expected no error, got: %v", err)
@@ -479,7 +479,7 @@ func TestGenerateDERCRL_IssuerNotFound(t *testing.T) {
svc, _, _, _ := newRevocationTestService() svc, _, _, _ := newRevocationTestService()
// Try to generate CRL for unknown issuer // Try to generate CRL for unknown issuer
crl, err := svc.GenerateDERCRL(context.Background(), "iss-unknown") crl, err := svc.GenerateDERCRL("iss-unknown")
// Should return error or nil CRL depending on implementation // Should return error or nil CRL depending on implementation
if crl != nil && err == nil { if crl != nil && err == nil {
@@ -513,7 +513,7 @@ func TestGetOCSPResponse_Good(t *testing.T) {
certRepo.Versions["cert-ocsp-good"] = []*domain.CertificateVersion{version} certRepo.Versions["cert-ocsp-good"] = []*domain.CertificateVersion{version}
// Request OCSP response for good cert // Request OCSP response for good cert
resp, err := svc.GetOCSPResponse(context.Background(), "iss-local", "OCSP-GOOD-001") resp, err := svc.GetOCSPResponse("iss-local", "OCSP-GOOD-001")
if err != nil { if err != nil {
t.Fatalf("expected no error, got: %v", err) t.Fatalf("expected no error, got: %v", err)
@@ -566,7 +566,7 @@ func TestGetOCSPResponse_Revoked(t *testing.T) {
} }
// Request OCSP response for revoked cert // Request OCSP response for revoked cert
resp, err := svc.GetOCSPResponse(context.Background(), "iss-local", "OCSP-REVOKED-001") resp, err := svc.GetOCSPResponse("iss-local", "OCSP-REVOKED-001")
if err != nil { if err != nil {
t.Fatalf("expected no error, got: %v", err) t.Fatalf("expected no error, got: %v", err)
@@ -583,7 +583,7 @@ func TestGetOCSPResponse_Unknown(t *testing.T) {
svc, _, _, _ := newRevocationTestService() svc, _, _, _ := newRevocationTestService()
// Request OCSP response for unknown cert // Request OCSP response for unknown cert
resp, err := svc.GetOCSPResponse(context.Background(), "iss-local", "UNKNOWN-SERIAL") resp, err := svc.GetOCSPResponse("iss-local", "UNKNOWN-SERIAL")
if err != nil { if err != nil {
t.Fatalf("expected no error (should return unknown status), got: %v", err) t.Fatalf("expected no error (should return unknown status), got: %v", err)
@@ -601,7 +601,7 @@ func TestGetOCSPResponse_IssuerNotFound(t *testing.T) {
svc, _, _, _ := newRevocationTestService() svc, _, _, _ := newRevocationTestService()
// Request OCSP response for unknown issuer // Request OCSP response for unknown issuer
resp, err := svc.GetOCSPResponse(context.Background(), "iss-unknown", "SOME-SERIAL") resp, err := svc.GetOCSPResponse("iss-unknown", "SOME-SERIAL")
// Should return error since issuer doesn't exist // Should return error since issuer doesn't exist
if err == nil && resp != nil { if err == nil && resp != nil {
@@ -615,7 +615,7 @@ func TestGetOCSPResponse_InvalidSerial(t *testing.T) {
svc, _, _, _ := newRevocationTestService() svc, _, _, _ := newRevocationTestService()
// Request OCSP response with invalid serial format // Request OCSP response with invalid serial format
resp, err := svc.GetOCSPResponse(context.Background(), "iss-local", "") resp, err := svc.GetOCSPResponse("iss-local", "")
if err == nil && resp != nil { if err == nil && resp != nil {
// Empty serial might return unknown status; that's ok // Empty serial might return unknown status; that's ok