gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-13 06:58:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add operation-level context timeouts to scheduler loops

Browse Source 
Prevents runaway operations from blocking scheduler goroutines:
- Renewal check: 5 minute timeout
- Job processor: 2 minute timeout
- Agent health check: 1 minute timeout
- Notification processor: 1 minute timeout

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
shankar0123
2026-03-20 01:20:15 -04:00
parent 239a1792d2
commit 829c7c0064
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/scheduler/scheduler.go
+12 -4
View File
@@ -117,7 +117,9 @@ func (s *Scheduler) renewalCheckLoop(ctx context.Context) {
// runRenewalCheck executes a single renewal check with error recovery. // runRenewalCheck executes a single renewal check with error recovery.
func (s *Scheduler) runRenewalCheck(ctx context.Context) { func (s *Scheduler) runRenewalCheck(ctx context.Context) {
if err := s.renewalService.CheckExpiringCertificates(ctx); err != nil { opCtx, cancel := context.WithTimeout(ctx, 5*time.Minute)
defer cancel()
if err := s.renewalService.CheckExpiringCertificates(opCtx); err != nil {
s.logger.Error("renewal check failed", s.logger.Error("renewal check failed",
"error", err, "error", err,
"interval", s.renewalCheckInterval.String()) "interval", s.renewalCheckInterval.String())
@@ -148,7 +150,9 @@ func (s *Scheduler) jobProcessorLoop(ctx context.Context) {
// runJobProcessor executes a single job processing cycle with error recovery. // runJobProcessor executes a single job processing cycle with error recovery.
func (s *Scheduler) runJobProcessor(ctx context.Context) { func (s *Scheduler) runJobProcessor(ctx context.Context) {
if err := s.jobService.ProcessPendingJobs(ctx); err != nil { opCtx, cancel := context.WithTimeout(ctx, 2*time.Minute)
defer cancel()
if err := s.jobService.ProcessPendingJobs(opCtx); err != nil {
s.logger.Error("job processor failed", s.logger.Error("job processor failed",
"error", err, "error", err,
"interval", s.jobProcessorInterval.String()) "interval", s.jobProcessorInterval.String())
@@ -179,7 +183,9 @@ func (s *Scheduler) agentHealthCheckLoop(ctx context.Context) {
// runAgentHealthCheck executes a single agent health check with error recovery. // runAgentHealthCheck executes a single agent health check with error recovery.
func (s *Scheduler) runAgentHealthCheck(ctx context.Context) { func (s *Scheduler) runAgentHealthCheck(ctx context.Context) {
if err := s.agentService.MarkStaleAgentsOffline(ctx, s.agentHealthCheckInterval); err != nil { opCtx, cancel := context.WithTimeout(ctx, 1*time.Minute)
defer cancel()
if err := s.agentService.MarkStaleAgentsOffline(opCtx, s.agentHealthCheckInterval); err != nil {
s.logger.Error("agent health check failed", s.logger.Error("agent health check failed",
"error", err, "error", err,
"interval", s.agentHealthCheckInterval.String()) "interval", s.agentHealthCheckInterval.String())
@@ -209,7 +215,9 @@ func (s *Scheduler) notificationProcessLoop(ctx context.Context) {
// runNotificationProcess executes a single notification processing cycle with error recovery. // runNotificationProcess executes a single notification processing cycle with error recovery.
func (s *Scheduler) runNotificationProcess(ctx context.Context) { func (s *Scheduler) runNotificationProcess(ctx context.Context) {
if err := s.notificationService.ProcessPendingNotifications(ctx); err != nil { opCtx, cancel := context.WithTimeout(ctx, 1*time.Minute)
defer cancel()
if err := s.notificationService.ProcessPendingNotifications(opCtx); err != nil {
s.logger.Error("notification processor failed", s.logger.Error("notification processor failed",
"error", err, "error", err,
"interval", s.notificationProcessInterval.String()) "interval", s.notificationProcessInterval.String())