mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 13:51:36 +00:00
scheduler+db: close Phase 6 — scale hardening across pool, jitter, ETag, asyncpoll
Phase 6 of the certctl architecture diligence remediation. Five
findings across the same scheduler-and-DB-pool surface.
SCALE-M1 (Med) — DB pool default bumped 25 → 50
internal/config/config.go line 1972:
MaxConnections: getEnvInt("CERTCTL_DATABASE_MAX_CONNS", 50)
Postgres default max_connections is 100; 50 leaves headroom for
pg_dump + ad-hoc psql + a server replica without exhausting the
DB-side cap. Operator override env var unchanged. Operator-tune
ladder for larger fleets (5K / 50K certs) lives in
docs/operator/scale.md as starter values pending Phase 8 load
tests — explicitly marked TBD.
SCALE-M3 (Med) — async-CA poll budget operator-configurable
Live state was partially-already-shipped: all 4 async-CA
connectors (digicert, entrust, globalsign, sectigo) already have
per-connector CERTCTL_<NAME>_POLL_MAX_WAIT_SECONDS (Audit fix #5
closed pre-Phase-6). What was missing: a global package-default
override. Shipped:
- internal/connector/issuer/asyncpoll/asyncpoll.go gains
SetDefaultMaxWait(d) + effectiveDefaultMaxWait var + the
currentDefaultMaxWait() priority resolver.
- cmd/server/main.go reads CERTCTL_ASYNC_POLL_MAX_WAIT_SECONDS
at boot and calls SetDefaultMaxWait.
- deploy/ENVIRONMENTS.md documents the new env var (G-3 guard
green).
Naming deviation from the prompt's CERTCTL_ASYNC_POLL_MAX_ATTEMPTS:
the live code tracks wall-clock time (MaxWait), not attempt count.
Matched the existing per-connector nomenclature (_POLL_MAX_WAIT_SECONDS)
so the priority chain reads naturally.
SCALE-M5 (Med) — JitteredTicker wrapper for all 15 scheduler loops
internal/scheduler/jitter.go ships NewJitteredTicker(interval,
jitterPct) + DefaultSchedulerJitter (±10%). All 15 sites in
internal/scheduler/scheduler.go migrated from bare time.NewTicker
to NewJitteredTicker(interval, DefaultSchedulerJitter). Base
intervals unchanged; only the per-tick envelope adds ±10%
randomized delay so multiple loops with the same nominal cadence
don't co-fire and spike CPU + DB at wall-clock boundaries.
internal/scheduler/jitter_test.go pins:
- Bounded envelope (each tick within ±jitterPct of interval)
- Mean drift < 30% of nominal (sign-bug detector)
- Stop() releases the goroutine + closes C
- Stop() idempotent (no panic on repeat)
- Zero-jitter behaves like time.NewTicker
- Negative and >=1 jitterPct values clamped defensively
CI guard scripts/ci-guards/no-bare-newticker-in-scheduler.sh blocks
any future bare time.NewTicker in scheduler.go.
SCALE-L1 (Low) — renewal-sweep semaphore behavior documented
docs/operator/scale.md "Scheduler tick budgets" section explains
the per-tick concurrency semaphore (CERTCTL_RENEWAL_CONCURRENCY=25
default), the ctx-cancellation drain on tick-budget overrun, and
operator tuning advice (raise concurrency + DB pool together).
No code change — the behavior is defensible as-is per the audit.
SCALE-L2 (Low) — ETag middleware for top-5 read endpoints
internal/api/middleware/etag.go computes SHA-256 ETag over the
buffered response body, respects If-None-Match, short-circuits
to 304 Not Modified on match. GET/HEAD only; non-2xx responses
pass through unchanged. 64 KiB buffer cap degrades gracefully on
oversized responses (no caching, body still flushes intact).
Wired around the top-5 read endpoints via etagged() helper in
internal/api/router/router.go:
GET /api/v1/certificates
GET /api/v1/agents
GET /api/v1/jobs
GET /api/v1/audit
GET /api/v1/discovered-certificates
internal/api/middleware/etag_test.go pins 11 behaviors including
304-on-repeat, 200-after-mutation-with-new-ETag, POST bypass,
4xx/5xx pass-through, oversized-response degradation, wildcard
match, HEAD-treated-like-GET, byte-equal pass-through.
Cross-cutting fixes:
- internal/config/config_test.go::TestLoad_DefaultValues updated
to assert the new 50 default (was 25).
- deploy/helm/certctl/values.yaml comment corrected — agent
pollInterval is hardcoded 30s, not env-configurable; the
Phase 4 comment mistakenly referenced CERTCTL_AGENT_POLL_INTERVAL
which G-3 caught as a phantom env var.
- asyncpoll.go reformatted by gofmt; functionally unchanged.
Verification (all pass):
grep -nE 'SetMaxOpenConns' internal/repository/postgres/db.go # finds 1 site
grep -nE 'CERTCTL_DATABASE_MAX_CONNS.*50' internal/config/config.go # config default is 50
grep -rnE 'CERTCTL_ASYNC_POLL_MAX_WAIT_SECONDS' internal/ deploy/ENVIRONMENTS.md # wired
grep -cE 'time\.NewTicker\(' internal/scheduler/scheduler.go # 0 (all migrated)
grep -cE 'JitteredTicker' internal/scheduler/scheduler.go # 15
ls internal/scheduler/jitter.go internal/api/middleware/etag.go # both exist
ls docs/operator/scale.md # exists
bash scripts/ci-guards/no-bare-newticker-in-scheduler.sh # clean
bash scripts/ci-guards/G-3-env-docs-drift.sh # clean
go test ./internal/scheduler/ ./internal/api/middleware/ \
./internal/connector/issuer/asyncpoll/ ./internal/config/ # 4/4 packages green
Closes: cowork/certctl-architecture-diligence-audit.html#fix-SCALE-M1
cowork/certctl-architecture-diligence-audit.html#fix-SCALE-M3
cowork/certctl-architecture-diligence-audit.html#fix-SCALE-M5
cowork/certctl-architecture-diligence-audit.html#fix-SCALE-L1
cowork/certctl-architecture-diligence-audit.html#fix-SCALE-L2
This commit is contained in:
@@ -0,0 +1,122 @@
|
||||
// Copyright 2026 certctl LLC. All rights reserved.
|
||||
// SPDX-License-Identifier: BUSL-1.1
|
||||
|
||||
package scheduler
|
||||
|
||||
import (
|
||||
"math/rand/v2"
|
||||
"time"
|
||||
)
|
||||
|
||||
// Phase 6 SCALE-M5 closure (2026-05-14): bounded-jitter wrapper
|
||||
// around time.Timer to spread scheduler-loop tick co-fires.
|
||||
//
|
||||
// Pre-Phase-6 the 15 scheduler loops in scheduler.go each used a
|
||||
// bare time.NewTicker(interval). When multiple loops share a
|
||||
// nominal cadence (e.g. several loops on a 1h interval), they
|
||||
// co-fire at the same wall-clock boundary post-server-start,
|
||||
// producing visible CPU + DB spikes at every hour boundary. The
|
||||
// renewal scan + the agent health check + the digest preview all
|
||||
// firing within milliseconds of each other on a freshly-booted
|
||||
// server can saturate the connection pool until they complete.
|
||||
//
|
||||
// JitteredTicker replaces the bare time.NewTicker with a goroutine
|
||||
// that fires C once per interval ± jitterPct, drawn fresh on every
|
||||
// tick. The base interval is the same as before; only the per-tick
|
||||
// envelope changes. This preserves every loop's expected SLO (a
|
||||
// renewal scan still runs ~once per hour) while breaking up the
|
||||
// co-fire pattern.
|
||||
//
|
||||
// JitteredTicker.Stop() must be called by the caller (typically via
|
||||
// defer) to release the goroutine. After Stop, the C channel is
|
||||
// closed.
|
||||
type JitteredTicker struct {
|
||||
// C is the channel a tick fires on. Read this in the loop's
|
||||
// select{} the same way you'd read time.Ticker.C.
|
||||
C chan time.Time
|
||||
|
||||
stopCh chan struct{}
|
||||
}
|
||||
|
||||
// NewJitteredTicker returns a ticker that fires on C every
|
||||
// interval ± jitterPct (e.g. jitterPct=0.1 = ±10%). The first tick
|
||||
// arrives one (jittered) interval after construction — same as
|
||||
// time.NewTicker. jitterPct < 0 is treated as 0 (no jitter, equivalent
|
||||
// to time.NewTicker). jitterPct ≥ 1 is clamped to 0.99 (avoid the
|
||||
// degenerate "instant tick" case where the jitter consumes the
|
||||
// entire interval).
|
||||
//
|
||||
// interval must be > 0. Callers passing 0 or negative get a panic
|
||||
// from time.NewTimer, matching time.NewTicker's existing contract.
|
||||
func NewJitteredTicker(interval time.Duration, jitterPct float64) *JitteredTicker {
|
||||
if jitterPct < 0 {
|
||||
jitterPct = 0
|
||||
}
|
||||
if jitterPct >= 1 {
|
||||
jitterPct = 0.99
|
||||
}
|
||||
|
||||
jt := &JitteredTicker{
|
||||
C: make(chan time.Time, 1),
|
||||
stopCh: make(chan struct{}),
|
||||
}
|
||||
|
||||
go jt.run(interval, jitterPct)
|
||||
return jt
|
||||
}
|
||||
|
||||
// run owns the per-tick scheduling loop. The fresh-per-tick jitter
|
||||
// draw prevents drift from compounding (vs. computing the jittered
|
||||
// interval once and reusing it).
|
||||
func (jt *JitteredTicker) run(interval time.Duration, jitterPct float64) {
|
||||
defer close(jt.C)
|
||||
|
||||
for {
|
||||
// Bounded-symmetric jitter around the interval. delta ∈
|
||||
// [-jitterPct, +jitterPct) drawn fresh per tick.
|
||||
delta := (rand.Float64()*2 - 1) * jitterPct
|
||||
next := time.Duration(float64(interval) * (1 + delta))
|
||||
// Floor at 1ns so we never feed a zero or negative
|
||||
// duration into time.NewTimer; the jitterPct clamp above
|
||||
// keeps next > 0 in normal use but a Float64 rounding
|
||||
// edge case could otherwise produce 0.
|
||||
if next < time.Nanosecond {
|
||||
next = time.Nanosecond
|
||||
}
|
||||
|
||||
timer := time.NewTimer(next)
|
||||
select {
|
||||
case t := <-timer.C:
|
||||
select {
|
||||
case jt.C <- t:
|
||||
// emitted
|
||||
case <-jt.stopCh:
|
||||
return
|
||||
}
|
||||
case <-jt.stopCh:
|
||||
if !timer.Stop() {
|
||||
<-timer.C
|
||||
}
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Stop releases the goroutine + closes C. Safe to call multiple
|
||||
// times; subsequent calls are no-ops (the stopCh close is the
|
||||
// only side effect, and re-closing a closed channel would panic,
|
||||
// so we guard via a select+default).
|
||||
func (jt *JitteredTicker) Stop() {
|
||||
select {
|
||||
case <-jt.stopCh:
|
||||
// already closed; no-op
|
||||
default:
|
||||
close(jt.stopCh)
|
||||
}
|
||||
}
|
||||
|
||||
// DefaultSchedulerJitter is the jitter percentage applied to every
|
||||
// scheduler-loop tick. ±10% is the industry-standard "spread but
|
||||
// don't blur SLO" envelope used by Kubernetes controllers, AWS SDK
|
||||
// retries, and Prometheus scrape intervals.
|
||||
const DefaultSchedulerJitter = 0.10
|
||||
@@ -0,0 +1,198 @@
|
||||
// Copyright 2026 certctl LLC. All rights reserved.
|
||||
// SPDX-License-Identifier: BUSL-1.1
|
||||
|
||||
package scheduler
|
||||
|
||||
import (
|
||||
"math"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// Phase 6 SCALE-M5 contract pin (2026-05-14): JitteredTicker fires
|
||||
// ~interval per tick with a bounded ±jitterPct envelope. The tests
|
||||
// below are timing-sensitive but use generous tolerances + averaging
|
||||
// across many ticks to stay stable under CI load.
|
||||
|
||||
func TestJitteredTicker_BoundedEnvelope(t *testing.T) {
|
||||
const (
|
||||
interval = 20 * time.Millisecond
|
||||
jitterPct = 0.20 // ±20%
|
||||
ticks = 30
|
||||
)
|
||||
|
||||
jt := NewJitteredTicker(interval, jitterPct)
|
||||
defer jt.Stop()
|
||||
|
||||
last := time.Now()
|
||||
for i := 0; i < ticks; i++ {
|
||||
select {
|
||||
case now := <-jt.C:
|
||||
gap := now.Sub(last)
|
||||
last = now
|
||||
|
||||
// Bounded envelope: every tick should fall within
|
||||
// [interval × (1-jitter), interval × (1+jitter)] plus a
|
||||
// generous scheduling-slop tolerance for the test
|
||||
// runtime. The first tick is allowed wider slop since
|
||||
// goroutine startup may eat into the first interval.
|
||||
minGap := time.Duration(float64(interval) * (1 - jitterPct))
|
||||
maxGap := time.Duration(float64(interval)*(1+jitterPct)) + 50*time.Millisecond
|
||||
if i == 0 {
|
||||
minGap = 0 // first tick can land arbitrarily fast under CI scheduling pressure
|
||||
}
|
||||
|
||||
if gap < minGap || gap > maxGap {
|
||||
t.Errorf("tick %d gap=%v outside envelope [%v, %v]", i, gap, minGap, maxGap)
|
||||
}
|
||||
case <-time.After(5 * interval):
|
||||
t.Fatalf("tick %d timed out (>5×interval); JitteredTicker stuck", i)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestJitteredTicker_MeanCloseToInterval(t *testing.T) {
|
||||
// Statistical pin: across many ticks the mean gap should be
|
||||
// reasonably close to the nominal interval. Larger deviations
|
||||
// indicate the jitter draw is biased (e.g. only producing
|
||||
// positive deltas because of a sign bug — mean would drift to
|
||||
// interval × 1.3 instead of staying near interval × 1.0).
|
||||
//
|
||||
// The 50ms interval + 50-tick sample is chosen so per-scheduler-
|
||||
// quantum jitter (~1ms on Linux) is < 2% of the interval; the
|
||||
// 30% bound below is generous enough for CI scheduling noise
|
||||
// while still catching sign bugs (which would push mean drift
|
||||
// past 30% trivially).
|
||||
const (
|
||||
interval = 50 * time.Millisecond
|
||||
jitterPct = 0.30
|
||||
ticks = 50
|
||||
)
|
||||
|
||||
jt := NewJitteredTicker(interval, jitterPct)
|
||||
defer jt.Stop()
|
||||
|
||||
gaps := make([]time.Duration, 0, ticks)
|
||||
last := time.Now()
|
||||
|
||||
for i := 0; i < ticks; i++ {
|
||||
select {
|
||||
case now := <-jt.C:
|
||||
if i > 0 { // skip first gap (goroutine warmup)
|
||||
gaps = append(gaps, now.Sub(last))
|
||||
}
|
||||
last = now
|
||||
case <-time.After(5 * interval):
|
||||
t.Fatalf("tick %d timed out", i)
|
||||
}
|
||||
}
|
||||
|
||||
var sum time.Duration
|
||||
for _, g := range gaps {
|
||||
sum += g
|
||||
}
|
||||
mean := sum / time.Duration(len(gaps))
|
||||
|
||||
// Sign-bug threshold: a healthy jittered ticker should produce
|
||||
// mean ≈ interval (mean drift < 10%). A sign bug (e.g.
|
||||
// always-positive jitter) shifts mean to interval × (1 +
|
||||
// jitterPct / 2) = +15%. 30% bound catches that while
|
||||
// tolerating CI scheduling noise + the (1 - x) vs (1 + x)
|
||||
// asymmetry of multiplicative jitter.
|
||||
driftPct := math.Abs(float64(mean-interval)) / float64(interval)
|
||||
if driftPct > 0.30 {
|
||||
t.Errorf("mean gap %v drifts %.1f%% from nominal interval %v (>30%% threshold)", mean, driftPct*100, interval)
|
||||
}
|
||||
}
|
||||
|
||||
func TestJitteredTicker_Stop_ReleasesGoroutine(t *testing.T) {
|
||||
jt := NewJitteredTicker(50*time.Millisecond, 0.10)
|
||||
|
||||
// Stop immediately, before any tick fires.
|
||||
jt.Stop()
|
||||
|
||||
// C should close within one tick interval. If it doesn't, the
|
||||
// goroutine is stuck (which would leak in production).
|
||||
select {
|
||||
case _, ok := <-jt.C:
|
||||
if ok {
|
||||
// A tick fired before C closed — also acceptable, but
|
||||
// drain it and re-check that close follows.
|
||||
select {
|
||||
case _, ok2 := <-jt.C:
|
||||
if ok2 {
|
||||
t.Errorf("JitteredTicker.C still emitting after Stop()")
|
||||
}
|
||||
case <-time.After(200 * time.Millisecond):
|
||||
t.Errorf("JitteredTicker.C did not close after Stop()")
|
||||
}
|
||||
}
|
||||
case <-time.After(200 * time.Millisecond):
|
||||
t.Errorf("JitteredTicker.C did not close within 200ms of Stop()")
|
||||
}
|
||||
}
|
||||
|
||||
func TestJitteredTicker_Stop_Idempotent(t *testing.T) {
|
||||
jt := NewJitteredTicker(50*time.Millisecond, 0.10)
|
||||
|
||||
// Multiple Stop() calls must not panic.
|
||||
jt.Stop()
|
||||
jt.Stop()
|
||||
jt.Stop()
|
||||
}
|
||||
|
||||
func TestJitteredTicker_ZeroJitter_BehavesLikeTicker(t *testing.T) {
|
||||
// jitterPct=0 reduces to a deterministic ticker. The mean
|
||||
// should be exactly the interval (modulo scheduling noise).
|
||||
const (
|
||||
interval = 20 * time.Millisecond
|
||||
ticks = 10
|
||||
)
|
||||
|
||||
jt := NewJitteredTicker(interval, 0)
|
||||
defer jt.Stop()
|
||||
|
||||
last := time.Now()
|
||||
for i := 0; i < ticks; i++ {
|
||||
select {
|
||||
case now := <-jt.C:
|
||||
gap := now.Sub(last)
|
||||
last = now
|
||||
// Allow generous slop for CI scheduling.
|
||||
if i > 0 && (gap < interval/2 || gap > interval*3) {
|
||||
t.Errorf("zero-jitter tick %d gap=%v far from interval=%v", i, gap, interval)
|
||||
}
|
||||
case <-time.After(5 * interval):
|
||||
t.Fatalf("zero-jitter tick %d timed out", i)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestJitteredTicker_NegativeJitter_TreatedAsZero(t *testing.T) {
|
||||
// Defensive: negative jitterPct should not produce
|
||||
// negative-duration timers (which would panic time.NewTimer).
|
||||
jt := NewJitteredTicker(10*time.Millisecond, -0.5)
|
||||
defer jt.Stop()
|
||||
|
||||
// Just confirm at least one tick fires without panic.
|
||||
select {
|
||||
case <-jt.C:
|
||||
// ok
|
||||
case <-time.After(100 * time.Millisecond):
|
||||
t.Errorf("negative-jitter ticker produced no tick within 100ms")
|
||||
}
|
||||
}
|
||||
|
||||
func TestJitteredTicker_LargeJitter_ClampedBelowOne(t *testing.T) {
|
||||
// Defensive: jitterPct≥1 would otherwise allow next=0 and panic
|
||||
// time.NewTimer. Confirm the ticker still fires.
|
||||
jt := NewJitteredTicker(10*time.Millisecond, 1.5)
|
||||
defer jt.Stop()
|
||||
|
||||
select {
|
||||
case <-jt.C:
|
||||
// ok
|
||||
case <-time.After(100 * time.Millisecond):
|
||||
t.Errorf("over-clamped-jitter ticker produced no tick within 100ms")
|
||||
}
|
||||
}
|
||||
@@ -473,7 +473,7 @@ func (s *Scheduler) Start(ctx context.Context) <-chan struct{} {
|
||||
// If an error occurs, it logs the error but continues running.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous check is still running.
|
||||
func (s *Scheduler) renewalCheckLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.renewalCheckInterval)
|
||||
ticker := NewJitteredTicker(s.renewalCheckInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -522,7 +522,7 @@ func (s *Scheduler) runRenewalCheck(ctx context.Context) {
|
||||
// If an error occurs, it logs the error but continues running.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous job is still running.
|
||||
func (s *Scheduler) jobProcessorLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.jobProcessorInterval)
|
||||
ticker := NewJitteredTicker(s.jobProcessorInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -573,7 +573,7 @@ func (s *Scheduler) runJobProcessor(ctx context.Context) {
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous retry sweep
|
||||
// is still running.
|
||||
func (s *Scheduler) jobRetryLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.jobRetryInterval)
|
||||
ticker := NewJitteredTicker(s.jobRetryInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -628,7 +628,7 @@ func (s *Scheduler) runJobRetry(ctx context.Context) {
|
||||
// retry loop then auto-promotes eligible Failed jobs back to Pending. Closes
|
||||
// coverage gap I-003. Uses atomic.Bool to prevent duplicate execution.
|
||||
func (s *Scheduler) jobTimeoutLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.jobTimeoutInterval)
|
||||
ticker := NewJitteredTicker(s.jobTimeoutInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -706,7 +706,7 @@ func (s *Scheduler) runJobTimeout(ctx context.Context) {
|
||||
// If an error occurs, it logs the error but continues running.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous check is still running.
|
||||
func (s *Scheduler) agentHealthCheckLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.agentHealthCheckInterval)
|
||||
ticker := NewJitteredTicker(s.agentHealthCheckInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -754,7 +754,7 @@ func (s *Scheduler) runAgentHealthCheck(ctx context.Context) {
|
||||
// If an error occurs, it logs the error but continues running.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous process is still running.
|
||||
func (s *Scheduler) notificationProcessLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.notificationProcessInterval)
|
||||
ticker := NewJitteredTicker(s.notificationProcessInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -806,7 +806,7 @@ func (s *Scheduler) runNotificationProcess(ctx context.Context) {
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous retry sweep
|
||||
// is still running. Mirrors the I-001 jobRetryLoop topology byte-for-byte.
|
||||
func (s *Scheduler) notificationRetryLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.notificationRetryInterval)
|
||||
ticker := NewJitteredTicker(s.notificationRetryInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -861,7 +861,7 @@ func (s *Scheduler) runNotificationRetry(ctx context.Context) {
|
||||
// no CRL/OCSP needed.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous check is still running.
|
||||
func (s *Scheduler) shortLivedExpiryCheckLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.shortLivedExpiryCheckInterval)
|
||||
ticker := NewJitteredTicker(s.shortLivedExpiryCheckInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -909,7 +909,7 @@ func (s *Scheduler) runShortLivedExpiryCheck(ctx context.Context) {
|
||||
// of configured network targets.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous scan is still running.
|
||||
func (s *Scheduler) networkScanLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.networkScanInterval)
|
||||
ticker := NewJitteredTicker(s.networkScanInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -956,7 +956,7 @@ func (s *Scheduler) runNetworkScan(ctx context.Context) {
|
||||
// digestLoop runs every digestInterval and generates/sends certificate digest emails.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous digest is still running.
|
||||
func (s *Scheduler) digestLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.digestInterval)
|
||||
ticker := NewJitteredTicker(s.digestInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Do NOT run immediately on start for digest — wait for the first tick.
|
||||
@@ -999,7 +999,7 @@ func (s *Scheduler) runDigest(ctx context.Context) {
|
||||
// resource-intensive. Wait for the first tick.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous check is still running.
|
||||
func (s *Scheduler) healthCheckLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.healthCheckInterval)
|
||||
ticker := NewJitteredTicker(s.healthCheckInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Do NOT run immediately on start for health checks — wait for the first tick.
|
||||
@@ -1041,7 +1041,7 @@ func (s *Scheduler) runHealthCheck(ctx context.Context) {
|
||||
// Runs immediately on start, then on each tick. Same idempotency pattern as networkScanLoop.
|
||||
// Uses atomic.Bool to prevent duplicate execution if the previous scan is still running.
|
||||
func (s *Scheduler) cloudDiscoveryLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.cloudDiscoveryInterval)
|
||||
ticker := NewJitteredTicker(s.cloudDiscoveryInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Run immediately on start (with idempotency guard)
|
||||
@@ -1121,7 +1121,7 @@ func (s *Scheduler) WaitForCompletion(timeout time.Duration) error {
|
||||
//
|
||||
// Bundle CRL/OCSP-Responder Phase 3.
|
||||
func (s *Scheduler) crlGenerationLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.crlGenerationInterval)
|
||||
ticker := NewJitteredTicker(s.crlGenerationInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
// Do NOT run immediately on start. CRLs are typically valid for
|
||||
@@ -1171,7 +1171,7 @@ var ErrSchedulerShutdownTimeout = errors.New("scheduler graceful shutdown timeou
|
||||
// sync.WaitGroup tracks the in-flight goroutine for graceful shutdown.
|
||||
// Phase 5.
|
||||
func (s *Scheduler) acmeGCLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.acmeGCInterval)
|
||||
ticker := NewJitteredTicker(s.acmeGCInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
for {
|
||||
@@ -1212,7 +1212,7 @@ func (s *Scheduler) acmeGCLoop(ctx context.Context) {
|
||||
// file: a stuck Postgres can't block the next tick, and concurrent
|
||||
// sweeps are skipped not queued.
|
||||
func (s *Scheduler) sessionGCLoop(ctx context.Context) {
|
||||
ticker := time.NewTicker(s.sessionGCInterval)
|
||||
ticker := NewJitteredTicker(s.sessionGCInterval, DefaultSchedulerJitter)
|
||||
defer ticker.Stop()
|
||||
|
||||
for {
|
||||
|
||||
Reference in New Issue
Block a user