chore(fmt): repo-wide gofmt -w sweep — close drift surfaced by ci-pipeline-cleanup Phase 4

Mechanical reformat. The new 'gofmt drift' CI step (added in
ci-pipeline-cleanup Phase 4, commit 0f205a8) surfaced 111 files
with accumulated gofmt drift across cmd/, internal/, and deploy/test/.

Each file's diff is gofmt-standard: whitespace adjustments, intra-
group import sorting (alphabetical by import path within blank-line-
separated groups), and struct-tag column alignment. No semantic
changes — verified via 'git diff --ignore-all-space' which shows only
the line-position deltas from import reordering.

The gate stays in place after this commit. Going forward it catches
gofmt drift at PR time.
This commit is contained in:
shankar0123
2026-04-30 22:33:57 +00:00
parent e2298c8222
commit 7cb453a336
111 changed files with 761 additions and 770 deletions
+5 -5
View File
@@ -34,16 +34,16 @@ import (
"github.com/shankar0123/certctl/internal/connector/target/apache" "github.com/shankar0123/certctl/internal/connector/target/apache"
"github.com/shankar0123/certctl/internal/connector/target/caddy" "github.com/shankar0123/certctl/internal/connector/target/caddy"
"github.com/shankar0123/certctl/internal/connector/target/envoy" "github.com/shankar0123/certctl/internal/connector/target/envoy"
pf "github.com/shankar0123/certctl/internal/connector/target/postfix"
sshconn "github.com/shankar0123/certctl/internal/connector/target/ssh"
"github.com/shankar0123/certctl/internal/connector/target/f5" "github.com/shankar0123/certctl/internal/connector/target/f5"
jks "github.com/shankar0123/certctl/internal/connector/target/javakeystore"
k8s "github.com/shankar0123/certctl/internal/connector/target/k8ssecret"
wcs "github.com/shankar0123/certctl/internal/connector/target/wincertstore"
"github.com/shankar0123/certctl/internal/connector/target/haproxy" "github.com/shankar0123/certctl/internal/connector/target/haproxy"
"github.com/shankar0123/certctl/internal/connector/target/iis" "github.com/shankar0123/certctl/internal/connector/target/iis"
jks "github.com/shankar0123/certctl/internal/connector/target/javakeystore"
k8s "github.com/shankar0123/certctl/internal/connector/target/k8ssecret"
"github.com/shankar0123/certctl/internal/connector/target/nginx" "github.com/shankar0123/certctl/internal/connector/target/nginx"
pf "github.com/shankar0123/certctl/internal/connector/target/postfix"
sshconn "github.com/shankar0123/certctl/internal/connector/target/ssh"
"github.com/shankar0123/certctl/internal/connector/target/traefik" "github.com/shankar0123/certctl/internal/connector/target/traefik"
wcs "github.com/shankar0123/certctl/internal/connector/target/wincertstore"
) )
// AgentConfig represents the agent-side configuration. // AgentConfig represents the agent-side configuration.
+2 -2
View File
@@ -1,10 +1,10 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"errors"
"context" "context"
"encoding/json" "encoding/json"
"errors"
"github.com/shankar0123/certctl/internal/repository"
"net/http" "net/http"
"strconv" "strconv"
"strings" "strings"
+1 -1
View File
@@ -1,10 +1,10 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"encoding/json" "encoding/json"
"errors" "errors"
"github.com/shankar0123/certctl/internal/repository"
"log/slog" "log/slog"
"net/http" "net/http"
"strconv" "strconv"
+1 -1
View File
@@ -9,8 +9,8 @@ import (
"testing" "testing"
"time" "time"
"github.com/shankar0123/certctl/internal/domain"
"github.com/shankar0123/certctl/internal/api/middleware" "github.com/shankar0123/certctl/internal/api/middleware"
"github.com/shankar0123/certctl/internal/domain"
) )
// mockAuditService implements AuditService for testing. // mockAuditService implements AuditService for testing.
+2 -2
View File
@@ -1,11 +1,11 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"errors"
"context" "context"
"encoding/json" "encoding/json"
"errors"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"log/slog" "log/slog"
"net/http" "net/http"
"strings" "strings"
+2 -2
View File
@@ -1,10 +1,10 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"errors"
"context" "context"
"encoding/json" "encoding/json"
"errors"
"github.com/shankar0123/certctl/internal/repository"
"log/slog" "log/slog"
"net/http" "net/http"
"strconv" "strconv"
+1 -1
View File
@@ -1,10 +1,10 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"encoding/json" "encoding/json"
"errors" "errors"
"github.com/shankar0123/certctl/internal/repository"
"io" "io"
"net/http" "net/http"
"strconv" "strconv"
+2 -2
View File
@@ -1,9 +1,9 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"errors"
"context" "context"
"errors"
"github.com/shankar0123/certctl/internal/repository"
"net/http" "net/http"
"strconv" "strconv"
"strings" "strings"
+2 -2
View File
@@ -1,10 +1,10 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"errors"
"context" "context"
"encoding/json" "encoding/json"
"errors"
"github.com/shankar0123/certctl/internal/repository"
"net/http" "net/http"
"strconv" "strconv"
"strings" "strings"
+2 -2
View File
@@ -1,10 +1,10 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"errors"
"context" "context"
"encoding/json" "encoding/json"
"errors"
"github.com/shankar0123/certctl/internal/repository"
"net/http" "net/http"
"strconv" "strconv"
"strings" "strings"
+1 -1
View File
@@ -1,10 +1,10 @@
package handler package handler
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"encoding/json" "encoding/json"
"errors" "errors"
"github.com/shankar0123/certctl/internal/repository"
"net/http" "net/http"
"strconv" "strconv"
"strings" "strings"
+1
View File
@@ -1091,6 +1091,7 @@ func TestGetEnvBool(t *testing.T) {
}) })
} }
} }
// I-003: Job timeout reaper configuration tests // I-003: Job timeout reaper configuration tests
func TestConfig_Scheduler_JobTimeoutDefaults(t *testing.T) { func TestConfig_Scheduler_JobTimeoutDefaults(t *testing.T) {
clearCertctlEnv(t) clearCertctlEnv(t)
@@ -369,4 +369,3 @@ func TestSource_Discover_AgentIDAndSourcePath(t *testing.T) {
t.Errorf("expected source path 'aws-sm://eu-west-1/my-secret', got %s", report.Certificates[0].SourcePath) t.Errorf("expected source path 'aws-sm://eu-west-1/my-secret', got %s", report.Certificates[0].SourcePath)
} }
} }
@@ -249,4 +249,3 @@ func signJWS(key *ecdsa.PrivateKey, kid, nonce, targetURL string, payload []byte
return json.Marshal(jws) return json.Marshal(jws)
} }
@@ -1770,4 +1770,3 @@ func TestIntegration_FullLifecycle(t *testing.T) {
t.Errorf("Expected status 'completed', got '%s'", status.Status) t.Errorf("Expected status 'completed', got '%s'", status.Status)
} }
} }
@@ -644,4 +644,3 @@ func contains(s, substr string) bool {
} }
return false return false
} }
@@ -310,4 +310,3 @@ func (c *Connector) ValidateDeployment(ctx context.Context, request target.Valid
// Ensure Connector implements target.Connector. // Ensure Connector implements target.Connector.
var _ target.Connector = (*Connector)(nil) var _ target.Connector = (*Connector)(nil)
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"time" "time"
"github.com/google/uuid" "github.com/google/uuid"
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"time" "time"
"github.com/shankar0123/certctl/internal/domain" "github.com/shankar0123/certctl/internal/domain"
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"github.com/google/uuid" "github.com/google/uuid"
"github.com/shankar0123/certctl/internal/domain" "github.com/shankar0123/certctl/internal/domain"
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"time" "time"
"github.com/google/uuid" "github.com/google/uuid"
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"time" "time"
"github.com/lib/pq" "github.com/lib/pq"
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"github.com/google/uuid" "github.com/google/uuid"
"github.com/shankar0123/certctl/internal/domain" "github.com/shankar0123/certctl/internal/domain"
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"github.com/shankar0123/certctl/internal/domain" "github.com/shankar0123/certctl/internal/domain"
) )
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"github.com/google/uuid" "github.com/google/uuid"
"github.com/shankar0123/certctl/internal/domain" "github.com/shankar0123/certctl/internal/domain"
+1 -1
View File
@@ -1,10 +1,10 @@
package postgres package postgres
import ( import (
"github.com/shankar0123/certctl/internal/repository"
"context" "context"
"database/sql" "database/sql"
"fmt" "fmt"
"github.com/shankar0123/certctl/internal/repository"
"github.com/google/uuid" "github.com/google/uuid"
"github.com/shankar0123/certctl/internal/domain" "github.com/shankar0123/certctl/internal/domain"
-1
View File
@@ -138,7 +138,6 @@ func (m *mockJobService) RetryFailedJobs(ctx context.Context, maxRetries int) er
return nil return nil
} }
// ReapTimedOutJobs is the scheduler-driven counterpart to ProcessPendingJobs that // ReapTimedOutJobs is the scheduler-driven counterpart to ProcessPendingJobs that
// covers coverage gap I-003: JobService.ReapTimedOutJobs (via JobReaperService interface) // covers coverage gap I-003: JobService.ReapTimedOutJobs (via JobReaperService interface)
// had no runtime caller prior to the jobTimeoutLoop being wired. // had no runtime caller prior to the jobTimeoutLoop being wired.
-1
View File
@@ -10,7 +10,6 @@ import (
"github.com/shankar0123/certctl/internal/domain" "github.com/shankar0123/certctl/internal/domain"
) )
func TestRegisterAgent(t *testing.T) { func TestRegisterAgent(t *testing.T) {
ctx := context.Background() ctx := context.Background()
agentRepo := &mockAgentRepo{ agentRepo := &mockAgentRepo{
+1 -1
View File
@@ -1,12 +1,12 @@
package service package service
import ( import (
"time"
"context" "context"
"errors" "errors"
"fmt" "fmt"
"log/slog" "log/slog"
"strings" "strings"
"time"
"github.com/shankar0123/certctl/internal/domain" "github.com/shankar0123/certctl/internal/domain"
"github.com/shankar0123/certctl/internal/repository" "github.com/shankar0123/certctl/internal/repository"
-2
View File
@@ -1313,7 +1313,6 @@ func TestFailJob_SetsFailedStatus(t *testing.T) {
} }
} }
// --- CreateDeploymentJobs Tests --- // --- CreateDeploymentJobs Tests ---
func TestCreateDeploymentJobs_PartialFailure(t *testing.T) { func TestCreateDeploymentJobs_PartialFailure(t *testing.T) {
@@ -1383,5 +1382,4 @@ func TestCreateDeploymentJobs_PartialFailure(t *testing.T) {
} }
} }
// stringPtr is defined in notification_test.go // stringPtr is defined in notification_test.go
-1
View File
@@ -525,4 +525,3 @@ func TestSanitizeForShell(t *testing.T) {
}) })
} }
} }