gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-10 09:08:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bundle N.A/B-extended CI follow-up: QF1002 tagged-switch fix in digicert

Browse Source 
CI's golangci-lint flagged 3 staticcheck QF1002 hits on
internal/connector/issuer/digicert/digicert_failure_test.go at
lines 32, 51, 70 — 'could use tagged switch on r.URL.Path'.

Fix: convert each 'switch { case r.URL.Path == "/user/me": ... }'
to 'switch r.URL.Path { case "/user/me": ... }'. Same shape as
the Bundle J QF1002 fix-up.

Why digicert and not sectigo: sectigo's switches mix literal path
checks (case r.URL.Path == "/ssl/v1/types") with prefix checks
(case strings.HasPrefix(r.URL.Path, "/ssl/v1/collect/")), which
can't be expressed as a tagged switch. CI didn't flag sectigo.

Verification
=================
  - go test -short -count=1 ./internal/connector/issuer/digicert/...:
    PASS in 0.6s
  - go vet ./internal/connector/issuer/digicert/...: clean
  - staticcheck -checks=QF1002 across all extension test files:
    clean (0 hits)

Bundle: N.AB-ci-fix
This commit is contained in:
shankar0123
2026-04-27 21:48:54 +00:00
parent 76be79661d
commit 6cf7ae05d6
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/connector/issuer/digicert/digicert_failure_test.go
+6 -6
View File
@@ -29,8 +29,8 @@ func buildDigicertConnector(t *testing.T, baseURL string) *digicert.Connector {
func TestDigicert_GetOrderStatus_404_ReturnsError(t *testing.T) { func TestDigicert_GetOrderStatus_404_ReturnsError(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch { switch r.URL.Path {
case r.URL.Path == "/user/me": case "/user/me":
w.WriteHeader(http.StatusOK) w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`{"id":1}`)) _, _ = w.Write([]byte(`{"id":1}`))
default: default:
@@ -48,8 +48,8 @@ func TestDigicert_GetOrderStatus_404_ReturnsError(t *testing.T) {
func TestDigicert_GetOrderStatus_MalformedJSON_ReturnsError(t *testing.T) { func TestDigicert_GetOrderStatus_MalformedJSON_ReturnsError(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch { switch r.URL.Path {
case r.URL.Path == "/user/me": case "/user/me":
w.WriteHeader(http.StatusOK) w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`{"id":1}`)) _, _ = w.Write([]byte(`{"id":1}`))
default: default:
@@ -67,8 +67,8 @@ func TestDigicert_GetOrderStatus_MalformedJSON_ReturnsError(t *testing.T) {
func TestDigicert_GetOrderStatus_IssuedButCertIDMissing(t *testing.T) { func TestDigicert_GetOrderStatus_IssuedButCertIDMissing(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch { switch r.URL.Path {
case r.URL.Path == "/user/me": case "/user/me":
w.WriteHeader(http.StatusOK) w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`{"id":1}`)) _, _ = w.Write([]byte(`{"id":1}`))
default: default: