mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-12 10:18:52 +00:00
feat: M15a — certificate revocation API, CRL endpoint, and revocation notifications
Implements core revocation infrastructure: POST /api/v1/certificates/{id}/revoke
with all 8 RFC 5280 reason codes, JSON-formatted CRL at GET /api/v1/crl, webhook
and email revocation notifications, best-effort issuer notification, and immutable
revocation audit trail. Includes 48 new tests across service, handler, integration,
and domain layers (600+ total). Fixes 3 pre-existing test bugs (team_test error
matching, agent_group delete status code, team handler per_page validation).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,57 @@
|
||||
package domain
|
||||
|
||||
import "testing"
|
||||
|
||||
func TestIsValidRevocationReason(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
reason string
|
||||
want bool
|
||||
}{
|
||||
{"unspecified", "unspecified", true},
|
||||
{"keyCompromise", "keyCompromise", true},
|
||||
{"caCompromise", "caCompromise", true},
|
||||
{"affiliationChanged", "affiliationChanged", true},
|
||||
{"superseded", "superseded", true},
|
||||
{"cessationOfOperation", "cessationOfOperation", true},
|
||||
{"certificateHold", "certificateHold", true},
|
||||
{"privilegeWithdrawn", "privilegeWithdrawn", true},
|
||||
{"empty string", "", false},
|
||||
{"random string", "notAValidReason", false},
|
||||
{"partial match", "key", false},
|
||||
{"case sensitive", "KeyCompromise", false},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if got := IsValidRevocationReason(tt.reason); got != tt.want {
|
||||
t.Errorf("IsValidRevocationReason(%q) = %v, want %v", tt.reason, got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestCRLReasonCode(t *testing.T) {
|
||||
tests := []struct {
|
||||
reason RevocationReason
|
||||
want int
|
||||
}{
|
||||
{RevocationReasonUnspecified, 0},
|
||||
{RevocationReasonKeyCompromise, 1},
|
||||
{RevocationReasonCACompromise, 2},
|
||||
{RevocationReasonAffiliationChanged, 3},
|
||||
{RevocationReasonSuperseded, 4},
|
||||
{RevocationReasonCessationOfOperation, 5},
|
||||
{RevocationReasonCertificateHold, 6},
|
||||
{RevocationReasonPrivilegeWithdrawn, 9},
|
||||
{RevocationReason("unknown"), 0}, // falls back to unspecified
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(string(tt.reason), func(t *testing.T) {
|
||||
if got := CRLReasonCode(tt.reason); got != tt.want {
|
||||
t.Errorf("CRLReasonCode(%q) = %d, want %d", tt.reason, got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user