gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-11 04:58:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(auth/rbac): scope_type+scope_id+expires_at on role grants (HIGH-10)

Browse Source 
Audit 2026-05-10 — close HIGH-10 from the HANDOFF.md backend batch
(item 1). Per-actor scoped + time-bound role grants are now
expressible via the API.

Migration 000043: adds scope_type TEXT NOT NULL DEFAULT 'global' +
scope_id TEXT to actor_roles. Constraints:
  - actor_roles_scope_type_enum: scope_type ∈ {global, profile, issuer}
  - actor_roles_scope_id_required_when_not_global: scope_id is NULL
    iff scope_type='global'
  - Uniqueness extended: (actor_id, actor_type, role_id, scope_type,
    scope_id, tenant_id) — so an operator can grant the same role to
    the same actor scoped to multiple profiles/issuers (e.g.
    r-operator on p-finance AND on p-engineering).
Index idx_actor_roles_scope for non-global lookup hot paths.

Domain: ActorRole.ScopeType (ScopeType enum) + ScopeID (*string).
Authorizer.CheckPermission already understands the tuple via the
parallel role_permissions columns; this addition gives operators a
per-actor knob without forking roles.

Postgres repo: Grant writes scope_type+scope_id with ON CONFLICT keyed
on the new uniqueness tuple. Defaults to (global, NULL) when caller
omits.

Handler: assignRoleRequest extended with scope_type / scope_id /
expires_at. Validation:
  - role_id required (unchanged)
  - scope_type defaults to 'global'; allowed values global/profile/
    issuer; anything else → 400
  - scope_id required when scope_type ∈ {profile, issuer}; rejected
    (must be empty) when scope_type='global'
  - expires_at must be in the future when present; nil = standing

Regression matrix in internal/api/handler/auth_test.go (6 cases):
  - TestAssignRoleToKey_HIGH10_ProfileScopeBoundGrantPersists
  - TestAssignRoleToKey_HIGH10_TimeBoundGrantPersists
  - TestAssignRoleToKey_HIGH10_RejectsScopeIDWithGlobalScope
  - TestAssignRoleToKey_HIGH10_RejectsMissingScopeIDOnProfile
  - TestAssignRoleToKey_HIGH10_RejectsPastExpiry
  - TestAssignRoleToKey_HIGH10_RejectsInvalidScopeType

HIGH-10 marked CLOSED in audit-doc — the v3 deferral from the prior
session is reversed; everything lands in v2.

Refs: cowork/auth-bundles-fixes-2026-05-10/HANDOFF.md item 1
      cowork/auth-bundles-audit-2026-05-10.md HIGH-10
This commit is contained in:
shankar0123
2026-05-10 22:47:45 +00:00
parent acaa81472d
commit 551812b2ca
6 changed files with 261 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/domain/auth/types.go
+13
View File
@@ -95,6 +95,19 @@ type ActorRole struct {
ExpiresAt *time.Time `json:"expires_at,omitempty"`
GrantedBy string `json:"granted_by"`
TenantID string `json:"tenant_id"`
// Audit 2026-05-10 HIGH-10 closure — per-actor scope override on
// the grant. Pre-fix, scope was per-role only; now operators can
// grant the standing r-operator role to Alice scoped to profile-X
// via (ScopeType="profile", ScopeID="p-X"). Authorizer.CheckPermission
// already understands the tuple via role_permissions. Migration
// 000043 ships the schema columns + uniqueness extension.
//
// ScopeType ∈ {global, profile, issuer}. Empty/missing defaults
// to "global" at the persistence layer (schema column DEFAULT).
// ScopeID is required when ScopeType != "global"; nil otherwise.
ScopeType ScopeType `json:"scope_type,omitempty"`
ScopeID *string `json:"scope_id,omitempty"`
}
// ActorTypeValue is the typed-string actor identifier used in