fix(security): TICKET-009 add HTTP timeouts to notifier clients

- Added TestSlack_ClientHasTimeout to verify 10-second timeout
- Added TestTeams_ClientHasTimeout to verify 10-second timeout
- Added TestPagerDuty_ClientHasTimeout to verify 10-second timeout
- Added TestOpsGenie_ClientHasTimeout to verify 10-second timeout
- All notifiers already configured with 10 second timeout in New()
- Tests verify timeout is set and matches expected value

internal/connector/notifier/opsgenie/opsgenie_test.go

@@ -7,6 +7,7 @@ import (
 	"net/http/httptest"
 	"strings"
 	"testing"
+	"time"
 )
 
 func TestOpsGenie_Channel(t *testing.T) {
@@ -114,6 +115,17 @@ func TestOpsGenie_SendConnectionError(t *testing.T) {
 	}
 }
 
+func TestOpsGenie_ClientHasTimeout(t *testing.T) {
+	n := New(Config{APIKey: "test-key"})
+	if n.httpClient.Timeout == 0 {
+		t.Fatal("expected HTTP client timeout to be set, got 0")
+	}
+	expectedTimeout := 10 * time.Second
+	if n.httpClient.Timeout != expectedTimeout {
+		t.Errorf("expected timeout %v, got %v", expectedTimeout, n.httpClient.Timeout)
+	}
+}
+
 // urlRewriteTransport redirects all requests to a test server URL.
 type urlRewriteTransport struct {
 	target    string

internal/connector/notifier/pagerduty/pagerduty_test.go

@@ -7,6 +7,7 @@ import (
 	"net/http/httptest"
 	"strings"
 	"testing"
+	"time"
 )
 
 func TestPagerDuty_Channel(t *testing.T) {
@@ -130,6 +131,17 @@ func TestPagerDuty_SendConnectionError(t *testing.T) {
 	}
 }
 
+func TestPagerDuty_ClientHasTimeout(t *testing.T) {
+	n := New(Config{RoutingKey: "test-key"})
+	if n.httpClient.Timeout == 0 {
+		t.Fatal("expected HTTP client timeout to be set, got 0")
+	}
+	expectedTimeout := 10 * time.Second
+	if n.httpClient.Timeout != expectedTimeout {
+		t.Errorf("expected timeout %v, got %v", expectedTimeout, n.httpClient.Timeout)
+	}
+}
+
 // urlRewriteTransport redirects all requests to a test server URL.
 type urlRewriteTransport struct {
 	target    string

internal/connector/notifier/slack/slack_test.go

@@ -7,6 +7,7 @@ import (
 	"net/http/httptest"
 	"strings"
 	"testing"
+	"time"
 )
 
 func TestSlack_Channel(t *testing.T) {
@@ -105,3 +106,14 @@ func TestSlack_SendConnectionError(t *testing.T) {
 		t.Errorf("expected 'request failed' in error, got %v", err)
 	}
 }
+
+func TestSlack_ClientHasTimeout(t *testing.T) {
+	n := New(Config{WebhookURL: "https://hooks.slack.com/test"})
+	if n.httpClient.Timeout == 0 {
+		t.Fatal("expected HTTP client timeout to be set, got 0")
+	}
+	expectedTimeout := 10 * time.Second
+	if n.httpClient.Timeout != expectedTimeout {
+		t.Errorf("expected timeout %v, got %v", expectedTimeout, n.httpClient.Timeout)
+	}
+}

internal/connector/notifier/teams/teams_test.go

@@ -7,6 +7,7 @@ import (
 	"net/http/httptest"
 	"strings"
 	"testing"
+	"time"
 )
 
 func TestTeams_Channel(t *testing.T) {
@@ -89,3 +90,14 @@ func TestTeams_SendConnectionError(t *testing.T) {
 		t.Errorf("expected 'request failed' in error, got %v", err)
 	}
 }
+
+func TestTeams_ClientHasTimeout(t *testing.T) {
+	n := New(Config{WebhookURL: "https://outlook.office.com/webhook/test"})
+	if n.httpClient.Timeout == 0 {
+		t.Fatal("expected HTTP client timeout to be set, got 0")
+	}
+	expectedTimeout := 10 * time.Second
+	if n.httpClient.Timeout != expectedTimeout {
+		t.Errorf("expected timeout %v, got %v", expectedTimeout, n.httpClient.Timeout)
+	}
+}