gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-07 16:21:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(auth): ARCH-002 — relax OIDC runtime guard, full Bundle-2 stack ships

Browse Source 
Sprint 4 unified-master-audit closure. The README has advertised OIDC
SSO as a v2.1 feature (L18, L74) but cmd/server/main.go retained a
Bundle-2-Phase-0 runtime guard that os.Exit(1)'d the moment any
operator set CERTCTL_AUTH_TYPE=oidc:

    CERTCTL_AUTH_TYPE=oidc: the OIDC auth chain is not yet wired in
    this build (Auth Bundle 2 Phase 6 ships the session middleware
    that consumes this auth-type literal).

That message was true when Phase 0 landed (the literal got reserved
in ValidAuthTypes ahead of the handler chain). It's been stale since
Phase 6 shipped. As of 2026-05-16 the full stack is live:

  - session.NewService at cmd/server/main.go:394
  - oidcsvc.NewService at cmd/server/main.go:436
  - ChainAuthSessionThenBearer at cmd/server/main.go:2012
  - csrfMiddleware at cmd/server/main.go:2017
  - /auth/oidc/{login,callback,back-channel-logout} routes at router.go
  - 6 OIDC handler files in internal/api/handler/
  - 2,852 LOC in internal/auth/oidc/ + 1,632 LOC in internal/auth/session/

Fix:
  - Introduce config.IsRuntimeSupportedAuthType(AuthType) as the
    single source of truth for which auth-type literals the cmd/server
    runtime guard accepts. The set is {api-key, none, oidc} —
    every entry in ValidAuthTypes(). The helper exists so the test
    suite can pin the invariant 'ValidAuthTypes ⊆ runtime-supported'
    without grepping cmd/server source.
  - cmd/server/main.go's switch collapses to a single
    IsRuntimeSupportedAuthType check; the dedicated AuthTypeOIDC
    fail-loud case is gone. The G-1 silent-auth-downgrade invariant
    stays intact — 'jwt' is still rejected at config.Validate()
    time (never made it into ValidAuthTypes()).
  - internal/config/auth.go AuthTypeOIDC comment updated to reflect
    the post-Phase-6 reality (it was prescriptive pre-fix:
    'Once Bundle 2's session middleware + OIDC service ship, the
    runtime guard relaxes' — that condition is met).

Regression coverage:
  - TestIsRuntimeSupportedAuthType_AcceptsAllValidEntries — every
    valid type is runtime-supported (catches future drift).
  - TestIsRuntimeSupportedAuthType_AcceptsOIDC — explicit pin on
    the ARCH-002 invariant.
  - TestIsRuntimeSupportedAuthType_RejectsUnknown — 'jwt', empty,
    'saml', 'mtls', 'API-KEY' all rejected.

(Also lands the ARCH-003 keygen-mode tests in the same file —
contiguous hunk in config_test.go.)

Closes ARCH-002.
This commit is contained in:
shankar0123
2026-05-16 04:53:36 +00:00
parent 3ce05ab0a8
commit 34d5200904
3 changed files with 181 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/server/main.go
+19 -16
View File
@@ -76,27 +76,30 @@ func main() {
// the slog logger is constructed from cfg below this point; we want
// the failure to be visible regardless of log-level configuration.
//
// Auth Bundle 2 Phase 0: AuthTypeOIDC is in ValidAuthTypes() but the
// session middleware + OIDC handler chain ship in later phases. An
// operator who sets CERTCTL_AUTH_TYPE=oidc on a Bundle-2-incomplete
// deployment must NOT silently fall back to api-key (the silent
// auth-downgrade failure mode that drove G-1 in the first place).
// The OIDC case below refuses-to-start with an actionable message.
// Phase 6 of Bundle 2 (session middleware wiring) relaxes this case
// to fall through alongside the api-key + none cases.
switch config.AuthType(cfg.Auth.Type) {
case config.AuthTypeAPIKey, config.AuthTypeNone:
// ok — fall through
case config.AuthTypeOIDC:
fmt.Fprintf(os.Stderr,
"CERTCTL_AUTH_TYPE=oidc: the OIDC auth chain is not yet wired in this build (Auth Bundle 2 Phase 6 ships the session middleware that consumes this auth-type literal). Set CERTCTL_AUTH_TYPE=api-key or run an authenticating gateway with CERTCTL_AUTH_TYPE=none until Bundle 2 lands. See cowork/auth-bundle-2-prompt.md.\n")
os.Exit(1)
default:
// ARCH-002 closure (Sprint 4, 2026-05-16). Auth Bundle 2 is now
// fully wired: session.NewService at L394 + oidcsvc.NewService at
// L436 + ChainAuthSessionThenBearer at L2012 + the OIDC handler
// routes (`/auth/oidc/login`, `/auth/oidc/callback`,
// `/auth/oidc/back-channel-logout`) registered in
// internal/api/router/router.go. The pre-ARCH-002 Phase-0 guard
// that exited on AuthTypeOIDC made sense when the handler chain
// was a stub; it became a stale fail-loud after Phase 6 shipped
// and is the only thing that stopped CERTCTL_AUTH_TYPE=oidc from
// being a viable production auth mode.
//
// Post-fix: oidc falls through alongside api-key + none. The
// G-1 silent-auth-downgrade invariant stays intact — "jwt" is
// still rejected at config.Validate() time (it never made it
// into ValidAuthTypes()) and the default branch below still
// refuses any other unrecognised value at runtime.
if !config.IsRuntimeSupportedAuthType(config.AuthType(cfg.Auth.Type)) {
fmt.Fprintf(os.Stderr,
"unsupported auth type at runtime: %q (valid: %v) — config validation should have caught this; refusing to start\n",
cfg.Auth.Type, config.ValidAuthTypes())
os.Exit(1)
}
// ok — all three modes (api-key / none / oidc) route through the
// chained session-then-Bearer auth middleware constructed at L2011.
// Set up structured logging
logger := slog.New(slog.NewJSONHandler(os.Stdout, &slog.HandlerOptions{