From 2edac7e78bd10d75cc3b5bc261fd84eccbdea92d Mon Sep 17 00:00:00 2001 From: shankar0123 Date: Sat, 25 Apr 2026 15:48:39 +0000 Subject: [PATCH] fix(mcp): close staticcheck ST1021 on BulkRenew/BulkReassign input docstrings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CI on the B-1 merge (b8a4318) failed at the golangci-lint step on two ST1021 errors against internal/mcp/types.go — both pre-existed L-1 but weren't caught locally because the linter wasn't installed during the L-1 verification gates. The convention staticcheck enforces is "comment on exported type X should be of the form 'X ...'" — i.e. the doc-comment must lead with the type name (with optional article) so godoc renders correctly. Before: // L-1 master closure (cat-l-fa0c1ac07ab5): bulk-renew MCP tool input. After: // BulkRenewCertificatesInput is the MCP tool input for bulk-renew (L-1 // master closure, cat-l-fa0c1ac07ab5). Mirrors BulkRevokeCertificatesInput // field-for-field minus Reason. Same shape applied to BulkReassignCertificatesInput. The L-1 / L-2 closure rationale is preserved verbatim — only the lead-in is restructured to satisfy the godoc convention. Verification: - golangci-lint v2.11.4 (matching CI) installed locally at /dev/shm/bin - golangci-lint run ./... --timeout 5m → 0 issues - internal/mcp/... package targeted lint → 0 issues This unblocks the B-1 CI run on master. No behavioral change; doc-only edit. --- internal/mcp/types.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/mcp/types.go b/internal/mcp/types.go index d6e5c05..b725506 100644 --- a/internal/mcp/types.go +++ b/internal/mcp/types.go @@ -72,8 +72,9 @@ type BulkRevokeCertificatesInput struct { CertificateIDs []string `json:"certificate_ids,omitempty" jsonschema:"Explicit list of certificate IDs to revoke"` } -// L-1 master closure (cat-l-fa0c1ac07ab5): bulk-renew MCP tool input. -// Mirrors BulkRevokeCertificatesInput field-for-field minus Reason. +// BulkRenewCertificatesInput is the MCP tool input for bulk-renew (L-1 +// master closure, cat-l-fa0c1ac07ab5). Mirrors BulkRevokeCertificatesInput +// field-for-field minus Reason. type BulkRenewCertificatesInput struct { ProfileID string `json:"profile_id,omitempty" jsonschema:"Renew all certs matching this profile ID"` OwnerID string `json:"owner_id,omitempty" jsonschema:"Renew all certs owned by this owner"` @@ -83,8 +84,8 @@ type BulkRenewCertificatesInput struct { CertificateIDs []string `json:"certificate_ids,omitempty" jsonschema:"Explicit list of certificate IDs to renew"` } -// L-2 closure (cat-l-8a1fb258a38a): bulk-reassign MCP tool input. -// IDs-only — no criteria-mode. +// BulkReassignCertificatesInput is the MCP tool input for bulk-reassign +// (L-2 closure, cat-l-8a1fb258a38a). IDs-only — no criteria-mode. type BulkReassignCertificatesInput struct { CertificateIDs []string `json:"certificate_ids" jsonschema:"Explicit list of certificate IDs to reassign"` OwnerID string `json:"owner_id" jsonschema:"Required. New owner_id for every cert in certificate_ids"`