From 1f065d67bbcc529534a09d1c2b2786eac0164437 Mon Sep 17 00:00:00 2001
From: shankar0123 <skreddy040@gmail.com>
Date: Fri, 27 Mar 2026 21:39:15 -0400
Subject: [PATCH] fix(testing): TICKET-014 generate valid self-signed test
 certificates

The generateTestCert() function previously returned &x509.Certificate{Raw: []byte("test")},
which is not a valid DER-encoded certificate. Replace with a proper self-signed certificate
generator using ECDSA P-256 that creates valid X.509 certificates for testing.

Added imports: crypto/ecdsa, crypto/elliptic, crypto/rand, crypto/x509/pkix, math/big

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 cmd/agent/verify_test.go | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/cmd/agent/verify_test.go b/cmd/agent/verify_test.go
index ea35147..94d0eb0 100644
--- a/cmd/agent/verify_test.go
+++ b/cmd/agent/verify_test.go
@@ -2,10 +2,15 @@ package main
 
 import (
 	"context"
+	"crypto/ecdsa"
+	"crypto/elliptic"
+	"crypto/rand"
 	"crypto/x509"
+	"crypto/x509/pkix"
 	"encoding/json"
 	"encoding/pem"
 	"fmt"
+	"math/big"
 	"net"
 	"net/http"
 	"net/http/httptest"
@@ -163,10 +168,29 @@ func TestVerifyDeployment_InvalidCertPEM(t *testing.T) {
 
 // Helper function to generate a test certificate for testing
 func generateTestCert() (*x509.Certificate, error) {
-	// Return nil for basic testing; in real scenarios would generate proper cert
-	return &x509.Certificate{
-		Raw: []byte("test"),
-	}, nil
+	key, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
+	if err != nil {
+		return nil, err
+	}
+
+	template := &x509.Certificate{
+		SerialNumber: big.NewInt(1),
+		Subject: pkix.Name{
+			CommonName: "test.example.com",
+		},
+		NotBefore:             time.Now(),
+		NotAfter:              time.Now().Add(24 * time.Hour),
+		KeyUsage:              x509.KeyUsageDigitalSignature,
+		BasicConstraintsValid: true,
+		DNSNames:              []string{"test.example.com"},
+	}
+
+	certDER, err := x509.CreateCertificate(rand.Reader, template, template, &key.PublicKey, key)
+	if err != nil {
+		return nil, err
+	}
+
+	return x509.ParseCertificate(certDER)
 }
 
 func TestReportVerificationResult_Success(t *testing.T) {