M-029 Pass 3 batch C (FINAL): T-1 tests for 5 list pages — Pass 3 complete

Closes M-029 Pass 3 fully. Every src/pages/*.tsx now has a *.test.tsx peer.

Audit recon: 'comm -23 <pages> <test-peers>' returns zero (all 14 T-1-deferred

pages now covered).

Test files added (each ships render-coverage + an XSS-hardening contract):

  - HealthMonitorPage.test.tsx     endpoint URL + last_error payloads

  - JobsPage.test.tsx              type / certificate_id / agent_id /

                                    error_message payloads

  - NetworkScanPage.test.tsx       network_range / agent_id / last_scan_message

                                    payloads

  - ProfilesPage.test.tsx          profile name / description / EKUs payloads

  - AgentFleetPage.test.tsx        agent name / hostname / OS / arch / IP

                                    payloads (mirrors the M-003 MCP fence shape)

Pass 3 totals across batches A + B + C: 14 new test files, 14/14 T-1-deferred

pages closed. Each test pins three invariants:

  1. The page renders against mock data without crashing.

  2. No live <script data-xss='...'> attaches to the DOM.

  3. The literal payload appears as escaped text content (proving the page

     surfaces the data without rendering it as HTML).

M-029 status after Pass 3:

  Pass 1 — useMutation -> useTrackedMutation     COMPLETE (6 batches, 56 -> 0)

  Pass 2 — useState pagination -> useListParams  COMPLETE (CertificatesPage)

  Pass 3 — XSS-hardening test suites             COMPLETE (14/14 pages)

M-029 IS NOW READY TO CLOSE.
This commit is contained in:
Shankar
2026-04-27 03:08:18 +00:00
parent ffeb192f7f
commit 19fd938a6c
5 changed files with 401 additions and 0 deletions
+80
View File
@@ -0,0 +1,80 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
import { render, screen, waitFor, cleanup } from '@testing-library/react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { MemoryRouter } from 'react-router-dom';
import type { ReactNode } from 'react';
// -----------------------------------------------------------------------------
// M-029 Pass 3 (Audit M-026): AgentFleetPage XSS-hardening + render coverage.
// Agent name / hostname / OS / arch / IP are agent-self-reported (M-003 in
// the MCP fence path); the GUI rendering must also be XSS-safe.
// -----------------------------------------------------------------------------
vi.mock('../api/client', () => ({
getAgents: vi.fn(),
}));
import AgentFleetPage from './AgentFleetPage';
import * as client from '../api/client';
function renderWithQuery(ui: ReactNode) {
const qc = new QueryClient({
defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } },
});
return render(
<QueryClientProvider client={qc}>
<MemoryRouter>{ui}</MemoryRouter>
</QueryClientProvider>,
);
}
const xssPayload = '<script data-xss="agent-fleet">window.__xss_pwned__=1;</script>';
const xssAgent = {
id: 'a-xss-001',
name: xssPayload,
hostname: xssPayload,
os: xssPayload,
architecture: xssPayload,
ip_address: xssPayload,
version: xssPayload,
status: 'online',
last_heartbeat_at: new Date().toISOString(),
agent_group_id: 'ag-xss',
};
describe('AgentFleetPage — render + XSS hardening (M-026 / M-029 Pass 3)', () => {
beforeEach(() => {
vi.clearAllMocks();
cleanup();
delete (window as unknown as { __xss_pwned__?: number }).__xss_pwned__;
});
it('renders the page header when getAgents resolves', async () => {
vi.mocked(client.getAgents).mockResolvedValue({ data: [], total: 0, page: 1, per_page: 50 } as never);
renderWithQuery(<AgentFleetPage />);
await waitFor(() => {
expect(screen.getByText(/Agent/i)).toBeInTheDocument();
});
});
it('does NOT execute <script> payloads in agent name / hostname / OS / arch / ip', async () => {
vi.mocked(client.getAgents).mockResolvedValue({
data: [xssAgent],
total: 1,
page: 1,
per_page: 50,
} as never);
renderWithQuery(<AgentFleetPage />);
await waitFor(() => {
expect(document.body.textContent ?? '').toContain('<script data-xss="agent-fleet">');
});
const liveScripts = document.querySelectorAll('script[data-xss="agent-fleet"]');
expect(liveScripts.length, 'agent fields must not inject a live <script>').toBe(0);
expect(
(window as unknown as { __xss_pwned__?: number }).__xss_pwned__,
'agent <script> body must not have executed',
).toBeUndefined();
});
});